Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Winkler, Tomas" <tomas.winkler@intel.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     "Usyskin, Alexander" <alexander.usyskin@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [char-misc v4.4.y 2/2] mei: bus: type promotion bug in
 mei_nfc_if_version()
Thread-Topic: [char-misc v4.4.y 2/2] mei: bus: type promotion bug in
 mei_nfc_if_version()
Thread-Index: AQHUS15efZUfsgX14EOznlt0owXT76T9ZoOg
Date:   Sun, 23 Sep 2018 05:49:02 +0000
Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B9D9B4CF9@hasmsx108.ger.corp.intel.com>
References: <20180903224304.15989-1-tomas.winkler@intel.com>
 <20180903224304.15989-2-tomas.winkler@intel.com>
 <20180913123553.GJ2268@kroah.com>
In-Reply-To: <20180913123553.GJ2268@kroah.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> 
> On Tue, Sep 04, 2018 at 01:43:04AM +0300, Tomas Winkler wrote:
> > From: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > commit b40b3e9358fbafff6a4ba0f4b9658f6617146f9c upstream
> >
> > We accidentally removed the check for negative returns without
> > considering the issue of type promotion.
> > The "if_version_length" variable is type size_t so if __mei_cl_recv()
> > returns a negative then "bytes_recv" is type promoted to a high
> > positive value and treated as success.
> >
> > Cc: <stable@vger.kernel.org> # 4.4
> 
> I also need a version of this patch for 4.18.y, 4.14.y, and 4.9.y before I will
> consider adding it to 4.4.y, as we do not want anyone to ever get a
> regression moving to a new kernel.

Right, I've started from the wrong end. 
Now I've posted the patches for the rest of the required long running versions.

Thanks
Tomas