Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1485479imm; Sun, 23 Sep 2018 05:14:38 -0700 (PDT) X-Google-Smtp-Source: ACcGV61abdTRlFaqm7r8zYCN6MiqbFR53ToVwCpKOcihNxwHx3rYtLZ368NCsjMpFTJp1wdupcKN X-Received: by 2002:a63:3dc6:: with SMTP id k189-v6mr5664177pga.191.1537704878373; Sun, 23 Sep 2018 05:14:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537704878; cv=none; d=google.com; s=arc-20160816; b=JshJPc+tFK+gYA9/sYSRbcys3Sv5klUgABoHJeER525G7JcxS844VDN+nRgEgq4fSl mBK1LDKmEc/IHZrqz8cjgYVkxPXBJw/8ZFrCy5WCbpYt9VI52wEHZv9sIOtGa4oulfFz b1xBB3YZpT7XJTCo1u5/YANG3pdB9EpBQGr3+wwoVpMzE6HIjCiX47s4nHRhQLxPVETL 9VVLfflHEfxDKiGVzu23eynmb43oJURNV2eIV/WVYnSWhALefPCMAkNtF6SI3KAPt4Yg uxTb8Bdzha5YvkTpZg2Uot/hM5kdOQt+gPeT+hEbWqnZL87erNWPC08zuA5B0+5JlHN5 DpLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=2p1Qq8fDB06OaDZ7+OqIO9X0xLdgMSUERjPUsnx0lWU=; b=OlE+vNw/2b851fVabqtzfGwSVj562CyhcPLdlsPywtB+WEiV5wl5BR8sx7XpG7Rvak a5zBv9WHjV0CEyDXrU7OShFpT/Aza21FoVQwYre+3whc9U+xAXUYsJjHYvvdPPyMI0TB 2ywFQv7mWGWWtVPR29FxG/GDYQhRC5DvNwiSvDgbeh8qz7/O4fVyh+ovgTZYBgr4pVak wxUdhVwggluYXyIWuwjkRRxcSrtF3PLofYugGccc9IpoWvVaXxFFX4EYom239AMZHXpI RbVlrM1nxNwg0RcKSTvxd5JrDbIr6aiXwdHAfLbwPzfKpygSWbjadGOI5AzUJnGDxA6i oFJA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y8-v6si31433985pfm.141.2018.09.23.05.13.59; Sun, 23 Sep 2018 05:14:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726214AbeIWSLM (ORCPT + 99 others); Sun, 23 Sep 2018 14:11:12 -0400 Received: from bastet.se.axis.com ([195.60.68.11]:49018 "EHLO bastet.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726134AbeIWSLL (ORCPT ); Sun, 23 Sep 2018 14:11:11 -0400 Received: from localhost (localhost [127.0.0.1]) by bastet.se.axis.com (Postfix) with ESMTP id E9D93183C4; Sun, 23 Sep 2018 14:13:52 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at bastet.se.axis.com Received: from bastet.se.axis.com ([IPv6:::ffff:127.0.0.1]) by localhost (bastet.se.axis.com [::ffff:127.0.0.1]) (amavisd-new, port 10024) with LMTP id 7PBqM3ygVc9Y; Sun, 23 Sep 2018 14:13:52 +0200 (CEST) Received: from boulder02.se.axis.com (boulder02.se.axis.com [10.0.8.16]) by bastet.se.axis.com (Postfix) with ESMTPS id D0F3A18398; Sun, 23 Sep 2018 14:13:51 +0200 (CEST) Received: from boulder02.se.axis.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AF0D81A065; Sun, 23 Sep 2018 14:13:51 +0200 (CEST) Received: from boulder02.se.axis.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A39A81A061; Sun, 23 Sep 2018 14:13:51 +0200 (CEST) Received: from thoth.se.axis.com (unknown [10.0.2.173]) by boulder02.se.axis.com (Postfix) with ESMTP; Sun, 23 Sep 2018 14:13:51 +0200 (CEST) Received: from XBOX02.axis.com (xbox02.axis.com [10.0.5.16]) by thoth.se.axis.com (Postfix) with ESMTP id 9749D2F8E; Sun, 23 Sep 2018 14:13:51 +0200 (CEST) Received: from [10.88.41.2] (10.0.5.60) by XBOX02.axis.com (10.0.5.16) with Microsoft SMTP Server (TLS) id 15.0.1365.1; Sun, 23 Sep 2018 14:13:51 +0200 Subject: Re: [PATCH crypto-next 18/23] crypto: artpec6 - Remove VLA usage of skcipher To: Kees Cook , Herbert Xu CC: Jesper Nilsson , Lars Persson , , Ard Biesheuvel , "Eric Biggers" , linux-crypto , Linux Kernel Mailing List References: <20180919021100.3380-1-keescook@chromium.org> <20180919021100.3380-19-keescook@chromium.org> From: Lars Persson Message-ID: <29e492c8-671a-2077-043f-e4f829ba04f2@axis.com> Date: Sun, 23 Sep 2018 14:13:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180919021100.3380-19-keescook@chromium.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: sv Content-Transfer-Encoding: 7bit X-Originating-IP: [10.0.5.60] X-ClientProxiedBy: XBOX01.axis.com (10.0.5.15) To XBOX02.axis.com (10.0.5.16) X-TM-AS-GCONF: 00 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/19/18 4:10 AM, Kees Cook wrote: > In the quest to remove all stack VLA usage from the kernel[1], this > replaces struct crypto_skcipher and SKCIPHER_REQUEST_ON_STACK() usage > with struct crypto_sync_skcipher and SYNC_SKCIPHER_REQUEST_ON_STACK(), > which uses a fixed stack size. > > [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com > > Cc: Jesper Nilsson > Cc: Lars Persson > Cc: linux-arm-kernel@axis.com > Signed-off-by: Kees Cook > --- > drivers/crypto/axis/artpec6_crypto.c | 19 +++++++++---------- > 1 file changed, 9 insertions(+), 10 deletions(-) > Acked-by: Lars Persson