Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 24 Sep 2018 01:01:51 +0200
From:   Christian Brauner <christian@brauner.io>
To:     David Howells <dhowells@redhat.com>
Cc:     Miklos Szeredi <mszeredi@redhat.com>,
        Al Viro <viro@ZenIV.linux.org.uk>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] fsmount: do not use legacy MS_ flags
Message-ID: <20180923230150.32qbjhnnzy56x3yy@brauner.io>
References: <20180922161406.6beo2ob6ki2otrjx@brauner.io>
 <20180922132106.wfa6xaxwbu276qka@brauner.io>
 <20180921155455.flkf5vdrm3vgn6do@brauner.io>
 <20180920151214.15484-6-mszeredi@redhat.com>
 <20180920151214.15484-1-mszeredi@redhat.com>
 <17157.1537542475@warthog.procyon.org.uk>
 <20311.1537548756@warthog.procyon.org.uk>
 <8221.1537631312@warthog.procyon.org.uk>
 <3868.1537742717@warthog.procyon.org.uk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="glbgympmb4iviibk"
Content-Disposition: inline
In-Reply-To: <3868.1537742717@warthog.procyon.org.uk>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--glbgympmb4iviibk
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Sep 23, 2018 at 11:45:17PM +0100, David Howells wrote:
> Christian Brauner <christian@brauner.io> wrote:
>=20
> > Of course, I'm not sure what the reasons for all of the other arguments=
 to
> > this function are since it's not yet implemented.
>=20
> Well, dfd, path and atflags are pretty standard.  atflags conveys things =
like
> AT_EMPTY_PATH or AT_SYMLINK_NOFOLLOW and dfd conveys a file descriptor
> pointing to a vfs object or AT_FDCWD.
>=20
> > Seems that attr_values and attr_mask could be compacted to a single
> > attr_mask maybe?
>=20
> If you don't have a mask, you can't really do recursion.  Without the mas=
k,
> you have to supply the entire set of options absolutely - and this would =
get
> stamped on everything in the target range.
>=20
> With a mask in combination with the set of desired values, you can turn o=
n or
> off a specific subset of the attributes without affecting the rest - with=
out
> needing to know the rest.

Ok, understood. What about passing the different attrs as a struct?

struct mount_attr {
        unsigned int attr_cmd,
        unsigned int attr_values,
        unsigned int attr_mask,

};

mount_setattr(int dfd, const char *path, unsigned int atflags,
              struct mount_attr *attr);

I find that to be a little cleaner in all honesty.
One could also add a version argument similar to what we currently do
for vfs fcaps so that kernel and userspace can easily navigate
compabitility when a new member gets added or removed in later releases.

Christian

--glbgympmb4iviibk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE7btrcuORLb1XUhEwjrBW1T7ssS0FAluoG10ACgkQjrBW1T7s
sS3UbhAApTh25hvwZzNlE/pffrckUmo8cNLOhy5M5kKpT970GkroRVSzYCFiWm+8
KB1cEZeOKCUq2stSTD7WKn5j7uBsmCJkrWhQyG0/hJOuRKfc4YWI5ubezs+7XipW
gG/ZNNz/Jp7BJ0Murtb9p8N4xxRjcezu2faBPVfso99mmvg9l0yCUfKXON99MJwd
OVX/Tm10r06rDig8Ya/APVERhozkz4T8S//VHlUbaXqqO/Makzhvhth9tuwvFuO/
NK/4h3xnL3RyVLWLKyIivebEExR3TgKLiCgWXaL5LWVBiOvvJcZ/CmDAVU+LWqHP
UHsRtz2Y0cmaHuoWeHyFQIQ6mL5EFgO3SBa3pISB64V79FcwDaKAu9+ZTHwl1f0r
SPz+kA2z7vUKqgVN/RCYMNnoIk8VtZBpLt5S4SSf0WnepIuZ4FIQ4+4ZrOFd+Qmy
ereXDCnkaMsNEnhpt0tthC1Aitrv1vLZIgP9Uifq6r3y8rO3O7rKNYMo9Q1s3M5W
Ivn+dG6fFtiZLNVDphNAsHA1NbM3J+fCEKD42/7xzmsmb72TzLWH1nSE9cTsC02r
8dmmdeeI7LTN+w7/xaLKq43TW/ro0fbqsZCFcSFgCFrWpUDi7noEeqF9Md3i9F9+
9BfcDpPGLByw7D9HHgxcBci4NSZi0wB777lOx+LjIKd9TTjP4Cw=
=pdAY
-----END PGP SIGNATURE-----

--glbgympmb4iviibk--