Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2146640imm; Sun, 23 Sep 2018 21:58:43 -0700 (PDT) X-Google-Smtp-Source: ACcGV61lObXM+lcGGeStGYCKRWRyvJ7m+2KxRj2h7083JjNPvgMjq2Vz4YvB6VALui5bjrYB/kqN X-Received: by 2002:a17:902:6f10:: with SMTP id w16-v6mr8725141plk.216.1537765123651; Sun, 23 Sep 2018 21:58:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537765123; cv=none; d=google.com; s=arc-20160816; b=lnq37zW15CjRRDpuX9lX4vLLZXu8eTsKqcIHz3C7ujFzaJPXH2f734T763m7v3lOof wcuonuardzlYToE1VTAt9WpbuHNORsQmCpwIKbRa96tY3G55CtjnrTeTjkDr+npatynD pxf7VkFpz+51tnAok4dFQH1toZK7fUVxBs13YRxwV1lx1Tc1TnQctXKzDnKJ6hSbRKXm /es8R9JcwIdfRtUQZHkMdZadJvPDRbcvT+3EUdtNpBzENHBpUoeAZViWiAX19Ulpy2qu Wpok3UiRBSv1JvHsuDW6iKAUyOjaNUnFo1S8NbhR/veVJ+nn8WXOQcAKs0xzcQwjqI7d snpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:references:message-id:date :thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=0/d6wf47ZymZwPr7HJjoeltLgKmgtkQaGjzr0KX0oN8=; b=lGK88zSdH8y3WktXJCHNoHBI6WTyid/p7LcOZOtH5s1Re65hwFPi5BsbPBHOeJ0aJc vAZJUFqE8rbVo5fYdIfThHLY+3mAXhpQtyKOMSJkT0bBhixLKDQf0i3NjPubLnckCjYa hesMtLm89j+Thvyema6E1wbrOKGvhs0XIWbH5sZHYX89ZYzWaHDT6L7AVFYcT7VDMJhk iM+YIYg4CC7pENLWSzSlamyjH6LacYGr1aY06ZAzp67x5iB0klK80DoxqU1Asq2iI0gB OuKVSlzVch8Q6rbnCpW72AbE1ewtA0w2lWZ1se0eUDj7DCubkEodEZWDnBtEfX+vJJ3a aLRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=D1vbTaZv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i3-v6si34321418pld.454.2018.09.23.21.58.16; Sun, 23 Sep 2018 21:58:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=D1vbTaZv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726366AbeIXK54 (ORCPT + 99 others); Mon, 24 Sep 2018 06:57:56 -0400 Received: from smtprelay4.synopsys.com ([198.182.47.9]:39840 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725825AbeIXK5z (ORCPT ); Mon, 24 Sep 2018 06:57:55 -0400 Received: from mailhost.synopsys.com (mailhost2.synopsys.com [10.13.184.66]) by smtprelay.synopsys.com (Postfix) with ESMTP id 76DFA24E0368; Sun, 23 Sep 2018 21:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1537765060; bh=GjSoWG9m7Hck/Xvfk0x2NofYEu/ZGkm5TYCwx0vITnY=; h=From:To:CC:Subject:Date:References:From; b=D1vbTaZv3BfLgbSM7dPBaFVw3SWE0hxyQcT2VTs6Xk7vk5/uV0M7zXQs7vAZzcYtu T6+XWCqQJk30kdXtE0dIPUzsflPqN5fITaYWSvB9MCgsyVgI8QHspI7TogjTIM0x1C VhThMU6+2GxXI/MospkR52Bp4RPDJzRs4ig2eLEmxXU+E8WeG8y70y1nm2EIsJd6Wm NWKikD61RS08YsR5c+Gv/xZX29/FavhRTKZPJVzpLD+PuKqqO7mjmkWIQ8is4CvvZ9 e1aFUwQfhjR7qMSqXlh6nb+SZwt28XOHBVjC8zZgEDAiLKhIfAxDV5Wp2I0yKJHPPU y4r37NoQ6s+mg== Received: from US01WXQAHTC1.internal.synopsys.com (us01wxqahtc1.internal.synopsys.com [10.12.238.230]) by mailhost.synopsys.com (Postfix) with ESMTP id 5C89A3B26; Sun, 23 Sep 2018 21:57:40 -0700 (PDT) Received: from IN01WEHTCA.internal.synopsys.com (10.144.199.104) by US01WXQAHTC1.internal.synopsys.com (10.12.238.230) with Microsoft SMTP Server (TLS) id 14.3.361.1; Sun, 23 Sep 2018 21:57:40 -0700 Received: from IN01WEMBXB.internal.synopsys.com ([169.254.4.157]) by IN01WEHTCA.internal.synopsys.com ([::1]) with mapi id 14.03.0361.001; Mon, 24 Sep 2018 10:27:37 +0530 From: Tejas Joglekar To: Anurag Kumar Vulisha , Tejas Joglekar , "balbi@kernel.org" , "gregkh@linuxfoundation.org" CC: "v.anuragkumar@gmail.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Thinh.Nguyen@synopsys.com" , "Ajay Yugalkishore Pandey" , "joglekartejas@gmail.com" Subject: Re: [PATCH v5 0/8] usb: dwc3: Fix broken BULK stream support to dwc3 gadget driver Thread-Topic: [PATCH v5 0/8] usb: dwc3: Fix broken BULK stream support to dwc3 gadget driver Thread-Index: AQHUTQCuzSz+NUz9VEOohRr9Kn9YIg== Date: Mon, 24 Sep 2018 04:57:35 +0000 Message-ID: <6DE59E7D7B09224BB10C87AEADB5972690BC7D@IN01WEMBXB.internal.synopsys.com> References: <1537021801-23896-1-git-send-email-anurag.kumar.vulisha@xilinx.com> <6DE59E7D7B09224BB10C87AEADB5972690BB1B@IN01WEMBXB.internal.synopsys.com> Accept-Language: en-US, en-IN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.12.239.236] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Anurag,=0A= On 9/21/2018 7:36 PM, Anurag Kumar Vulisha wrote:=0A= > Hi Tejas,=0A= >=0A= >> -----Original Message-----=0A= >> From: Tejas Joglekar [mailto:Tejas.Joglekar@synopsys.com]=0A= >> Sent: Friday, September 21, 2018 7:01 PM=0A= >> To: Anurag Kumar Vulisha ; balbi@kernel.org;=0A= >> gregkh@linuxfoundation.org=0A= >> Cc: v.anuragkumar@gmail.com; linux-usb@vger.kernel.org; linux-=0A= >> kernel@vger.kernel.org; Thinh.Nguyen@synopsys.com; Ajay Yugalkishore Pan= dey=0A= >> ; joglekartejas@gmail.com=0A= >> Subject: Re: [PATCH v5 0/8] usb: dwc3: Fix broken BULK stream support to= dwc3=0A= >> gadget driver=0A= >>=0A= >> Hello Anurag,=0A= >> On 9/15/2018 8:00 PM, Anurag Kumar Vulisha wrote:=0A= >>> These patch series fixes the broken BULK streaming support in=0A= >>> dwc3 gadget driver.=0A= >>>=0A= >>> Changes in v5:=0A= >>> 1. Removed the dev_dbg prints as suggested bt "Thinh Nguyen"=0A= >>>=0A= >>> Changes in v4:=0A= >>> 1. Corrected the commit messgae and stream timeout description=0A= >>> as suggested by "Thinh Nguyen"=0A= >>>=0A= >>> Changes in v3:=0A= >>> 1. Added the changes suggested by "Thinh Nguyen"=0A= >>>=0A= >>> Changes in v2:=0A= >>> 1. Added "usb: dwc3:" in subject heading=0A= >>>=0A= >>> Anurag Kumar Vulisha (8):=0A= >>> usb: dwc3: Correct the logic for checking TRB full in=0A= >>> __dwc3_prepare_one_trb()=0A= >>> usb: dwc3: update stream id in depcmd=0A= >>> usb: dwc3: make controller clear transfer resources after complete=0A= >>> usb: dwc3: implement stream transfer timeout=0A= >>> usb: dwc3: don't issue no-op trb for stream capable endpoints=0A= >>> usb: dwc3: check for requests in started list for stream capable=0A= >>> endpoints=0A= >>> usb: dwc3: Check for IOC/LST bit in both event->status and TRB->ctrl= =0A= >>> fields=0A= >>> usb: dwc3: Check MISSED ISOC bit only for ISOC endpoints=0A= >>>=0A= >>> drivers/usb/dwc3/core.h | 7 ++++=0A= >>> drivers/usb/dwc3/gadget.c | 85=0A= >> ++++++++++++++++++++++++++++++++++++++++++-----=0A= >>> 2 files changed, 84 insertions(+), 8 deletions(-)=0A= >>>=0A= >> Tested-By: Tejas Joglekar =0A= >> I have tested this patch series except the stream transfer timeout patch= on HAPS-DX=0A= >> platform. I am not aware of exact scenarios to test the timeout patch a= nd don't have=0A= >> a test for the same.=0A= > Thanks for testing the patches. The issue mentioned in the timeout patch = (Patch 4) will=0A= > occur very rarely on the long runs and only when tested with stream capab= le host. This=0A= > issue happens only when the host & dwc3 controller go out of sync, where = the dwc3=0A= > controller may wait for host to issue prime transaction and host may wait= for the gadget=0A= > to issue ERDY. I used controller version 2.90A for testing this issue. = This issue is mentioned=0A= > in databook section 9.5.2=0A= >=0A= > Thanks,=0A= > Anurag Kumar Vulisha=0A= >=0A= >=0A= I see, as it is rare so maybe it is not seen here. I have used 3.30A for te= sting. I will keep watch on this issue during my tests.=0A= =0A= ---=0A= Thanks,=0A= Tejas Joglekar=0A=