Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 24 Sep 2018 09:04:53 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Silesh C V <svellattu@mvista.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Driver core: add bus_find_device_by_fwnode
Message-ID: <20180924070453.GA7105@kroah.com>
References: <1537763755-28871-1-git-send-email-svellattu@mvista.com>
 <20180924051832.GB1974@kroah.com>
 <CALabi0Ho9w_6PcSe6D8PmGgLfw9sYWhBS-z=KebxCPqkaM8ibw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALabi0Ho9w_6PcSe6D8PmGgLfw9sYWhBS-z=KebxCPqkaM8ibw@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Sep 24, 2018 at 12:06:13PM +0530, Silesh C V wrote:
> Hello Greg,
> On Mon, Sep 24, 2018 at 10:48 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Mon, Sep 24, 2018 at 10:05:55AM +0530, Silesh C V wrote:
> > > Some drivers need to find the device on a bus having a specific firmware
> > > node. Currently, such drivers have their own implementations to do this.
> > > Provide a helper similar to bus_find_device_by_name so that each driver
> > > does not have to reinvent this.
> >
> > Is there a second patch that uses this function?  We don't add api calls
> > that are not used.
> 
> OK. If I change, say, of_find_i2c_device_by_node,
> of_find_i2c_adapter_by_node, of_phy_find_device and
> of_find_spi_device_by_node to use this API, will that be good enough?
> If that is OK, I will send this as a series in v2.

I have no idea.  Why would you want to create a new api call with no
users?  Let's see the patch series before being able to properly judge
it...

thanks,

greg k-h