Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2463756imm; Mon, 24 Sep 2018 04:58:38 -0700 (PDT) X-Google-Smtp-Source: ACcGV63Xo4RGzE7OhQ1Dj4VuL7CsWEZSSl8nJO1p0kk2vgPB3Sq+ig2w+01qoHgxk2SP+/3R+9uH X-Received: by 2002:a17:902:7e49:: with SMTP id a9-v6mr5146543pln.149.1537790318571; Mon, 24 Sep 2018 04:58:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537790318; cv=none; d=google.com; s=arc-20160816; b=s0wbfay/X85HRR7P3kk6iZkUekHtOocRsyuCHDfJvwRBoG1AuaCvEQ5vrS5lpBv/p+ QvuZjMBBiUu/hWfRayYf9rkcQG2kZaJrzqgcVsL+bTK+SRnYZ6EXm85iAVhmCbGMnpLQ yzhuvLlEshph4/JCOq2mGxtF2x48WCi2AMv7WBaT+MqEzzukuX70RnEAlvLJcG/jMp7l 8u8pzYAZN2XOdv3E6XchAIqPWC6CwmTIpFeK9XY4ONtCihFhxmSFax7ZbAozzlgr573Q bMzSl6oFjr8xjhoXnYWe9vRLM3VMRSNfXiuAIe7lrgh14xoPT42nPzJCjnAdiw9Oah6n pjYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from; bh=w3f2hu19TV72VJpdhdbw5PwbxHZKnL06Zrlw2BuI6U8=; b=e0i74ydN8O1tWVYLfVCCWbhaa3Otw4OKqjTsO/VkXu1g9+Q/orEUDzVClBb7UDuyWi G4LzXlNI/bwGi5aQBhf7y4NkGSa+UORD5VWQu6J/1D9hcd1/QnIf3hJRIAt7+Ozlw+vL jWvCx13+bqXaPKAbCdamRoupI5Jqi9xO50ihEg5Z5cqO2YdqSW9W7EWCIdqw3/g5S7tm AYh5xCrtjaLCuyfV8ZAXjmzSCzCK3NCLpAFOnTIAT+WL5AXsXGP9RU5twJbhPUPHkVD3 HVw7eS9jX5G3SAlHZ0rPVYn20GtWuUWrgVG/MIWagHvU3Q+8sg9cPlWgyxCVv3NVq1c+ jYpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o128-v6si34295710pgo.276.2018.09.24.04.58.23; Mon, 24 Sep 2018 04:58:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730220AbeIXR7L (ORCPT + 99 others); Mon, 24 Sep 2018 13:59:11 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52212 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728835AbeIXR7K (ORCPT ); Mon, 24 Sep 2018 13:59:10 -0400 Received: from localhost (ip-213-127-77-73.ip.prioritytelecom.net [213.127.77.73]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 5A5D6D64; Mon, 24 Sep 2018 11:57:25 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wei Lu , Felix Kuehling , =?UTF-8?q?Christian=20K=C3=B6nig?= , Oded Gabbay , Sasha Levin Subject: [PATCH 4.4 59/70] drm/amdkfd: Fix error codes in kfd_get_process Date: Mon, 24 Sep 2018 13:52:58 +0200 Message-Id: <20180924113106.718096379@linuxfoundation.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20180924113058.420454070@linuxfoundation.org> References: <20180924113058.420454070@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wei Lu [ Upstream commit e47cb828eb3fca3e8999a0b9aa053dda18552071 ] Return ERR_PTR(-EINVAL) if kfd_get_process fails to find the process. This fixes kernel oopses when a child process calls KFD ioctls with a file descriptor inherited from the parent process. Signed-off-by: Wei Lu Reviewed-by: Felix Kuehling Signed-off-by: Felix Kuehling Acked-by: Christian König Signed-off-by: Oded Gabbay Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c @@ -125,6 +125,8 @@ struct kfd_process *kfd_get_process(cons return ERR_PTR(-EINVAL); process = find_process(thread); + if (!process) + return ERR_PTR(-EINVAL); return process; }