Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2466047imm; Mon, 24 Sep 2018 05:00:53 -0700 (PDT) X-Google-Smtp-Source: ACcGV60WovKRZ1gr7EwNyqS1dURaNVKoVLWOiZWh245dPn+dS8tgCrM26Pw7i+sEpUEdpYVie1yI X-Received: by 2002:a17:902:5ac1:: with SMTP id g1-v6mr10322773plm.161.1537790453567; Mon, 24 Sep 2018 05:00:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537790453; cv=none; d=google.com; s=arc-20160816; b=HWNVYg8sUsykQXHSZXw0b923kG/3SwKxTmfe9qbDq1qar4YwoKlX3wUunV6hc4tYfh IMBPcv1upKpefIc2QoqdWuosL+/Rx7Z+IdctN1l5jdn692+sRSV8wP6wYnVRzUPsNSN9 74iUuOXQfmaIGVoufKdBYuab8GfNWJbDd6NqdCAFW19GP3J60YCxMg9tnhiAh6dp317Q BTqE31oapDXrhmUWC0TvmQxNlAnwmeUekt0ACcCuPMrIgZi4LcD7asxdzEUsNaRvE3hv /1+M6hwTUTCEwQlXZWEuutHbHHDG/kfYTKAv35Qnkog+bw4S4ZaOt/hrltnnEzhcb1uJ RTSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from; bh=oN9lxvG4yd1/Ivtw+YuCda10A7AbLGYpGWgeYIw1Sfo=; b=is7LwxSz9NaqchYGZYsOCWhOqttFmIyZeA9JOKicXxcTlmsld6OE4h9xZSICsimNYh 9CoAiBZnFHW4+4NZ7yWx5eVbIvc4oZXns2pQOI64bipcufrZ7vXb8FtVRjL/h4zarmAy LbHPx1tvrcv3NbEZmb9ylOJQKcHWRjnu/SKQ+dSpdCqOdbFNHCzy2VeMcGzFnRVQkTRj zk/C9jYmdM/kA5fJcTi7+fMk3fVY37jwrXD96DJDM+5FCiy6SXl8ek1vMa6FeuO+Klx5 Oskz3brJCywdkbH0819inbpSgDgsi68tvdSPoTlVsBrWPKEsIEV91XxGDATM4ygXnaND cOjQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p14-v6si34827527pgg.67.2018.09.24.05.00.38; Mon, 24 Sep 2018 05:00:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730559AbeIXSBf (ORCPT + 99 others); Mon, 24 Sep 2018 14:01:35 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52564 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729489AbeIXSBe (ORCPT ); Mon, 24 Sep 2018 14:01:34 -0400 Received: from localhost (ip-213-127-77-73.ip.prioritytelecom.net [213.127.77.73]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id CE5C11076; Mon, 24 Sep 2018 11:59:47 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Imre Deak , Bartlomiej Zolnierkiewicz , Sasha Levin Subject: [PATCH 4.9 021/111] fbdev: omapfb: off by one in omapfb_register_client() Date: Mon, 24 Sep 2018 13:51:48 +0200 Message-Id: <20180924113106.536323076@linuxfoundation.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20180924113103.337261320@linuxfoundation.org> References: <20180924113103.337261320@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter [ Upstream commit 5ec1ec35b2979b59d0b33381e7c9aac17e159d16 ] The omapfb_register_client[] array has OMAPFB_PLANE_NUM elements so the > should be >= or we are one element beyond the end of the array. Fixes: 8b08cf2b64f5 ("OMAP: add TI OMAP framebuffer driver") Signed-off-by: Dan Carpenter Cc: Imre Deak Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/video/fbdev/omap/omapfb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/video/fbdev/omap/omapfb_main.c +++ b/drivers/video/fbdev/omap/omapfb_main.c @@ -956,7 +956,7 @@ int omapfb_register_client(struct omapfb { int r; - if ((unsigned)omapfb_nb->plane_idx > OMAPFB_PLANE_NUM) + if ((unsigned)omapfb_nb->plane_idx >= OMAPFB_PLANE_NUM) return -EINVAL; if (!notifier_inited) {