Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261755AbTKQWnR (ORCPT ); Mon, 17 Nov 2003 17:43:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261776AbTKQWnR (ORCPT ); Mon, 17 Nov 2003 17:43:17 -0500 Received: from fw.osdl.org ([65.172.181.6]:5358 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S261755AbTKQWnQ (ORCPT ); Mon, 17 Nov 2003 17:43:16 -0500 Date: Mon, 17 Nov 2003 14:42:58 -0800 (PST) From: Linus Torvalds To: Zwane Mwaikambo cc: Ingo Molnar , "Martin J. Bligh" , Andrew Morton , Linux Kernel , , Hugh Dickins Subject: Re: [PATCH][2.6-mm] Fix 4G/4G X11/vm86 oops In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 684 Lines: 20 On Mon, 17 Nov 2003, Zwane Mwaikambo wrote: > > I've managed to `fix` the triple fault (see further below for the patch > in all it's glory). What's the generated assembly language for this function with and without the "fix"? If adding that printk fixes a triple fault, the issue is not likely to be the printk itself as much as the difference in code that the compiler generates - stack frame, memory re-ordering etc... Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/