Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2476395imm; Mon, 24 Sep 2018 05:09:43 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbBZyHNQmNUpU0+xZ8SGs4SpyeF2CNFz8wNsruZYrYnLhueeS9HLiYEDmD1RIa47flkBOhu X-Received: by 2002:a63:6a86:: with SMTP id f128-v6mr6963749pgc.165.1537790983184; Mon, 24 Sep 2018 05:09:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537790983; cv=none; d=google.com; s=arc-20160816; b=QQTNp4TcHvaVTyMrEouQKrfpkuvg8LMTqV8zoPxoHbelO3sT6lwi+8Ao+Sft66uLt5 lS/nlP+SV9Fd6nZNjhM77bvjODQKCFzaEOf+MajlCwdzflMQpMjMrM5NLhQPA1Sej6Eq 55Wg/fcZgS4yC8AqmV3VJ/550Vd16eXmBzz/nmNyOzZDtthxVsWRanWV+KRPvJ7m8Imb eykcAdlGCfNnGh0kgVXriieR860uxyraGolPrUyxjtdmLbn4DDjiG8nOQ/MDa6j6Y5Ak 6zOVvjQRgQQ/zf6X4kXgSRSVKSXvweRUHzyhHK+l6ygbZmWSKnkzSt7Xasy6va6uYlFF JeqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from; bh=i8R/+v0VAvt4m/Yhk8/TR+khZ1nEeLemAhFFJl/uG6M=; b=Dq3DZ5dMyqoAHNgBeTNx83niRIjPRzFAyn0ACDeVS/DVNNzmKL5b3bTUZB1T183FV6 mudUbs1a77dA2VCFdhX45xJm2Zmqsopg0N3in+k/6NeIHwJzF1pbDNdrMA1NGYdAWdSK DSt3dK57p1lLrtW1uAntP8+NGaru2M8Iko3yGFAogp0FZEWRxlwLn+h+sVxtL+MSOAIj WiRWSg/mv7dENGWOSKQPUTSkQEH5gQl+h7txAh0nmTRMrUp1Gd/B4abh0lu+jx2gyClR Xwk2tOA9eHbP2LGQRBZvK+xJf8KJ0BrtYb/E/OfpvMND15DYmeVXmIdT+VQUjttqgGQF +iCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a11-v6si12857770plp.199.2018.09.24.05.09.28; Mon, 24 Sep 2018 05:09:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731198AbeIXSIr (ORCPT + 99 others); Mon, 24 Sep 2018 14:08:47 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:54162 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729639AbeIXSIr (ORCPT ); Mon, 24 Sep 2018 14:08:47 -0400 Received: from localhost (ip-213-127-77-73.ip.prioritytelecom.net [213.127.77.73]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 823AD1084; Mon, 24 Sep 2018 12:06:58 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Zhouyang Jia , Alexandre Belloni , Sasha Levin Subject: [PATCH 4.9 096/111] rtc: bq4802: add error handling for devm_ioremap Date: Mon, 24 Sep 2018 13:53:03 +0200 Message-Id: <20180924113114.473005134@linuxfoundation.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20180924113103.337261320@linuxfoundation.org> References: <20180924113103.337261320@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zhouyang Jia [ Upstream commit 7874b919866ba91bac253fa219d3d4c82bb944df ] When devm_ioremap fails, the lack of error-handling code may cause unexpected results. This patch adds error-handling code after calling devm_ioremap. Signed-off-by: Zhouyang Jia Signed-off-by: Alexandre Belloni Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/rtc/rtc-bq4802.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/rtc/rtc-bq4802.c +++ b/drivers/rtc/rtc-bq4802.c @@ -164,6 +164,10 @@ static int bq4802_probe(struct platform_ } else if (p->r->flags & IORESOURCE_MEM) { p->regs = devm_ioremap(&pdev->dev, p->r->start, resource_size(p->r)); + if (!p->regs){ + err = -ENOMEM; + goto out; + } p->read = bq4802_read_mem; p->write = bq4802_write_mem; } else {