Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2482666imm; Mon, 24 Sep 2018 05:15:39 -0700 (PDT) X-Google-Smtp-Source: ACcGV63h0cbzXM5bk8Nuv6A8gJPrc88JX34XmxZlrCQYQOHrjGeFFCCcQBNZL/HT7pw0BtC5fMqo X-Received: by 2002:a17:902:720b:: with SMTP id ba11-v6mr6051030plb.199.1537791339842; Mon, 24 Sep 2018 05:15:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537791339; cv=none; d=google.com; s=arc-20160816; b=QSEfiWfVdgi2iudJlyq66Ri/eBkrMS9j5hSoUW1PC907dAyvDpsef+KwcX24062gos 9GQ5S5rFhaTEYbJWjFJ9Z2qgqnDsYCFjsQFIpxrkXVi+ubZkx/X8rLTRK0FBA69N8nu+ 6RzZLi9ZPOFlqLXbgpZzhufeKY95ynXMVDDsO/GnOXlC4Bw43WGO+MVSdURcK73Gw6Cp uRWL2+V6Bc/7/DuCmf1rVKxL8zrPaLY64i2t05isulcyWzCJXjPT1AlvzrKJBSqDJVP9 qvONLNfHfVK9AnQ/T5nbakkeaJfp72bdc5GeVJ+9ctXhzCWe7mW/PjUEdTnfZ8cxlydy QMGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from; bh=Ole9Q1LpH0gLX0fzGjNxa96x1yzmuP4MSg67UnI4GtE=; b=jTiHwMObWv3jkVLqPVgDpie4OlUHDWxzhImqMd1Ye7gKa/SVmX5gEGbLKRmhsOyr5i nu/lKWxdT/4XRkzrqGkW3QP0RyaEYZf96y2Lc+nx70cQ9BLkR62Zj15At4u8Indiz65R VYH13mGXVkzrQVcleYRsu/oP/rZEXx0ZBdP8+K+fBjrOqGXWGChiELvUiFsWH7tu8M+u zMa5MTuU9em1NZsm9XBJHL3vE5rLH3Kg29Zinet9TWPsEVerxeYW/TGV9dDwW2ZKbAQ6 8GFoATFjHhz+mL7tH+YHTVydjb67ceo/gQCVwCNQJuR8QR/JuHm2EGILE/fNGkmUgW36 WjaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a20-v6si33221055pgi.184.2018.09.24.05.15.23; Mon, 24 Sep 2018 05:15:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731860AbeIXSQX (ORCPT + 99 others); Mon, 24 Sep 2018 14:16:23 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55400 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731803AbeIXSQS (ORCPT ); Mon, 24 Sep 2018 14:16:18 -0400 Received: from localhost (ip-213-127-77-73.ip.prioritytelecom.net [213.127.77.73]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 8F87310A3; Mon, 24 Sep 2018 12:14:27 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Krzysztof Kozlowski , Sasha Levin Subject: [PATCH 4.14 044/173] ARM: exynos: Clear global variable on init error path Date: Mon, 24 Sep 2018 13:51:18 +0200 Message-Id: <20180924113119.233587125@linuxfoundation.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20180924113114.334025954@linuxfoundation.org> References: <20180924113114.334025954@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Krzysztof Kozlowski [ Upstream commit cd4806911cee3901bc2b5eb95603cf1958720b57 ] For most of Exynos SoCs, Power Management Unit (PMU) address space is mapped into global variable 'pmu_base_addr' very early when initializing PMU interrupt controller. A lot of other machine code depends on it so when doing iounmap() on this address, clear the global as well to avoid usage of invalid value (pointing to unmapped memory region). Properly mapped PMU address space is a requirement for all other machine code so this fix is purely theoretical. Boot will fail immediately in many other places after following this error path. Signed-off-by: Krzysztof Kozlowski Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- arch/arm/mach-exynos/suspend.c | 1 + 1 file changed, 1 insertion(+) --- a/arch/arm/mach-exynos/suspend.c +++ b/arch/arm/mach-exynos/suspend.c @@ -209,6 +209,7 @@ static int __init exynos_pmu_irq_init(st NULL); if (!domain) { iounmap(pmu_base_addr); + pmu_base_addr = NULL; return -ENOMEM; }