Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2494071imm; Mon, 24 Sep 2018 05:26:54 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZ8IJq4N2rODSDUResqy9TVFjjL+RmADAmhVNd4hUNeAvIognehYwp7/EveMsNK9rTdGXKn X-Received: by 2002:a62:920d:: with SMTP id o13-v6mr1366900pfd.177.1537792014527; Mon, 24 Sep 2018 05:26:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537792014; cv=none; d=google.com; s=arc-20160816; b=ryszhEdlNC3d1XzD94ekKoB33n4jNGBSbzQ3ecjRDhSBSO7cDeGO7mVvfNjVD5hpZm kKR6WdBGSkta4HfHN5HKM0mWTWtqOPtO1DAtAJ2vOaFhlB9E99zf2zDs6XIKKms/hfI5 yuJCgfwoJY3Us/xHKEAjsp/pdb7o4hE3ZqFGR3ZmZYDplKQRzW8fEWTh7LrUvRcz5gBY tWH+QsyJL7lKkgAgpgA7SrGUigH5glYSf/G51ZutoSperOifDoYz6sHhSqFNAAvluEn+ eQQbXBfmaNpjnRPFpVik3ZHJSBP9uP5GFaIiL8ivWB+uoA9jRRqY8NIKuJMK3xixCfxA KiHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from; bh=GItsjHx6bOdmFKQvdk6E/Pc6oq+JFoeSa4bCyWoh2Tg=; b=UeDit8DQ0yB9fE4swIFUi6Hn2X148egfuIjgoT3yPHOjCbfI0ixgmIHZ2xapMwyA0b k98lxolLKRzL6kG01Ft1rB+dbYeq73PUeO2+qMAxSBLtOq64WdVKOIqa/AyAZxN1rraR X2W/Pz2rRROXlKFJ+MbVss/vNivIVlNyC1OMV1ss/McwzdljbXAZvo//g8lh5MCjfRjS Gi7yjo+q22mGH5dLDIy9aXMQyMKB5Z/2Ll6tlW8S5zZ34T/tXZpKXpHeIZBx7pkoPmlo jV9pkRhDDqo4jJy0NvfkGzwSAonCdYVAvhUnWsxkrgE6Pk9ruPAO0+GGMvLodLEzhF8Y 0miA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q5-v6si32145403pls.435.2018.09.24.05.26.38; Mon, 24 Sep 2018 05:26:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732988AbeIXS1d (ORCPT + 99 others); Mon, 24 Sep 2018 14:27:33 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:57002 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730683AbeIXS1c (ORCPT ); Mon, 24 Sep 2018 14:27:32 -0400 Received: from localhost (ip-213-127-77-73.ip.prioritytelecom.net [213.127.77.73]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 302F5108B; Mon, 24 Sep 2018 12:25:39 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chris Wilson , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , Sudip Mukherjee Subject: [PATCH 4.14 165/173] drm/i915: Apply the GTT write flush for all !llc machines Date: Mon, 24 Sep 2018 13:53:19 +0200 Message-Id: <20180924113127.174758304@linuxfoundation.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20180924113114.334025954@linuxfoundation.org> References: <20180924113114.334025954@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chris Wilson commit c5ba5b24657e473b1c64b0a614b168a635a2c935 upstream. We also see the delayed GTT write issue on i915g/i915gm, so let's presume that it is a universal problem for all !llc machines, and that we just haven't yet noticed on g33, gen4 and gen5 machines. v2: Use a register that exists on all platforms Testcase: igt/gem_mmap_gtt/coherency # i915gm References: https://bugs.freedesktop.org/show_bug.cgi?id=102577 Signed-off-by: Chris Wilson Cc: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20170907184520.5032-1-chris@chris-wilson.co.uk Reviewed-by: Ville Syrjälä Signed-off-by: Sudip Mukherjee Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/i915/i915_gem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -687,10 +687,10 @@ flush_write_domain(struct drm_i915_gem_o switch (obj->base.write_domain) { case I915_GEM_DOMAIN_GTT: - if (INTEL_GEN(dev_priv) >= 6 && !HAS_LLC(dev_priv)) { + if (!HAS_LLC(dev_priv)) { intel_runtime_pm_get(dev_priv); spin_lock_irq(&dev_priv->uncore.lock); - POSTING_READ_FW(RING_ACTHD(dev_priv->engine[RCS]->mmio_base)); + POSTING_READ_FW(RING_HEAD(dev_priv->engine[RCS]->mmio_base)); spin_unlock_irq(&dev_priv->uncore.lock); intel_runtime_pm_put(dev_priv); }