Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2511765imm; Mon, 24 Sep 2018 05:43:01 -0700 (PDT) X-Google-Smtp-Source: ACcGV62Y84svLyV3c8/j27x2LT9lQxZjPWoxqraJ2WRgtT3BK1gkUY1Mxlr2Bv8pmVayjbOUQj5J X-Received: by 2002:a63:f414:: with SMTP id g20-v6mr9374634pgi.407.1537792981070; Mon, 24 Sep 2018 05:43:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537792981; cv=none; d=google.com; s=arc-20160816; b=g4J5KMgnKBPGVW1wgzz21+wcOFK9QUMkJ7m56ZVAETKGT907FvTcks0qHYb3rVXdXR CySe/ZCA2o4aM2XY2K2r1a3/nXJMkrjNRNGQ/FABHYMeIMeucuB+bQzg/1b2ICca3i5C vZuDDfspR+OH7jbkXfJ8KSlOIj+lukWpDBE45Y1DgfdPXdPSrv0HQnyp2Z0Gm43/IlqE fHFJR0ZQrvbquLbSvKWD8FhC4sHJAoyNu3id+wQXUaUJrVZyCGBBXmTMxsmvq+u03e20 QLYSrDKg6rbtlOpQWmIjArnx1TKqMQL0Jf/lkX5oW+Hn7M/Pw7EUmlC5bJqUjqHkmAK5 Bk9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from; bh=AGQAxNoGPw6kLJ8jFNPxm+bJwt9O1hRjHl1EDJJphCg=; b=nJ2ld763ZN2HM54f48x9B8ywFZZFhuDcvduaQZDqUKhV38TxQu7nr+g5hOftcESZc0 e1Y3InSV1gmTYPv6M+5kugxwqklF+4zax06aCARLV0rpr8NZQEvUZSTi2hFEbkYtuo22 GuMRxR0YKndNUYu/Sn8vx6dpiwai3zdugsoefvVjNlts4jIq48PFs1IxJ6cw3Ww2eog7 2RyjgxTuJDCzT8G1dZMOl3MAHOymaTrC4oYX2MBCYZokr71vSgcJVgq4OA8LjnZQK9LE EkdeFtLsnyhXkmegNrEM9AnWJAjhFUHo++45iC8UMD0vHtmUgsv5SW45oyx2+9wO+RNP JC0A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z2-v6si12166850plo.412.2018.09.24.05.42.45; Mon, 24 Sep 2018 05:43:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388839AbeIXSnt (ORCPT + 99 others); Mon, 24 Sep 2018 14:43:49 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59198 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729543AbeIXSns (ORCPT ); Mon, 24 Sep 2018 14:43:48 -0400 Received: from localhost (ip-213-127-77-73.ip.prioritytelecom.net [213.127.77.73]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 64727109E; Mon, 24 Sep 2018 12:41:49 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stefan Agner , Marcel Ziswiler , Ulf Hansson , Sasha Levin Subject: [PATCH 4.18 182/235] mmc: tegra: prevent HS200 on Tegra 3 Date: Mon, 24 Sep 2018 13:52:48 +0200 Message-Id: <20180924113122.803178562@linuxfoundation.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20180924113103.999624566@linuxfoundation.org> References: <20180924113103.999624566@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Stefan Agner [ Upstream commit 127407e36f4fe3a1d5e8b9998b479956ce83a7dc ] The stack assumes that SDHC controller which support SD3.0 (SDR104) do support HS200. This is not the case for Tegra 3, which does support SD 3.0 but only supports eMMC spec 4.41. Use SDHCI_QUIRK2_BROKEN_HS200 to indicate that the controller does not support HS200. Note that commit 156e14b126ff ("mmc: sdhci: fix caps2 for HS200") added the tie between SD3.0 (SDR104) and HS200. I don't think that this is necessarly true. It is fully legitimate to support SD3.0 and not support HS200. The quirk naming suggests something is broken in the controller, but this is not the case: The controller simply does not support HS200. Fixes: 7ad2ed1dfcbe ("mmc: tegra: enable UHS-I modes") Signed-off-by: Stefan Agner Tested-by: Marcel Ziswiler Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/mmc/host/sdhci-tegra.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/mmc/host/sdhci-tegra.c +++ b/drivers/mmc/host/sdhci-tegra.c @@ -334,7 +334,8 @@ static const struct sdhci_pltfm_data sdh SDHCI_QUIRK_NO_HISPD_BIT | SDHCI_QUIRK_BROKEN_ADMA_ZEROLEN_DESC | SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN, - .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN, + .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN | + SDHCI_QUIRK2_BROKEN_HS200, .ops = &tegra_sdhci_ops, };