Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2514830imm; Mon, 24 Sep 2018 05:45:59 -0700 (PDT) X-Google-Smtp-Source: ACcGV62A/pUECFm2RH+poLNoexCyDq1fxjG9BEbAgc2uRuxKSinXS6UEGc1t34+Pj6hFmOw5KEpN X-Received: by 2002:a17:902:7b96:: with SMTP id w22-v6mr10518580pll.24.1537793159371; Mon, 24 Sep 2018 05:45:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537793159; cv=none; d=google.com; s=arc-20160816; b=lfecLAytu58Hy/JactyX4HU/E7cCXpl0zMi2+grRICWOr75uAonbSp7Crm3ci59omQ zN1xC3+K1IJzvZ65++UYBugm4A4t0twkFtmUhmqWdxBElCM9mkfv75r0+Wvpl2nqBTAj ekr9MRXUbCNk0hATWWQhVAYVrdGZRhvMQRq5SREgxwBf2eGaA10HRpqPxVwfO6pkmes8 Do0f1/NCbx3oBBiwJ6ogcA1qfk1VeqdJg6IwVtV3tUS3eB4EVX0yTM7vJCqhfIWkypkI pAMpdny1zSeWF3vPTrBYJ3IlW46jBJEvuJfGcyg07Xp/aKGeqwmx3TPtH/yJql53bLIU 5dfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from; bh=vaVVhUsHzPLZaEsrHsmMgotoIYhycr8FKNcp/7aEX3I=; b=BPUVW+JkOmzFYdj+kN8KhlZriT95rgr3woaihvFxiA4CJkXusNpz1PXqf6icgjkmDs 6FRwSCFVUFsOpfNIABOIxNwu8ndGX0n2QMHrEAa9TxfFDnDq1l3TbrYJguL8NTHFmjpC 8LVhnh3lsvMKFRnhIL3jmR8Dvr/a/yMV7SSrPuXqo2nsw+R93NbWEhKZdNNUUnOb2Bvq LDeDexAv93/lMj/KOFKs4AUUSiEokZmv28LCZriKAdfEsjva5XYapkxbTJqqhdWnGf+E pAzBUOeHUGgUZuSrNFQLw5twKBYaoEJIMe+uNsclgK5iBJZmxdHEnEctpxgi+VAtANRl /u/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h15-v6si3178996pgn.389.2018.09.24.05.45.43; Mon, 24 Sep 2018 05:45:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389040AbeIXSp3 (ORCPT + 99 others); Mon, 24 Sep 2018 14:45:29 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59466 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387721AbeIXSp3 (ORCPT ); Mon, 24 Sep 2018 14:45:29 -0400 Received: from localhost (ip-213-127-77-73.ip.prioritytelecom.net [213.127.77.73]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 883BB109A; Mon, 24 Sep 2018 12:43:30 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Linus Walleij , "David S. Miller" , Sasha Levin Subject: [PATCH 4.18 202/235] net: gemini: Allow multiple ports to instantiate Date: Mon, 24 Sep 2018 13:53:08 +0200 Message-Id: <20180924113124.307761063@linuxfoundation.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20180924113103.999624566@linuxfoundation.org> References: <20180924113103.999624566@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Linus Walleij [ Upstream commit 60cc7767b901dd1e3f70755c3d2505556ba487c2 ] The code was not tested with two ports actually in use at the same time. (I blame this on lack of actual hardware using that feature.) Now after locating a system using both ports, add necessary fix to make both ports come up. Signed-off-by: Linus Walleij Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/cortina/gemini.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/drivers/net/ethernet/cortina/gemini.c +++ b/drivers/net/ethernet/cortina/gemini.c @@ -1753,7 +1753,10 @@ static int gmac_open(struct net_device * phy_start(netdev->phydev); err = geth_resize_freeq(port); - if (err) { + /* It's fine if it's just busy, the other port has set up + * the freeq in that case. + */ + if (err && (err != -EBUSY)) { netdev_err(netdev, "could not resize freeq\n"); goto err_stop_phy; }