Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2545866imm; Mon, 24 Sep 2018 06:13:45 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYzgugIWZO+tlTyVlti5ZyCXfo/7ed+7mAhYgRI1s1pRAG1AbQrntVo3wMlKBPzaRhblZeY X-Received: by 2002:a62:3184:: with SMTP id x126-v6mr10313639pfx.49.1537794825900; Mon, 24 Sep 2018 06:13:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537794825; cv=none; d=google.com; s=arc-20160816; b=nhnveK4HVM9mx0lqehRn0swHMhmXSptFf64VTRnzFLPnB+Lr85+WWGkAtiPhVbXykJ XAszOB/mG349tTmtLm2Rn2GhQVXf95yQr8fBtFhtYC8yR+AQjGRyeNfCII7OYKS1KMjs 5FTwYHO+x2Uxe1FP7wINxsn0uugv26JCUmsfHinOqFmMmf4phB74dp5keWxeF1lJB3eT mKhbgKA/zAkt7qAUm0B4mJbp3xYmFICEkYHQX4L2RuaoVXD5baN/gA8SqmgixF3GqTXk nfM42M42VrO3I3sr4af57wgt8+lq3qJ6c66sFM58/rWVVDlCQjpPp+kFXl5uv05uQoFw v9lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=Q8gCZaegLuJJ6ZyqTBzFepWMCf8skZadY706KnIG8Is=; b=jU27XLekiKM9KZfh+Bwbn3rdWDXPwiDWyM0bXxEvdxhSOofH06DOgKiVzjcDDpvH2U rzrRK5WvDa8mBGeI3iovB5YAycFiZlZU6n6uIPcVooex0aefb+4NzNfF20iZ3LauUo9X hsib5tsRKjoPRjbZpp9G1yhjDaYtBoa+CCGN/2VAD1K/C7fOu77QLXd75a8CfnauYsgM XZiTelfb5NuDjz62sjEhDYsOLPfZWtuM/iipbzIjeOeVnQjT83E6fA2cZHeiGKeCKnai uD2jhb2538LCVzRB9BI9fyMe99KjKHauTS5JBNunuNXXgyN3lPZHzIlukCxHptyBNhGJ iuYQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u1-v6si35741412plb.291.2018.09.24.06.13.29; Mon, 24 Sep 2018 06:13:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730504AbeIXTPA (ORCPT + 99 others); Mon, 24 Sep 2018 15:15:00 -0400 Received: from mga05.intel.com ([192.55.52.43]:26022 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729176AbeIXTPA (ORCPT ); Mon, 24 Sep 2018 15:15:00 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2018 06:12:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,298,1534834800"; d="scan'208";a="265227524" Received: from mattu-haswell.fi.intel.com (HELO [10.237.72.164]) ([10.237.72.164]) by fmsmga005.fm.intel.com with ESMTP; 24 Sep 2018 06:06:41 -0700 Subject: Re: [PATCH] xhci: Add check for invalid byte size error when UAS devices are connected. To: Sandeep Singh , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, gregkh@linuxfoundation.org, mathias.nyman@intel.com Cc: Nehal Shah , Shyam Sundar S K References: <1537536150-11721-1-git-send-email-Sandeep.Singh@amd.com> From: Mathias Nyman Message-ID: <58201720-ee34-a866-b177-084b9f36c40c@linux.intel.com> Date: Mon, 24 Sep 2018 16:09:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1537536150-11721-1-git-send-email-Sandeep.Singh@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21.09.2018 16:22, Sandeep Singh wrote: > From: Sandeep Singh > > Observed "TRB completion code (27)" error which corresponds to Stopped - > Length Invalid error(xhci spec section 4.17.4) while connecting USB to > SATA bridge. > > Looks like this case was not considered when the following patch[1] was > committed. Hence adding this new check which can prevent > the invalid byte size error. > > [1] ade2e3a xhci: handle transfer events without TRB pointer > Thanks, adding to queue. Just out of curiosity, was the TRB pointer bits all zeroes in this Stopped -Length invalid transfer event TRB? -Mathias