Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2690359imm; Mon, 24 Sep 2018 08:25:08 -0700 (PDT) X-Google-Smtp-Source: ACcGV63L91liP29CKkPrx2zPd2WczxsMzlBhd1jMCF2a3aYksZa+FA5s49fg9OSAMGSPmXNQ6T3b X-Received: by 2002:a63:f744:: with SMTP id f4-v6mr304925pgk.410.1537802708435; Mon, 24 Sep 2018 08:25:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537802708; cv=none; d=google.com; s=arc-20160816; b=zpDcE66Jw27fEnws+Mps+PRtNz8iBQjrQ6FyzupiEMbX1CWXfS0RHMMhAr+wNowiWL M7VInsm7dncX//f6iE3FJiwDgiYXAOY1GYZJ3nJiR0MU97aju5SZM/BfwB1QfER0c5qu qSnC1okL4wcjHcmJB+HwPWr+W1Neq8R2NDDozoCcppC1ZDt0/hwQZBk6T0qQPwGmKTsQ hNQQVT83dHDZrmeo5GP7+LYIzkf4RB1GHyCX0leqO6f1V+CJ45C9uSUPgBEmdT2I9kSH 7SJyyn1JDTB3Z5Pk7Pnf6vvRW49/tmu4vibO6W7ZTk4gIx/iRHySxa3HlXmW/evnnZFm q3Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:mime-version:user-agent :message-id:date:cc:to:from; bh=vdvfvCOt8TIC4JGp79TTdj6sMKjT/0iXbOH0VDV67rg=; b=OYQF6gzDTTHL/cF/jdCR61Tb7Ggvz5fIw9NHZVd1cLL4b/2LQ8DqbxZ4AqBswBegS2 j7ZmHVarAS1Uk6AiVqoLcqQqLOi7ve+GLuGPiN29Nh7nq1AKmRM6Cc3h+QM3Eib3urMR l4KLhoCeD+a89A3p2EI0D9RSaKiGQOZ4Mi93Ky1sYtHgP43RiAaBwKvjMw6lXgGAsLKM PaLKJDJEOvkY+aXB4uZpGbyw4FAKZ7Pf3jlxtUZta3SQyWMBc9YGOQZAf+5rlDXKVmNU Q2rFBnUknnHBpE3aKr+B2xCAjgRTTHFv899k2ZOElonOxAyPWww+CUuX1qBToXkg641u BVWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g1-v6si33976240pld.79.2018.09.24.08.24.20; Mon, 24 Sep 2018 08:25:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729035AbeIXV03 (ORCPT + 99 others); Mon, 24 Sep 2018 17:26:29 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:33153 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728550AbeIXV03 (ORCPT ); Mon, 24 Sep 2018 17:26:29 -0400 Received: from in01.mta.xmission.com ([166.70.13.51]) by out02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1g4SiB-0001U2-07; Mon, 24 Sep 2018 09:23:47 -0600 Received: from [105.184.227.67] (helo=x220.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1g4Si9-00005o-9Y; Mon, 24 Sep 2018 09:23:46 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Cc: , Guan Xuetao Date: Mon, 24 Sep 2018 17:23:35 +0200 Message-ID: <87lg7q2a2w.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1g4Si9-00005o-9Y;;;mid=<87lg7q2a2w.fsf@xmission.com>;;;hst=in01.mta.xmission.com;;;ip=105.184.227.67;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1+DU8RXYMKgqzZkaoG+kC5M/Eq2/n5ryF4= X-SA-Exim-Connect-IP: 105.184.227.67 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa07.xmission.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=8.0 tests=ALL_TRUSTED,BAYES_00, DCC_CHECK_NEGATIVE,TR_Symld_Words,XMNoVowels autolearn=disabled version=3.4.1 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 1.5 TR_Symld_Words too many words that have symbols inside * 1.5 XMNoVowels Alpha-numberic number with no vowels * -3.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0046] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa07 1397; Body=1 Fuz1=1 Fuz2=1] X-Spam-DCC: XMission; sa07 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ; X-Spam-Relay-Country: X-Spam-Timing: total 133 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 2.7 (2.0%), b_tie_ro: 1.80 (1.3%), parse: 0.62 (0.5%), extract_message_metadata: 2.1 (1.6%), get_uri_detail_list: 0.66 (0.5%), tests_pri_-1000: 3.3 (2.4%), tests_pri_-950: 1.14 (0.9%), tests_pri_-900: 0.94 (0.7%), tests_pri_-400: 15 (11.2%), check_bayes: 14 (10.5%), b_tokenize: 4.1 (3.0%), b_tok_get_all: 4.8 (3.6%), b_comp_prob: 1.48 (1.1%), b_tok_touch_all: 2.1 (1.6%), b_finish: 0.53 (0.4%), tests_pri_0: 96 (71.8%), check_dkim_signature: 0.40 (0.3%), check_dkim_adsp: 2.6 (2.0%), tests_pri_500: 5 (3.9%), rewrite_mail: 0.00 (0.0%) Subject: [REVIEW][PATCH 0/3] signal/unicore32: siginfo cleanups X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I have been slowly cleaning up the architectues ever since I discovered that the pattern of passing in struct siginfo is error prone, and occassionally results in broken siginfo being sent to userspace. I don't have a clue how to obtain a working unicore32 compiler so the following changes have only been reviewed carefully and not compile tested. Still I believe they are simple and obviously correct. Anyone who can review or test these changes please do and let me know about any problems you find so that I can correct them. My intention is to merge this through my siginfo tree. If you feel it should go through your arch tree let me know. All of the prerequisites should have been merged several releases ago. Eric W. Biederman (3): signal/unicore32: Use send_sig_fault where appropriate signal/unicore32: Generate siginfo in ucs32_notify_die signal/unicore32: Use force_sig_fault where appropriate arch/unicore32/include/asm/bug.h | 3 ++- arch/unicore32/kernel/fpu-ucf64.c | 12 +++--------- arch/unicore32/kernel/traps.c | 5 +++-- arch/unicore32/mm/fault.c | 27 +++++---------------------- 4 files changed, 13 insertions(+), 34 deletions(-) Eric