Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2698534imm; Mon, 24 Sep 2018 08:32:15 -0700 (PDT) X-Google-Smtp-Source: ACcGV62zkw0lAw5RUCEQ1fDqucnwE45wL0SQqtQ1GmL8JGHWGru3In5c2x2QV6706DbHAE6RiKeZ X-Received: by 2002:a17:902:28a4:: with SMTP id f33-v6mr11323179plb.297.1537803135768; Mon, 24 Sep 2018 08:32:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537803135; cv=none; d=google.com; s=arc-20160816; b=RnYBT26dL6TVi/TFajURFw7GVavuNl2+5HzNqxNs4QWhNt/nYBGoeMibHEs6hWPwhH 0aPhQf2Qll0fQbMrNeXkzAoFizVQK+aXEmh0AXo3iKAPJFIk3JlmR0Ei4VAFckN3nm0K xEalHhGYB3fBB/WYfHifV0M50eKbFEIHsnxeGqL+eUCtXFdl/x0mHWIC/l3jYSIgEZb6 zxJX35g30TKK8iB52ld+9v9aebbTPgvwFsmDPs6oG6nRVZre9jVh95H5UDXpMhINcz+f CVTYuvaMZTHJPNYqUPJO0sK+QVlMv833qKsuc+Pof8yqJknd6kyW4f5ShfB33ku9yQB4 Rijg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:to:from:subject:message-id; bh=xlig4pOcJDaNzcZcKC384XflhplO4vDkMFosdiDCg2U=; b=Qv8pc5ABQce3hpDOSmo4kUr0fz30QsOkObk3guBXMFB50fXYtJgaXJIOGPO5/UQ8dA n8MHxTSDVCNzCY2aUdcTVixlLGxYP2Va0f2STYJ5j6RwnaK49BoG+KVMfoFKewiW0XSS aCvOzrPnvsQ1TowQAk0JKlzNqxl5q9g/+1OuvKucsuprZ+ZqoZn3GHamv8A0oXjh0YmY DMrDz5LKSrI0I4mnHAP3+CoXoAx0uLYdA+IdkKitpe7k6BfQp/tPz8ScmISQNLVzjc+0 TBZNQhDI2uEKgQ2YscmH9OOpdWeDGnJBH9Ehto4qdsCggSd19S8dqwJXaIc3k53PgzWE 8EAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c32-v6si35034190plj.272.2018.09.24.08.31.29; Mon, 24 Sep 2018 08:32:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729472AbeIXVdV (ORCPT + 99 others); Mon, 24 Sep 2018 17:33:21 -0400 Received: from mga11.intel.com ([192.55.52.93]:56450 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726400AbeIXVdV (ORCPT ); Mon, 24 Sep 2018 17:33:21 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2018 08:30:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,298,1534834800"; d="scan'208";a="91460965" Received: from 2b52.sc.intel.com ([143.183.136.51]) by fmsmga004.fm.intel.com with ESMTP; 24 Sep 2018 08:30:27 -0700 Message-ID: <4e453720b77fd9c4dade6fcefc5b6f0eea396a1a.camel@intel.com> Subject: Re: [RFC PATCH v4 00/27] Control Flow Enforcement: Shadow Stack From: Yu-cheng Yu To: Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue Date: Mon, 24 Sep 2018 08:25:51 -0700 In-Reply-To: <1ca5178d-60f3-ae70-ce95-7026ac0429b4@linux.intel.com> References: <20180921150351.20898-1-yu-cheng.yu@intel.com> <1ca5178d-60f3-ae70-ce95-7026ac0429b4@linux.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.1-2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2018-09-21 at 15:53 -0700, Dave Hansen wrote: > On 09/21/2018 08:03 AM, Yu-cheng Yu wrote: > > The previous version of CET patches can be found in the following > > link: > > > > https://lkml.org/lkml/2018/8/30/608 > > So, this is an RFC, but there no mention of what you want comments *on*. :) > > What do you want folks to review? What needs to get settled before this > is merged? Thanks, Dave! These patches passed GLIBC built-in tests and more tests HJ and I put together at https://github.com/hjl-tools/cet-smoke-test. I made some changes since V3 as outlined in the cover letter. In particular there are two new patches for the VMA guard and preventing shadow stack merging. Does anyone have comments on those and the whole Shadow Stack/IBT series in general? Thanks, Yu-cheng