Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2762171imm; Mon, 24 Sep 2018 09:29:40 -0700 (PDT) X-Google-Smtp-Source: ACcGV61ruXwNi2ZEiM6tp4IJgGASvjvgD1YrY/ch/36JApEp0/3CKTTK57YBjast8dzMQXlFpmy7 X-Received: by 2002:a63:df04:: with SMTP id u4-v6mr10392904pgg.434.1537806580124; Mon, 24 Sep 2018 09:29:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537806580; cv=none; d=google.com; s=arc-20160816; b=GjJPUmQpmuozN6uK82UeupI1YCBq2dqytlTMOx0SgesqV/mQm/VArgdOHnSq6Ay20w uwOL+XiPyRjUK7VIzZYP6rPg+y81Vsgi5nRG28Pb+J8aTS+SwCxl0scdGJmy3KD89puQ xEdKmflqrhBlhC6reo7m4PsEEFENT5Qh9Bh5gyzRzUVFacIwsRZbIc4gK0emPODGZhHi Xocdwl72vm/jtSWyD9cAN4sDS2ZySKKgsRBBwA5ImuDqn/zpizDU9RcpuLPgdhyTfuWH xlAVpkRRsiUDxdOPP2cNle/ul63fwKloEtjLMjxiekodJQybRqWBHoEX7Nbb1kdt7yCf hMVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date:from :references:cc:to:subject; bh=NDLFsBZVgj+rCFUgGBASIHGHGbaZiqn0F2o7/ckvfqw=; b=GGnVrpYf/dk3yUMR4ww0W9oFMUbYHZ7MDQK6RCktkjpUGOnYlIF2eEO/qAZZtmBBhX Mgr8HHXSxCp1CF8NE7v89xMzyw5W4CF7OVrKR0/t5tH8gi9ygD9lz9DJvtB9E4PdQK88 c152ItflXbK6GGDImoTGQH4PNpivlsI+eZnjpEuCIlAF+Rg6+G+4EZlOltmIpV1QghOH 1Bw03Ggzn8yBDfUI/ALuJ2GTfVPDqOyIl6eGRmWtp4ZQjjpmYNNM3flK7w8UZP8H1gwf XlstUyvxbS07O/0XBl45wPpI2p+vkhTtEFz9zX3hNOB2UoQn1sl+9xRWxQA/6eFw/kC0 KqVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j37-v6si35177446pgl.432.2018.09.24.09.29.24; Mon, 24 Sep 2018 09:29:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730200AbeIXWcL (ORCPT + 99 others); Mon, 24 Sep 2018 18:32:11 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:38764 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726711AbeIXWcL (ORCPT ); Mon, 24 Sep 2018 18:32:11 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w8OGRiJC064936 for ; Mon, 24 Sep 2018 12:29:13 -0400 Received: from e33.co.us.ibm.com (e33.co.us.ibm.com [32.97.110.151]) by mx0a-001b2d01.pphosted.com with ESMTP id 2mq135y9rp-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 24 Sep 2018 12:29:12 -0400 Received: from localhost by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 24 Sep 2018 10:29:12 -0600 Received: from b03cxnp08028.gho.boulder.ibm.com (9.17.130.20) by e33.co.us.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 24 Sep 2018 10:29:08 -0600 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w8OGT5fC26214622 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 24 Sep 2018 09:29:05 -0700 Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9DB62BE053; Mon, 24 Sep 2018 10:29:05 -0600 (MDT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EBE54BE04F; Mon, 24 Sep 2018 10:29:01 -0600 (MDT) Received: from oc8043147753.ibm.com (unknown [9.85.130.123]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Mon, 24 Sep 2018 10:29:01 -0600 (MDT) Subject: Re: [PATCH v10 12/26] s390: vfio-ap: implement VFIO_DEVICE_GET_INFO ioctl To: Cornelia Huck , Tony Krowiak Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, freude@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, borntraeger@de.ibm.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, pmorel@linux.vnet.ibm.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, jjherne@linux.vnet.ibm.com, thuth@redhat.com, pasic@linux.vnet.ibm.com, berrange@redhat.com, fiuczy@linux.vnet.ibm.com, buendgen@de.ibm.com, frankja@linux.ibm.com References: <1536781396-13601-1-git-send-email-akrowiak@linux.vnet.ibm.com> <1536781396-13601-13-git-send-email-akrowiak@linux.vnet.ibm.com> <20180924134310.29fb9d1d.cohuck@redhat.com> From: Tony Krowiak Date: Mon, 24 Sep 2018 12:29:01 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20180924134310.29fb9d1d.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18092416-0036-0000-0000-00000A3DDB71 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009763; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000267; SDB=6.01093026; UDB=6.00564896; IPR=6.00873064; MB=3.00023484; MTD=3.00000008; XFM=3.00000015; UTC=2018-09-24 16:29:11 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18092416-0037-0000-0000-0000490D8FC2 Message-Id: <13d5ac07-3c89-1a93-ce62-e3c44b3bf0ba@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-09-24_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=877 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809240161 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/24/2018 07:43 AM, Cornelia Huck wrote: > On Wed, 12 Sep 2018 15:43:02 -0400 > Tony Krowiak wrote: > >> From: Tony Krowiak >> >> Introduces ioctl access to the VFIO AP Matrix device driver >> by implementing the VFIO_DEVICE_GET_INFO ioctl. This ioctl >> provides the VFIO AP Matrix device driver information to the >> guest machine. > > What about the following? > > "Add support for the VFIO_DEVICE_GET_INFO ioctl to the VFIO AP Matrix > device driver. This is a minimal implementation, as vfio-ap does not > use I/O regions." Sounds good, I'll change it. > >> >> Signed-off-by: Tony Krowiak >> Reviewed-by: Pierre Morel >> Acked-by: Halil Pasic >> Tested-by: Michael Mueller >> Tested-by: Farhan Ali >> Tested-by: Pierre Morel >> Signed-off-by: Christian Borntraeger >> --- >> drivers/s390/crypto/vfio_ap_ops.c | 38 +++++++++++++++++++++++++++++++++++++ >> include/uapi/linux/vfio.h | 1 + >> 2 files changed, 39 insertions(+), 0 deletions(-) > > Anyway, > > Reviewed-by: Cornelia Huck >