Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp3082133imm; Mon, 24 Sep 2018 15:36:00 -0700 (PDT) X-Google-Smtp-Source: ACcGV60NhEMFVf5kczkA0SgLeVXyc8bOJgbO5sj+4X2k+3dzS/rlZU3mBRf8/hhIZ0UFkkiKzbwV X-Received: by 2002:a17:902:163:: with SMTP id 90-v6mr704387plb.322.1537828560753; Mon, 24 Sep 2018 15:36:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537828560; cv=none; d=google.com; s=arc-20160816; b=DWpi3HVsdci6D5K77hAECU9hUlpr/IxBU7oj8+WJLcsd6y9ehkpoWBVtesLTAc7/fh kKyMcbybY8mZ+SOv5iRYlzXf/83Hx7SjoUGq+to7lTp0070VIP9MotkeiYP7ZrRTT5lT sN5vKkNbJA/5h7Mnw/zqqMwptuwA00NKO5fijVcS6/CCTNr5zQrSMnugaViT3JygPQtQ 7Y1/EdAQYnkgRSQ04q7e7qF8K0GtxPY5gYDMNykZQb9DIcIhI+04VlmCv82uydwO2e0q IWQpQrsl3WooVQUMYJ3cbWg6jZ+/7mj/fcNvwicX93rnoJFb1RblmN8au5bcsovPcUJJ V0VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=h9TwpVtnD1LCSrQzdn7QNLmY+VzDw9X8OzjBJgvXkLA=; b=CzdYzWRzir0bYrFgZf4hmWGZnY7r4U/vvuFT1NOC/1vQtuekDuzKt0zZaPz7Su6EVC px+5r/DvjPnevsz2Nu1eBdEnuWqYkJ16yZDHWuWDA0dw8t6hrZxn5nMyYa6KVNgxOYcp NwXzXsEo7x8k5NxjSQ+MelgkcrdlE8gl4O5zQA23MkzJMVky1HCW53Pz1/gPz0O+ng+5 76HISn/b3HkbWk2Li3BlhukDMTN5czPhQYk6bokljB8cWb0s91NC3Jd1KXtF6y/WSP4f TAOZ4urrQuu/CeoT7S6kpAGlqdOA5VvxhkPQfnFK/TQZ/zg21P1qUnBgC9xuDkRDTQc9 PDVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e22-v6si505122pgb.626.2018.09.24.15.35.44; Mon, 24 Sep 2018 15:36:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726361AbeIYEkF (ORCPT + 99 others); Tue, 25 Sep 2018 00:40:05 -0400 Received: from mga07.intel.com ([134.134.136.100]:35398 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725931AbeIYEkF (ORCPT ); Tue, 25 Sep 2018 00:40:05 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2018 15:35:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,299,1534834800"; d="scan'208";a="76951355" Received: from rkchitto-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.51.24]) by orsmga006.jf.intel.com with ESMTP; 24 Sep 2018 15:35:11 -0700 Date: Tue, 25 Sep 2018 01:35:13 +0300 From: Jarkko Sakkinen To: Nayna Jain Cc: Tomas Winkler , Jason Gunthorpe , Alexander Usyskin , Tadeusz Struk , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 11/21] tpm: factor out tpm_startup function Message-ID: <20180924223513.GB12088@linux.intel.com> References: <20180921135820.20549-1-tomas.winkler@intel.com> <20180921135820.20549-12-tomas.winkler@intel.com> <060a3dc0-046e-198c-f476-8c490140e9d6@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <060a3dc0-046e-198c-f476-8c490140e9d6@linux.vnet.ibm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 24, 2018 at 08:21:10PM +0530, Nayna Jain wrote: > On 09/21/2018 07:28 PM, Tomas Winkler wrote: > > TPM manual startup is used only from within TPM 1.x or TPM 2.x > > code, hence remove tpm_startup() function from tpm-interface.c > > and add two static functions implementations tpm1_startup() > > and tpm2_startup() into to tpm1-cmd.c and tpm2-cmd.c respectively. > > > > Signed-off-by: Tomas Winkler > > Tested-by: Jarkko Sakkine Probably my bad, had an unfortunate misconfiguration in my vim/git setup. Sorry. /Jarkko