Received: by 2002:a4a:301c:0:0:0:0:0 with SMTP id q28-v6csp354346oof; Mon, 24 Sep 2018 21:49:59 -0700 (PDT) X-Google-Smtp-Source: ACcGV63tHsvSOVlxvyU4lFubQtYJVUbmG8authvgotEqJqtte11kjS5c4/B5rC98j8+bBHVJABcB X-Received: by 2002:a63:fb57:: with SMTP id w23-v6mr1547502pgj.441.1537850999790; Mon, 24 Sep 2018 21:49:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537850999; cv=none; d=google.com; s=arc-20160816; b=NBq6Wjac6u/KzwsZ+Euy5LhvGhsEw1PCAwpISjdojn5GuhvQO/ywtiIK1oiW0vbrQg hlNg7lSiJHIc7370CD5U7kBKtbT8kmPFl+n2ZJetPoQXrhbFVW9YBxwGkCgk7Nx6vmHd PNR7srhB/2xSNDfr+PJMZE67cJ8I1laenLoX5ILsDPri9aN53xCFw4Zk13d8Y5l4Ujxl eQktuxo0CBZCwyLSmPXMU/k0abvAHQpSNm/izpJ4Ls7QattoF/iYJYnLYp7oygNWY041 qdLLGX8qv4nqdefRG9RlahGGAjvjIj8hlBBsysGteHiVFX9iR44b/0MQuuiLYVJD8qbX vSuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=K74nHdM9hfoZEiC5+SL4y2mgDGZue50S+i55roEdpMg=; b=vXMJ4SIGnQj1k+7X4a9l1dNY8jmlp55hVk6TkYForH0Vcmp8E3ALBdqj5IA8J4ceTB o8qsfZsZj/61RGSeZkLehu1oyNz4OliGBs5AyWjzYf8Qk/ec8pazCudESex8WrzA8fsN RjZX+Sc/MM6aqDEoz04yX/6/r5/TV+/aLra3ZJGe6IwQJJlkMYJWCFdNgMAaSUAHVPrA tTJ9BFhrxtPcsUba2xDuYTIxLauzMSB1L//Hp97fF86Rf3ngJoo9lHZLHTww2t7RmO3j FUbyek9tnnsXrQgYkKFRsoQK+Ki80MtODnp2ws0v/KYrFq/ZYP5aTQ9zOS8x5ZuG7nCx DBXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y11-v6si1146031pgr.217.2018.09.24.21.49.43; Mon, 24 Sep 2018 21:49:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726125AbeIYKzS (ORCPT + 99 others); Tue, 25 Sep 2018 06:55:18 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:34082 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725959AbeIYKzS (ORCPT ); Tue, 25 Sep 2018 06:55:18 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1g4fHt-0003Ua-R9; Tue, 25 Sep 2018 12:49:29 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1g4fHq-0004sz-9E; Tue, 25 Sep 2018 12:49:26 +0800 Date: Tue, 25 Sep 2018 12:49:26 +0800 From: Herbert Xu To: Kees Cook Cc: Ard Biesheuvel , Eric Biggers , linux-crypto , Linux Kernel Mailing List Subject: Re: [PATCH crypto-next 00/23] crypto: skcipher - Remove VLA usage Message-ID: <20180925044926.vkkj2fnfvshjqpt5@gondor.apana.org.au> References: <20180919021100.3380-1-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 24, 2018 at 05:49:37PM -0700, Kees Cook wrote: > > > Kees Cook (23): > > crypto: skcipher - Introduce crypto_sync_skcipher > > gss_krb5: Remove VLA usage of skcipher > > lib80211: Remove VLA usage of skcipher > > mac802154: Remove VLA usage of skcipher > > s390/crypto: Remove VLA usage of skcipher > > x86/fpu: Remove VLA usage of skcipher > > block: cryptoloop: Remove VLA usage of skcipher > > libceph: Remove VLA usage of skcipher > > ppp: mppe: Remove VLA usage of skcipher > > rxrpc: Remove VLA usage of skcipher > > wusb: Remove VLA usage of skcipher > > crypto: ccp - Remove VLA usage of skcipher > > crypto: vmx - Remove VLA usage of skcipher > > crypto: null - Remove VLA usage of skcipher > > crypto: cryptd - Remove VLA usage of skcipher > > crypto: sahara - Remove VLA usage of skcipher > > crypto: qce - Remove VLA usage of skcipher > > crypto: artpec6 - Remove VLA usage of skcipher > > crypto: chelsio - Remove VLA usage of skcipher > > crypto: mxs-dcp - Remove VLA usage of skcipher > > crypto: omap-aes - Remove VLA usage of skcipher > > crypto: picoxcell - Remove VLA usage of skcipher > > crypto: skcipher - Remove SKCIPHER_REQUEST_ON_STACK() > > How do these look to you, Herbert? I'd really like to make sure these > make it for the next merge window -- they're the last VLAs left in the > kernel now. :) I have no problems with the crypto parts. Do we have acks for all of the others? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt