Received: by 2002:a4a:301c:0:0:0:0:0 with SMTP id q28-v6csp807600oof; Tue, 25 Sep 2018 05:04:11 -0700 (PDT) X-Google-Smtp-Source: ACcGV60chLrdXVDd1uNfoKIe7wMXV2pulNRleFiTKQnuaDIheFqPZsD6H+56rOhj1t/YJkfjvFir X-Received: by 2002:a63:7419:: with SMTP id p25-v6mr746953pgc.395.1537877051284; Tue, 25 Sep 2018 05:04:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537877051; cv=none; d=google.com; s=arc-20160816; b=rI0TUsJrToc77X+zRKvv1X0cAxSlxyaCYMUgEV43kDQ5uyf0F6FtxoguqK8y2io0ij jhYbKF+qoa5EjLJpG/gulA5HwWwLWMv2T00377uM333sdIt16tNNnS4pHBOGVpKUrcE7 lKvSXelzlDIQp9bjTFfgKKL9dZThReM23+QbasN3xfW48Dbt4NViYEWKM344lqX18EIW 1YKE/RRH12krY1Y+FkMY+tvg3hBtuz6sqV3veIiettH0QucAa7BboyOL0zXVoIaGXABd 3qTarVN5tnp5pEDTn4TLtTMHQ/NDll23EumH9Qdawg2IupTNBa/GYuvBrLSdbQaVepI2 XCFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=VYEW7ht00VUcAk5YZHzmqxXiRl5qowM6sR3VDqHDTYs=; b=qTVgeSDqSFBJ4JySiTg4hyQtzXXARyM7THXJOpWXZoS1Zf6t+GIT68cquqD/XVut56 C5dtU/+AW5XnqJ16OtMRA8WuT7MFvc+KY+9OPw2l0Kj5i7psqnr4Vh8NgkBOFQKzIP86 Kwo6l+fI17ElTFPotMDOOuIuslEi2lcM5iINbraORCqDIuIo8bYsYK8TqwBCCj2RJOdP XUpjPS8eD8HuAeJDLlZeAGWSNlAHSI8485Ncyj7FNy8YO3uCdrBCkZOnEwFqcL6LsCs0 sbYZczH6BhL20CN4eWZlsQcYntI9cE8UdcaMlV6/anE1NEtoOznHhZfcbZhcY0P0AUhG LUpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g92-v6si2350167plg.445.2018.09.25.05.03.54; Tue, 25 Sep 2018 05:04:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727570AbeIYSK4 (ORCPT + 99 others); Tue, 25 Sep 2018 14:10:56 -0400 Received: from mail-pg1-f169.google.com ([209.85.215.169]:35096 "EHLO mail-pg1-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726586AbeIYSK4 (ORCPT ); Tue, 25 Sep 2018 14:10:56 -0400 Received: by mail-pg1-f169.google.com with SMTP id v133-v6so3861669pgb.2 for ; Tue, 25 Sep 2018 05:03:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=VYEW7ht00VUcAk5YZHzmqxXiRl5qowM6sR3VDqHDTYs=; b=ewGCDSa/y1RYrp7oNnO/7DzKTs/3kVC8z6EM8rTYZBw/HFECnbHy9m3RqpB5ZHi6sA PwtR+JHUVqM5brYsXy+uOEG1+/5l94hlHlAT5ZfDgZtlv/giuArUpaW4zDCzCMrn3uX5 s3EMFOu9ErPbEb4B6rX+CUn+QZ+mVZSnGp17eFcauJgIt3vlhSlB6Haj0N2TKbab5qCQ EnDguXTEzYfNtZeLbpP1a1px1bR8lrkh54cIvAGb/zL266srTBppJB7/yMMwVYPljqPY wDGnJUOyk25crlp6mv74G3zr5RFVL89Ct00faC8dwv9TNsIMo6rExXGG3rJx+RBDZHIR PPpQ== X-Gm-Message-State: ABuFfohF/VwsDJMom/EzJxZj2GinwOaqkXguZ2l5RBeQzy6hgpTxilFy tMuDNULsOlZkpYFLDppKIQ4= X-Received: by 2002:a63:e116:: with SMTP id z22-v6mr755481pgh.89.1537877022928; Tue, 25 Sep 2018 05:03:42 -0700 (PDT) Received: from tiehlicka.suse.cz (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id h132-v6sm3657449pfc.100.2018.09.25.05.03.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Sep 2018 05:03:42 -0700 (PDT) From: Michal Hocko To: Andrew Morton Cc: Mel Gorman , Vlastimil Babka , David Rientjes , Andrea Argangeli , Zi Yan , Stefan Priebe - Profihost AG , "Kirill A. Shutemov" , , LKML Subject: [PATCH 0/2] thp nodereclaim fixes Date: Tue, 25 Sep 2018 14:03:24 +0200 Message-Id: <20180925120326.24392-1-mhocko@kernel.org> X-Mailer: git-send-email 2.18.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, this has been brought up by Andrea [1] and he proposed two different fixes for the regression. I have proposed an alternative fix [2]. I have changed my mind in the end because whatever fix we end up with it should be backported to the stable trees so going with a minimalistic one is preferred so I have got back to the Andrea's second proposed solution [3] in the end. I have just reworded the changelog to reflect other bug report with the stall information. My primary concern about [3] was that the __GFP_THISNODE logic should be placed in alloc_hugepage_direct_gfpmask which I've done on top of the fix as a cleanup (patch 2) and it doesn't need to be backported to the stable tree. I am still not happy that the David's workload will regress as a result but we should really focus on the default behavior and come with a more robust solution for specialized one for those who have more restrictive NUMA preferences. I am thinking about a new numa policy that would mimic node reclaim behavior and I am willing to work on that but we really have to fix the regression first and that is the patch 1. Thoughts, alternative patches? [1] http://lkml.kernel.org/r/20180820032204.9591-1-aarcange@redhat.com [2] http://lkml.kernel.org/r/20180830064732.GA2656@dhcp22.suse.cz [3] http://lkml.kernel.org/r/20180820032640.9896-2-aarcange@redhat.com