Received: by 2002:a4a:301c:0:0:0:0:0 with SMTP id q28-v6csp852262oof; Tue, 25 Sep 2018 05:38:17 -0700 (PDT) X-Google-Smtp-Source: ACcGV63zjO8cF14Cy8TsaO6v2gyd2t/TpYMwV5UpimQg5/h4/zTObjm1RGhsEWVrT4rDCJ1l8VBQ X-Received: by 2002:a62:2c53:: with SMTP id s80-v6mr957916pfs.154.1537879097086; Tue, 25 Sep 2018 05:38:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537879097; cv=none; d=google.com; s=arc-20160816; b=oLhw4kU2xzL+EtUIDxCn18whPElpMHhoYqmStwU5u8dWxogNsiHzz0wPZKaD6tzNi5 tEF3mnF7od/+mpsmceBFCpUG1DlqkgoIz6kwaC0KiGPQ+QQE/0YAPYZAHbdMv357uDIE E5qqgKQiUO4ywde5H72lXUv+bUz2f3FbypANjAddlQXzwSnb064vaPNRtZLdHv8LsMUF u/stsYvJE0li6dl97WQcfOo4zuZclwcHkbkATkg1doshGnyZBgIHousa5vFMYVJiR4C9 jsqy4hkqZk+oVmr4Nb9+0Ydl5cXcp3/zF2wf1w9YYIrZnHuXpXfwBS+sUqS4wexSR+xp MF5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:date:from:dkim-signature; bh=gH0wuWmPFxuEhPvVxwSajJ2CD6lAeNUE+aZZCwyIDxU=; b=0dDrUev6Ab8QhGctkfbgkomAsT6c7fngT4UojzfTWvrKr7xxRRO4Q5ipybeNttk3Nw 7dCuYkx12rCojVC+DkUTWU5l2f8v1jiRc6kUynb/Tp0u9jQIbbG8oQidz71bagJZi83j ZYe6qbSyLXA0jRkAW9BIJ7p0DwDo8PJ84TlZYzgeP/EFxPpym/wyfdTMtrDaV+Wv2zMg CaopsndybATyr3yr2Yt5R/9IS9X0HCvpI626yfg/QiNrU1+IyfZYa90EYMsSTBGD1B+0 xkahLYj9ObVsH5WWQYzMj9qIzQdCyPMOUreXIwaK1A8iQrqqXSrBZFh4wGjQ0jYS4ZQA j50A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="cD5inT/T"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l2-v6si2377879pgc.196.2018.09.25.05.38.01; Tue, 25 Sep 2018 05:38:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="cD5inT/T"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729125AbeIYSop (ORCPT + 99 others); Tue, 25 Sep 2018 14:44:45 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:39930 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728588AbeIYSop (ORCPT ); Tue, 25 Sep 2018 14:44:45 -0400 Received: by mail-wr1-f67.google.com with SMTP id s14-v6so23180050wrw.6 for ; Tue, 25 Sep 2018 05:37:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gH0wuWmPFxuEhPvVxwSajJ2CD6lAeNUE+aZZCwyIDxU=; b=cD5inT/TKcPNrwUGb0SvA0bi8en5Z4t60qK5hDyfgPMlBDd9npgfytM2jJPr869rE5 c6jFvwH5vnfMQmk+2jPnER5/vX40K8Mpyur3jEIL7XSvUopEUC7mxo5tcyCJkua7a+Oo g7HnQS/HX3+oC3d3HmpmOYpg9FU1J5rgFFvuvAh3zNQfdUucVCFeX1hjg8o6xoqCOFg4 KEbzTaDfd1DTB3at76C1SAtGwA0Js7dCAhIuzt6ugKB1T18KvaY2l0zvmFOthFeosrcu d7CxvQs+w0rSJr10a9OLnCUfA77HvU9AKbWfEB4jgWifnGIQHu9y7brxwhC7dTmsU+l9 t09A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gH0wuWmPFxuEhPvVxwSajJ2CD6lAeNUE+aZZCwyIDxU=; b=Ul/DUrFK5YGpAuRTU33zp02qPjbaOgx5VrN3jc6ilVj6ambItGVHymw1q3Cq1JwsNQ CgMInN4AGHTkTid0EUMMmgbBN9j3U1p5owng711qbn3IjjcIDKGoVDZg5kOElsba7Wr5 0sinDBEsxecz+UsMA4UcPY1uLUhqlIxD9IleKkR3mTKth1nypacXbWKeYf6FlaIcuLEa 1yYnvsOFOD5ptpBS6Qy992iGqTwEn2SiyhXGDfFcbwELewiL0MIWlNrVd+F4wQT+mVva ATj2zEbQYBktaBKkBhlBUZlI4HeGDE8N6AFVY8HDtwBrvJ/YHl1uHqW7tTXHPTFS+rPZ Xkfg== X-Gm-Message-State: ABuFfoitBvIuxjXlGMXUKaDiG+QQWZSbnA7W6GgPXPONaYl+Hka8ctst 8MM2/oPQgN4NL0FvWxW7wC8= X-Received: by 2002:a5d:5450:: with SMTP id w16-v6mr910888wrv.4.1537879042002; Tue, 25 Sep 2018 05:37:22 -0700 (PDT) Received: from localhost ([178.121.95.75]) by smtp.gmail.com with ESMTPSA id p11-v6sm2904846wrd.74.2018.09.25.05.37.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 25 Sep 2018 05:37:21 -0700 (PDT) From: Sergey Senozhatsky X-Google-Original-From: Sergey Senozhatsky Date: Tue, 25 Sep 2018 21:37:16 +0900 To: Petr Mladek Cc: Sergey Senozhatsky , Steven Rostedt , He Zhe , Sergey Senozhatsky , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] printk: Fix panic caused by passing log_buf_len to command line Message-ID: <20180925123716.GD523@tigerII.localdomain> References: <1537291068-443145-1-git-send-email-zhe.he@windriver.com> <20180919015030.GA423@jagdpanzerIV> <6c354803-5341-7237-9ee3-7882252c7483@windriver.com> <20180919023932.GA14090@jagdpanzerIV> <20180918224312.6e9aef50@vmware.local.home> <1545bc85-b64a-4b45-d40f-79567ac621dc@windriver.com> <20180920123056.27b2cf18@gandalf.local.home> <20180921073753.mqayzofcofpmhiyu@pathway.suse.cz> <20180925120135.GB523@tigerII.localdomain> <20180925122300.qq5w4skwmxbzi6sy@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180925122300.qq5w4skwmxbzi6sy@pathway.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (09/25/18 14:23), Petr Mladek wrote: > > Thanks for pointing this out. Well, it seems that the change would > require a new syscall to pass the buffer size as long. We need to > be sure that people would use this in the real life. Agreed. > This thread suggested this change to avoid a checkpatch warning. Not exactly. I suggested u64 change not because of a checkpatch warning. But because of u64 memparse() return and because of potential log_buf_len=4G+ -ss