Received: by 2002:a4a:301c:0:0:0:0:0 with SMTP id q28-v6csp991777oof; Tue, 25 Sep 2018 07:05:03 -0700 (PDT) X-Google-Smtp-Source: ACcGV63njw0UeSCUp6vL+yunnPXgrC09KGmp1RhQ77msO3D4mE3ZdfuJ2ma0o+zPs+9MbGI5C61b X-Received: by 2002:a63:ab0c:: with SMTP id p12-v6mr1303626pgf.190.1537884303483; Tue, 25 Sep 2018 07:05:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537884303; cv=none; d=google.com; s=arc-20160816; b=lkpv3OnWupdkDP0ukhIpEQcBlwAX9nZgLiZdvsFIjtr49LUThTI+OvvIsfmuZSZxxO 7TxjBqSqVgQE8dpOIC/DCQst9YfWj2f1ABx2qbIMjQCuBvMZVCmyJBAwSFsxHzT1NUmT /gkNwdIdrLX6hMs9xr3+nn5jsj4M9eV1OWHjqTkCdcKdbNE//nNlVZkQgbSWNkU2Xfi+ vCJ9NOGiVp2D3cjLKE1qkp7BMSGRMjJJ3NXr5FgZe7BZqwi+cgzO/2FX70Iw+UWRf7py CEuXDjk8AfQ7/VFK1VjIV56SuxMzL8JoNbEPFFvZ6lRRip1B04M5hku2GDaxh6Rv8c70 y82A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:feedback-id:mime-version:user-agent :references:message-id:in-reply-to:subject:cc:to:from:date :dkim-signature; bh=XGUdJoj5Fs1dP41yVJe4rL6K+rZLLBMvG2C7+Vp/xJ4=; b=qrY6t7AIE/JZCDwkhgn/lToLgwKSaEA5uwqQ6s6pnMAGJKIKX6Chw6qvCSvv/cSdGp ycEMHUWXWln9isjJrRq6rvVFtUG/5Afpp2/easxcyieZxC7GZ0sLV//jzb86CWqFLcT9 hPTaPXRk4MVq939urSvFEEqUCtcKxcgrmMXdf2aZCxgFkLUQZY8F08jbzFlelwGg3I/H A39xqCpCNp3t2DUnY3fzkNCNO5prRg6+/I4ZgAgviWMc8IukV16QINoCtXEoC0ytMlWm jh5uFdu5VXU+nnYmpPFRbnXhfZ7PrubIHF+AvgZeR775ZMfXs8DsrQaSG2HCNtcG75E7 wFVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazonses.com header.s=ug7nbtf4gccmlpwj322ax3p6ow6yfsug header.b=Wq03ZSWV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a61-v6si2622447plc.80.2018.09.25.07.04.44; Tue, 25 Sep 2018 07:05:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amazonses.com header.s=ug7nbtf4gccmlpwj322ax3p6ow6yfsug header.b=Wq03ZSWV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729209AbeIYUMO (ORCPT + 99 others); Tue, 25 Sep 2018 16:12:14 -0400 Received: from a9-46.smtp-out.amazonses.com ([54.240.9.46]:35776 "EHLO a9-46.smtp-out.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729098AbeIYUMO (ORCPT ); Tue, 25 Sep 2018 16:12:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=ug7nbtf4gccmlpwj322ax3p6ow6yfsug; d=amazonses.com; t=1537884273; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:MIME-Version:Content-Type:Feedback-ID; bh=XGUdJoj5Fs1dP41yVJe4rL6K+rZLLBMvG2C7+Vp/xJ4=; b=Wq03ZSWVY/1n6P35p2EL3k3GD0GC3JIrgHu2V0QPI8weQ51+dhw981l+fAySdQjG cY/rhGb2EFC+I43xzNus2VsIGIA3fvtyu2KVDf3r9dhZ05u0m8PghGtTGDhwVMq+tkd WMun5kHwvXauPs9VcqrMsDN3LcZG6RusXVms1BGQ= Date: Tue, 25 Sep 2018 14:04:32 +0000 From: Christopher Lameter X-X-Sender: cl@nuc-kabylake To: Dmitry Vyukov cc: Dmitry Torokhov , syzbot+87829a10073277282ad1@syzkaller.appspotmail.com, Pekka Enberg , "linux-input@vger.kernel.org" , lkml , Henrik Rydberg , syzkaller-bugs , Linux-MM Subject: Re: WARNING: kmalloc bug in input_mt_init_slots In-Reply-To: Message-ID: <01000166110bb882-0b1fa048-fe1c-4139-a1ba-702754bbc267-000000@email.amazonses.com> References: <000000000000e5f76c057664e73d@google.com> <010001660c1fafb2-6d0dc7e1-d898-4589-874c-1be1af94e22d-000000@email.amazonses.com> <010001660c4a8bbe-91200766-00df-48bd-bc60-a03da2ccdb7d-000000@email.amazonses.com> <20180924184158.GA156847@dtor-ws> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-SES-Outgoing: 2018.09.25-54.240.9.46 Feedback-ID: 1.us-east-1.fQZZZ0Xtj2+TD7V5apTT/NrT6QKuPgzCT/IC7XYgDKI=:AmazonSES Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Sep 2018, Dmitry Vyukov wrote: > Assuming that the size is large enough to fail in all allocators, is > this warning still useful? How? Should we remove it? Remove it. It does not make sense because we check earlier if possible without the warn.