Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 25 Sep 2018 10:55:54 -0400 (EDT)
From:   Vladis Dronov <vdronov@redhat.com>
To:     Alan Stern <stern@rowland.harvard.edu>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Oliver Neukum <oneukum@suse.com>,
        Hans de Goede <hdegoede@redhat.com>,
        syzkaller@googlegroups.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, stable <stable@vger.kernel.org>
Message-ID: <13984886.16016319.1537887354102.JavaMail.zimbra@redhat.com>
In-Reply-To: <Pine.LNX.4.44L0.1809251012040.1517-100000@iolanthe.rowland.org>
References: <Pine.LNX.4.44L0.1809251012040.1517-100000@iolanthe.rowland.org>
Subject: Re: [PATCH] usb: usbfs: fix crash in
 check_ctrlrecip()->usb_find_alt_setting()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Thread-Topic: usbfs: fix crash in check_ctrlrecip()->usb_find_alt_setting()
Thread-Index: N1pN1orxDvlqdu0l2DHznH0UzA/W0g==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> What reason is there for having two different fixes for the same bug?
> This one isn't going to get into any mainline trees that don't already
> have c9a4cb204e9e.

I believe this is the right thing to do, so usb_find_alt_setting()
is not called with a known-bad argument.

Honestly, I would change "if (!config)" in usb_find_alt_setting() to
"BUG_ON(!config)" so we know when its callers do smth wrong and go
fix callers. Unfortunately, I understand this hardly will be accepted.

Best regards,
Vladis Dronov | Red Hat, Inc. | Product Security Engineer