Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] staging: dgnc: Fix Kconfig help header and text
To:     sehro rautenkranz <sehro@sehro.org>, lidza-louina@gmail.com
Cc:     markh@compro.net, driverdev-devel@linuxdriverproject.org,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
References: <20180925062001.12273-1-sehro@sehro.org>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <d5bb4ab0-42f6-3fd1-006d-670a355e8702@infradead.org>
Date:   Tue, 25 Sep 2018 08:34:43 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <20180925062001.12273-1-sehro@sehro.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 9/24/18 11:20 PM, sehro rautenkranz wrote:
> Replace Kconfig help header and text to match other modules. Issue found
> by checkpatch.
> 
> Signed-off-by: sehro rautenkranz <sehro@sehro.org>
> ---

Hi,

Documentation/process/coding-style.rst says:

Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.


>  drivers/staging/dgnc/Kconfig | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/Kconfig b/drivers/staging/dgnc/Kconfig
> index 032c2a795238..c845b357b53d 100644
> --- a/drivers/staging/dgnc/Kconfig
> +++ b/drivers/staging/dgnc/Kconfig
> @@ -2,5 +2,9 @@ config DGNC
>         tristate "Digi Neo and Classic PCI Products"
>         default n
>         depends on TTY && PCI
> -       ---help---
> -       Driver for the Digi International Neo and Classic PCI based product line.
> +       help
> +            Say Y here to enable support for the Digi International Neo and
> +            Classic PCI based product line.
> +
> +            To compile this driver as a module, say M here: the module will be
> +            called dgnc
> 

thanks,
-- 
~Randy