Received: by 2002:a4a:301c:0:0:0:0:0 with SMTP id q28-v6csp1132117oof; Tue, 25 Sep 2018 08:40:01 -0700 (PDT) X-Google-Smtp-Source: ACcGV61Y0VnlKWP/38QnuoddXdoGx+dQC5chklwsGgsQ7zgRwTfQfCBZX8ZPBbNbwWHI1RQnyEns X-Received: by 2002:a62:8f:: with SMTP id 137-v6mr600655pfa.24.1537890001567; Tue, 25 Sep 2018 08:40:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537890001; cv=none; d=google.com; s=arc-20160816; b=i6WuGigjghewYu06+g/MtdtstB4u+09EkuJv4C2WkzRo3KwDopNH2vYLVCKtzD8ASY imjgdpWq7QcEod4gngg5gehUJs825P8LkAEcucGqP3lkJyoY1zM8ishch/TlZ8VimYKY 9YrRWbBW0vp8IJThl6FBtUR/g3c1H+8KKwUAvoL03gOvqFktjb3TXfWuJ6OBI0SIDXoB 4ANDmL22Rvcatk4EGEYC8hGxhTndmXgo7LgUo0RHLMAOvstjQiHgZew/MS7zO0v8xGgG 0sOvf0y3P8HSUyWU6MKyGl5PjnSxQnWQHBQHpRbhvUs+v0YNnJxL3TrLAtSXjzP3THZS G0iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature; bh=mfwCTU3gBuwKB0JS+HTf1c/pKKqrJ0HMnISheVsQs5k=; b=LicTkFc8fwQqTvXP+lEXOEfgBmnfuTyd/OM7quP/5VaW2oz2+vW3dt1CVu2kvyue62 uOUDQ4r9xE8gqMZ4S59diwSHBJQM/mAVm5RS7FFeMwWJ1K7vz85VCpa2Sp15fblS3rUB x8jkVHYkUg91s6/FYfcyl1FqhLmMamsnw+ww9298h4jyOr3bWrKdkoBDZwiTg25Q1g57 P9kIa+q/EWJEW23O2uhf4hjJZtGcEUtKBYcX4169G4hI9pmvaHZMsgLkU5302Mzfbjqf u8I+7vTQHMqna16Q+YUm25ZAe4/9M8SJTKEze0Cebt1mV5gHLx/gPy//VSlDFFHxXFCr IGSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=DKRtb+17; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gn24si2667536plb.43.2018.09.25.08.39.46; Tue, 25 Sep 2018 08:40:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=DKRtb+17; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729792AbeIYVrS (ORCPT + 99 others); Tue, 25 Sep 2018 17:47:18 -0400 Received: from mail-yw1-f65.google.com ([209.85.161.65]:41080 "EHLO mail-yw1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729398AbeIYVrR (ORCPT ); Tue, 25 Sep 2018 17:47:17 -0400 Received: by mail-yw1-f65.google.com with SMTP id q129-v6so9473803ywg.8 for ; Tue, 25 Sep 2018 08:39:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=mfwCTU3gBuwKB0JS+HTf1c/pKKqrJ0HMnISheVsQs5k=; b=DKRtb+17jotvuUM9ICHQ1jMRgPUbB88Cj2LK7Ty0gWqcrFgCJ95cu+j4zjvtpumD1T QqctzFbB1kVWrUyORVm93ZRwT2nnPsTqarWfjDZxq4zZxDFQtFipjEXTQQqQpkn9JZ8X LZVOiffpFUuzxg5uJzsMvsCFVCv6Ofwm6pVPw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=mfwCTU3gBuwKB0JS+HTf1c/pKKqrJ0HMnISheVsQs5k=; b=RJeegiKd6K0A6Wc87qYoSYsWetimbvQh47+BYdHLtA9oK8Jywz8/DzHGX7jsp5SD7m /UO0/8A4DenNPrKZ7EabA62prycMJ15omYhjgiyey01CGl4XkrMNHjdtDblCyKUHDd8V 57npdBsyUFjbLEwsiAMdAlMTv7fq/cB0LilloPNONjuAsZXDFFEtuUJAZ903MDjjLPDh EAM67rLm3g3RofZUr6PqgvrH1lm9KaB8nN74hmuOXxITNOVpeZT59lLCAi12wB232/j7 HM+lpuqk3tERRQjhSPQ+ZzYnx5RSq5nGUq1ePvelShKP0z21g6DYJyMWlV6k85TCmfZg 4Uvw== X-Gm-Message-State: ABuFfoiR4ZgIfpHjnZHyB8sYOmYLniN5o5ICCHEQ5P2Q8UVZaziGPLQa lCtGFHLfVKpjoh7vvllmBW5Shbex7a8= X-Received: by 2002:a81:ae5f:: with SMTP id g31-v6mr865452ywk.372.1537889952989; Tue, 25 Sep 2018 08:39:12 -0700 (PDT) Received: from mail-yw1-f44.google.com (mail-yw1-f44.google.com. [209.85.161.44]) by smtp.gmail.com with ESMTPSA id j66-v6sm1880065ywc.61.2018.09.25.08.39.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Sep 2018 08:39:11 -0700 (PDT) Received: by mail-yw1-f44.google.com with SMTP id m129-v6so3702888ywc.1 for ; Tue, 25 Sep 2018 08:39:11 -0700 (PDT) X-Received: by 2002:a81:1194:: with SMTP id 142-v6mr902590ywr.168.1537889951317; Tue, 25 Sep 2018 08:39:11 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:5f04:0:0:0:0:0 with HTTP; Tue, 25 Sep 2018 08:39:10 -0700 (PDT) In-Reply-To: <20180925044926.vkkj2fnfvshjqpt5@gondor.apana.org.au> References: <20180919021100.3380-1-keescook@chromium.org> <20180925044926.vkkj2fnfvshjqpt5@gondor.apana.org.au> From: Kees Cook Date: Tue, 25 Sep 2018 08:39:10 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH crypto-next 00/23] crypto: skcipher - Remove VLA usage To: Herbert Xu Cc: Ard Biesheuvel , Eric Biggers , linux-crypto , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 24, 2018 at 9:49 PM, Herbert Xu wrote: > On Mon, Sep 24, 2018 at 05:49:37PM -0700, Kees Cook wrote: >> >> > Kees Cook (23): >> > crypto: skcipher - Introduce crypto_sync_skcipher >> > gss_krb5: Remove VLA usage of skcipher >> > lib80211: Remove VLA usage of skcipher >> > mac802154: Remove VLA usage of skcipher >> > s390/crypto: Remove VLA usage of skcipher >> > x86/fpu: Remove VLA usage of skcipher >> > block: cryptoloop: Remove VLA usage of skcipher >> > libceph: Remove VLA usage of skcipher >> > ppp: mppe: Remove VLA usage of skcipher >> > rxrpc: Remove VLA usage of skcipher >> > wusb: Remove VLA usage of skcipher >> > crypto: ccp - Remove VLA usage of skcipher >> > crypto: vmx - Remove VLA usage of skcipher >> > crypto: null - Remove VLA usage of skcipher >> > crypto: cryptd - Remove VLA usage of skcipher >> > crypto: sahara - Remove VLA usage of skcipher >> > crypto: qce - Remove VLA usage of skcipher >> > crypto: artpec6 - Remove VLA usage of skcipher >> > crypto: chelsio - Remove VLA usage of skcipher >> > crypto: mxs-dcp - Remove VLA usage of skcipher >> > crypto: omap-aes - Remove VLA usage of skcipher >> > crypto: picoxcell - Remove VLA usage of skcipher >> > crypto: skcipher - Remove SKCIPHER_REQUEST_ON_STACK() >> >> How do these look to you, Herbert? I'd really like to make sure these >> make it for the next merge window -- they're the last VLAs left in the >> kernel now. :) > > I have no problems with the crypto parts. Do we have acks for > all of the others? Some have trickled in (wusb, lib80211), along with some Reviewed-bys from Ard. I was hoping that since it was a wrapper-only change there wouldn't be a need to block on waiting for Acks. Thanks for looking at it; I'm excited to finally be done with VLA removals. :) -Kees -- Kees Cook Pixel Security