Received: by 2002:a4a:301c:0:0:0:0:0 with SMTP id q28-v6csp1196828oof; Tue, 25 Sep 2018 09:29:01 -0700 (PDT) X-Google-Smtp-Source: ACcGV63d1OT4oAO3KsEhkqwTxuPyYe2EYHS+P1nQCMtVAa3cmbO4vfQLBu4flCAUKx8a6SVo6VeT X-Received: by 2002:a62:c08b:: with SMTP id g11-v6mr2003477pfk.72.1537892941603; Tue, 25 Sep 2018 09:29:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537892941; cv=none; d=google.com; s=arc-20160816; b=PSalsm4Q4WDei/YwShfd+8ZodNOG27lOdkq2Fm6Be5Mv/aKWv5BUIxhfn7ferAwSzO mTsY6w3/jhGh1APVQ215CrJsHvap7OGPK3BP1FtjQo2gtmzdZwx5jW5uKwdxIlG3AcE+ 1glurSxZouycLTKmf8AeP2lgu+EpsCFsxu8kO0S0wXXeaolEEAqQzKUQnbxgxBLMzZJn JdYm7CKm4mYuDecPEsnWuR+/+w6XaVvj5SMTKyEK1xeFPDEDI+v01Lci6j8xM/R7hlfF 0RlsWvLiR1s7SlCpRWKuelkzU8LtaB+W9xqwmWuCaVkgAvLUgC/ibiS0S9lXeX41Dr5k Yo9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :from:references:cc:to:subject; bh=iytMkSgzKjnleWvMHRTNj9Sa4y/5DDMfpIyciW275lM=; b=D4A6fz7E4SxfdWRjtRobH4IkDAy756u4HX9RFXLR9YOIlubFrOky/jXON8wY/Skfmp ioaLh5b0qpRX45tIW/H6DCKHmEn0EAXW38adUjBjNCMOb83zBQmk63+Xr1vVmNL1uUP5 qy/l2yRxt+FopjjrxMgZLrMb37eRZBKpO1wlVWTlURYURzu5CrwydFjRT4Pb9MSdNgfV tzWr5RGsP45SAI+bzbyNbcINAElyS5ftxSKEdE/luaJ8Wh9e5fQgYEoHM56udUWZjVBG 5PbpHEJ2UcbRRxs8hc+YW4/cTMYl3ZUIXs/UrNlvvNg+1oZmZ7XYyLH3qNuZIjaV2r5g E0lA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g28-v6si2746290pgg.384.2018.09.25.09.28.45; Tue, 25 Sep 2018 09:29:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727544AbeIYWgr (ORCPT + 99 others); Tue, 25 Sep 2018 18:36:47 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:47726 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726706AbeIYWgr (ORCPT ); Tue, 25 Sep 2018 18:36:47 -0400 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w8PGRV1O027329 for ; Tue, 25 Sep 2018 12:28:31 -0400 Received: from e32.co.us.ibm.com (e32.co.us.ibm.com [32.97.110.150]) by mx0a-001b2d01.pphosted.com with ESMTP id 2mqr4ds9kv-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 25 Sep 2018 12:28:30 -0400 Received: from localhost by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 25 Sep 2018 10:28:29 -0600 Received: from b03cxnp07028.gho.boulder.ibm.com (9.17.130.15) by e32.co.us.ibm.com (192.168.1.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 25 Sep 2018 10:28:25 -0600 Received: from b03ledav001.gho.boulder.ibm.com (b03ledav001.gho.boulder.ibm.com [9.17.130.232]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w8PGSOd462914708 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 25 Sep 2018 09:28:24 -0700 Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5C4F16E056; Tue, 25 Sep 2018 10:28:24 -0600 (MDT) Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E39856E054; Tue, 25 Sep 2018 10:28:19 -0600 (MDT) Received: from [9.77.205.177] (unknown [9.77.205.177]) by b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 25 Sep 2018 10:28:19 -0600 (MDT) Subject: Re: [PATCH v3 06/20] tpm: move tpm1_pcr_extend to tpm1-cmd.c To: Jarkko Sakkinen , Tomas Winkler Cc: Jason Gunthorpe , Alexander Usyskin , Tadeusz Struk , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180918093459.19165-1-tomas.winkler@intel.com> <20180918093459.19165-7-tomas.winkler@intel.com> <20180919140634.GA27854@linux.intel.com> From: Nayna Jain Date: Tue, 25 Sep 2018 21:55:27 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180919140634.GA27854@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 18092516-0004-0000-0000-0000149188F6 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009769; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000267; SDB=6.01093506; UDB=6.00565184; IPR=6.00873543; MB=3.00023498; MTD=3.00000008; XFM=3.00000015; UTC=2018-09-25 16:28:27 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18092516-0005-0000-0000-000088EF80A4 Message-Id: <7af3302c-3c46-ebc7-bf9b-704c8eaaa6b7@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-09-25_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809250162 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/19/2018 07:36 PM, Jarkko Sakkinen wrote: > On Tue, Sep 18, 2018 at 12:34:45PM +0300, Tomas Winkler wrote: >> Move tpm1_pcr_extend to tpm1-cmd.c and remove >> unused pcrextend_header structure. >> >> Fixes warning: >> drivers/char/tpm/tpm-interface.c:609:38: warning: ‘pcrextend_header’ defined but not used [-Wunused-const-variable=] >> static const struct tpm_input_header pcrextend_header = { >> ^~~~~~~~~~~~~~~~ >> Signed-off-by: Tomas Winkler > Reviewed-by: Jarkko Sakkinen > > Can someone with a working IMA environment to test it? Don't have one > right now (should probably setup). I think I can try testing this patch sometime next week. I will test the updated version. Thanks & Regards,     - Nayna > > /Jarkko >