Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 25 Sep 2018 20:15:07 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Nadav Amit <namit@vmware.com>
Cc:     Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org,
        Xavier Deguillard <xdeguillard@vmware.com>
Subject: Re: [PATCH v2 17/20] vmw_balloon: compaction support
Message-ID: <20180925181507.GA25458@kroah.com>
References: <20180920173026.141333-1-namit@vmware.com>
 <20180920173026.141333-18-namit@vmware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180920173026.141333-18-namit@vmware.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Sep 20, 2018 at 10:30:23AM -0700, Nadav Amit wrote:
> --- a/include/uapi/linux/magic.h
> +++ b/include/uapi/linux/magic.h
> @@ -89,5 +89,6 @@
>  #define UDF_SUPER_MAGIC		0x15013346
>  #define BALLOON_KVM_MAGIC	0x13661366
>  #define ZSMALLOC_MAGIC		0x58295829
> +#define BALLOON_VMW_MAGIC	0xba11007

Any specific reason why you didn't put the leading 0 on your magic
number to make everything align properly?

And there is no need to put this in magic.h, nothing outside of your
code sees this value.  It is not a user api, so please do not make it
one.

thanks,

greg k-h