Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4102348imm; Tue, 25 Sep 2018 11:20:29 -0700 (PDT) X-Google-Smtp-Source: ACcGV60bf0exweKVDCNo+oJ5HfIPQjzmPb7aSV5Tajg9Dqma+KF7AYJAOn5FHUUrvl8COdqzSvQD X-Received: by 2002:a62:898d:: with SMTP id n13-v6mr2168759pfk.57.1537899629629; Tue, 25 Sep 2018 11:20:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537899629; cv=none; d=google.com; s=arc-20160816; b=HGm77jbPzxxX0lQf7z53aOSr127ybTpHG2CgLOQ8BzDBtjrkbOz+OQhjRETyz8TxzW 95LP/NWxHJUKQ24WA7L7c1uztOOEtXXg8W7+8Jl8SZHK+gddKE+ki08OamTm8H/pkt5Y gtLxbppCnBZasfg3GtYg0lFz+we+lZYbfpftesVMtiDmdW2VPUXP52ao4QOwCqBJIDcL 10J6aCBMTCixY5pf/g7jWWm+S9aDiFJzPC2UjobR/qchtaDT9yXmboPZquf5gPYXIJBm BCs+gpI0xD3IUKfatbEmiX6ekQcyVDt+XS5XnKLAQdwlfB4grgdiaj6AMlT7ePO7vHz/ KjyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=EVD+TYyGcRgC9u/4BO+yrYu0TFYEngutYRUdF7UVHy4=; b=oNUKekvmSbCnVwpHI1erGXx0NVLso+pt8VT2GPF9yVAsf9SbNuoLOnIeiwEUd0XsMA XxNXSzbTbRG8b12kXKUguV/7U3rHP46XTTVap/61JWn/ZIJkOjL481tLqMpI5K9c9GYz KZmQlgRkPssWwo5JOzyr9wH4s6hkhqdIFKBxA1ttIiqK0ZLD5bMqyiHwGsSnffW6Ouiy /FzNGMy8T+hIn9ljn5aLzFFXhFQC5fjcYRUWax2EYkEthq6sW4Ntx6quUmlwjMk0Desf c1xfRni1rIZT0Il0xizjecwpk+rGd5ELFBe3mlevlhaPBlFpvgHJjUHEQeLjK96KxA8f OItw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w61-v6si3007487plb.511.2018.09.25.11.20.13; Tue, 25 Sep 2018 11:20:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727407AbeIZA1P (ORCPT + 99 others); Tue, 25 Sep 2018 20:27:15 -0400 Received: from mx2.suse.de ([195.135.220.15]:39334 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726335AbeIZA1P (ORCPT ); Tue, 25 Sep 2018 20:27:15 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 1EEC0AFF3; Tue, 25 Sep 2018 18:18:29 +0000 (UTC) Date: Tue, 25 Sep 2018 20:18:26 +0200 From: Michal Hocko To: Arun KS Cc: Vlastimil Babka , kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, boris.ostrovsky@oracle.com, jgross@suse.com, akpm@linux-foundation.org, dan.j.williams@intel.com, iamjoonsoo.kim@lge.com, osalvador@suse.de, malat@debian.org, yasu.isimatu@gmail.com, devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, xen-devel@lists.xenproject.org, vatsa@codeaurora.org, vinmenon@codeaurora.org, getarunks@gmail.com Subject: Re: [PATCH v2] memory_hotplug: Free pages as higher order Message-ID: <20180925181826.GW18685@dhcp22.suse.cz> References: <1537854158-9766-1-git-send-email-arunks@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 25-09-18 11:59:09, Vlastimil Babka wrote: [...] > This seems like almost complete copy of __free_pages_boot_core(), could > you do some code reuse instead? I think Michal Hocko also suggested that. Yes, please try to reuse as much code as possible -- Michal Hocko SUSE Labs