Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4179198imm; Tue, 25 Sep 2018 12:43:59 -0700 (PDT) X-Google-Smtp-Source: ACcGV62vR9Uqwtiqjnqj3czyaviThnukbVZEVqtDiqN5EbDxz58GnH86gXZvDiFs19eZPrLqyDt9 X-Received: by 2002:a65:6102:: with SMTP id z2-v6mr2429605pgu.46.1537904639526; Tue, 25 Sep 2018 12:43:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537904639; cv=none; d=google.com; s=arc-20160816; b=JQqpznsB+KUkhjMIqwT7Cdf/dUGNaxnUlLQtFtCb85Rfl2Ci2XsmqVIteoOOxpDBG/ JHpqaIsrv8z+9IWKtrQvnBtC8qyahWcKxDt2uQcwUk96UyOzL/n364F6TTM6dOhmpveZ NazJ3RB7DiyQR38oRUG5zlNPdl08vM7RbQCpAtwC7w4l4lktVE31WT3fMHxIfqdhczxB i9L8rOEUw+3BF54FVqC2WYNWCnRAnoJMd+kenbcyri0N/qwOKmo7ODuzdbmTOlVKnAEk SxOLPz9zqUSMNbrpauIG1g/kQ+XB6SzPb77dmefGRsQpzqJDBWfy9V2ci+Faa9d9F/hx 9gIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=EMbQn+2OY0LrHwAc/60IimoERTECB+oB4f34f3wlNcI=; b=s+/BhzKY5q2nmSyTZgca87oNe0egHAIa2T8wR0kHKgULLYjXCe/4sKAVofW2oyaGYm j5FlVSPa9nNQFQciX687u6RUgmo0DeMPV2aZeD1v78mqkHzi4zDurc/lFCPtskNNMrtM U3KY/Cif3z0uZDUD/j9Cb5NC46iL3CYqxhKN2VKbAM5NVrLeMwlEQCjtbvCCXLbYitGg 5wiO4vk9xfYVLGBOkhuHJqKhQqRxVp1gSBtV5uhgchrmao25HNGO3Kx032Qttqnh7OBO N+h3fzdFy/klQmFVNzmyR2Z1iWVYoTxIeI74BgjXhRlrtfB8tPzk0pr9lMPjlu7vTmFl IiAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QvLS542A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d24-v6si3277814pgk.315.2018.09.25.12.43.43; Tue, 25 Sep 2018 12:43:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QvLS542A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727541AbeIZBwa (ORCPT + 99 others); Tue, 25 Sep 2018 21:52:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:45564 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727340AbeIZBw3 (ORCPT ); Tue, 25 Sep 2018 21:52:29 -0400 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 570B120880; Tue, 25 Sep 2018 19:43:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1537904602; bh=xUjnwwWHaUElZaunMyyEO52IwSEnXoY6ne4VGRmHmY4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=QvLS542AvpVvnsTsOd+mOVRwASdl2UMOW2mkY9j93kQ2rCv2/blJ+TvJVVoZTCi+2 yEMVhjPvtM5TqhNcXPBywbmRSHO2Ku/Ck6rODsrDYa60g0ffe1v2srC6kotfZ53900 yISCPtAmzWfavMDouPNppuF9Su2cSdtqgsRsAA4M= Received: by mail-qk1-f169.google.com with SMTP id b19-v6so14255337qkc.6; Tue, 25 Sep 2018 12:43:22 -0700 (PDT) X-Gm-Message-State: ABuFfoj493M7fJd7cb2+zhuw/mGahTbzU8W8mdaPWHcHaR5NfvaS87EI hC+ZVeWG4k3xonf9Pqo3C7fS5bBkuqWra5EkvQ== X-Received: by 2002:a37:12d1:: with SMTP id 78-v6mr1895586qks.147.1537904601588; Tue, 25 Sep 2018 12:43:21 -0700 (PDT) MIME-Version: 1.0 References: <20180627045234.27403-1-rnayak@codeaurora.org> <20180627045234.27403-3-rnayak@codeaurora.org> <20180703223554.GA32313@rob-hp-laptop> <20180704055757.4li26b6poxllmh2k@vireshk-i7> <1463d24b-481d-eecd-9e44-e7a5a993e5fc@codeaurora.org> <271db7b1-f65b-f42d-b00b-9362429b3749@codeaurora.org> In-Reply-To: <271db7b1-f65b-f42d-b00b-9362429b3749@codeaurora.org> From: Rob Herring Date: Tue, 25 Sep 2018 14:43:10 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/6] dt-bindings: power: Add qcom rpm power domain driver bindings To: Rajendra Nayak Cc: Viresh Kumar , Stephen Boyd , Andy Gross , Ulf Hansson , David Collins , Matthias Kaehlcke , devicetree@vger.kernel.org, linux-arm-msm , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 25, 2018 at 5:25 AM Rajendra Nayak wrote: > > Hi Rob, > > []... > >>>>> + rpmhpd_opp_table: opp-table { > >>>>> + compatible = "operating-points-v2-qcom-level"; > >>>>> + > >>>>> + rpmhpd_opp_ret: opp1 { > >>>>> + qcom,level = ; > >>>>> + }; > >>>> > >>>> I don't see the point in using the OPP binding here when you aren't > >>>> using *any* of the properties from it. > >>> > >>> Yeah, that's the case for now. But there are cases (as Stephen > >>> mentioned earlier [1]) where the voltage values (and maybe other > >>> values like current, etc) would be known and filled in DT. And that's > >>> why we all agreed to use OPP tables for PM domains as well, as these > >>> are really "operating performance points" of these PM domains. > >> > >> Rob, are you fine with these bindings then? > > > > Okay, my only thought is whether we should just use 'reg' here, or do > > we need 'level' for anything else and should make it common? > > I am not quite sure I understood what you are suggesting here :( You could use the 'reg' property instead of 'qcom,level'. Any reason not to do that? Alternatively, would 'level' be something useful in other situations and should not be QCom specific? Rob