Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4209560imm; Tue, 25 Sep 2018 13:17:45 -0700 (PDT) X-Google-Smtp-Source: ACcGV63wIjXnV2plItIDiPbtJH91dayTyvJCq5EE/Rk+9tjo6fFIgO0/75pEUbpuQDPlU75y6wfm X-Received: by 2002:a63:5059:: with SMTP id q25-v6mr2444206pgl.171.1537906665682; Tue, 25 Sep 2018 13:17:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537906665; cv=none; d=google.com; s=arc-20160816; b=Sw22rePK8yVQis8S2v3tXJq6zy1gXAc5i6Gdp8MrDmB8dGixyz3qZgzTZURJ0n86dZ UZfjopFR7aBXOFAMkNhLKG7VdvyQEO3Jid6hmZ8Y3DsN9eRBDWBdpuYsgFtdAc2Ud2rx qCYGieaP5VP/5OdOI5NgK0P62/b+fZTzwwOv1CB7YeI9SHwdEk27P4uImcgt0y1/X0jX sYkdjdnO+6m0IcFE9MXjQHoduTDs8cL0HohGv8NF9qOQQD/V8wmvccRykk+veE4lsQnl 90f6vL0NqWYuTcBi35GFPpgSAABXpitXcM7LzHc5c6GEt55WMeJfyxCB0LwW1if/I0Gk LFtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=RkPMwxdmL+DmFqPSK5ZNpZcC3YS7AHYyYlzSFv7/X4U=; b=od+T27TZq1a6qFrAaapapP0qkjzGzJSoENVkhM/OjOWSmF5HLViCHBfMmH71pQj8V5 PHIBZPnvqL+dLoPg9T+Qv9nVkMz5rjCTyeuZyADGvude3MtMXri/psAbIBbtMzwNHwlG XVromcAv9qEBP8H9xwr0JItH5BAs0BFFGxwVxXczKqsi+qdYCL6vvW+RGfDUTt5726Tq dNyWXug8N3fmaSyw/Ai/0lWcscvFYHsmZokiM/81SIqb7dM3ryLG5wUcquzg/NM2+5Fv G0vpwuuvF39t6yu939xSKzQxR8gX+aOjr/r9Hd/5F9j73wz90pCWeAFu+pOaRwVTpQSS Dn4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m18-v6si3081183pgb.655.2018.09.25.13.17.30; Tue, 25 Sep 2018 13:17:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727130AbeIZCZg (ORCPT + 99 others); Tue, 25 Sep 2018 22:25:36 -0400 Received: from verein.lst.de ([213.95.11.211]:34618 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726242AbeIZCZf (ORCPT ); Tue, 25 Sep 2018 22:25:35 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 26D1168AEF; Tue, 25 Sep 2018 22:16:19 +0200 (CEST) Date: Tue, 25 Sep 2018 22:16:19 +0200 From: Christoph Hellwig To: Guenter Roeck Cc: Christoph Hellwig , iommu@lists.linux-foundation.org, Greg Kroah-Hartman , Robin Murphy , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marek Szyprowski , Bjorn Helgaas , linux-pci@vger.kernel.org, Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 4/4] dma-mapping: clear dev->dma_ops in arch_teardown_dma_ops Message-ID: <20180925201619.GB8413@lst.de> References: <20180827084711.23407-1-hch@lst.de> <20180827084711.23407-5-hch@lst.de> <20180922150119.GA14761@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180922150119.GA14761@roeck-us.net> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looking at the code I think this commit is simply broken for architectures not using arch_setup_dma_ops, but instead setting up the dma ops through arch specific magic. I'll revert the patch.