Date: Wed, 19 Nov 2003 02:38:15 -0800
From: William Lee Irwin III <wli@holomorphy.com>
To: Paul Jackson <pj@sgi.com>
Cc: linux-kernel@vger.kernel.org, anton@samba.org, ak@muc.de
Subject: Re: format_cpumask()
Message-ID: <20031119103815.GE19856@holomorphy.com>
Mail-Followup-To: William Lee Irwin III <wli@holomorphy.com>,
	Paul Jackson <pj@sgi.com>, linux-kernel@vger.kernel.org,
	anton@samba.org, ak@muc.de
References: <20031117033504.GC19856@holomorphy.com> <20031119013238.21944da9.pj@sgi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20031119013238.21944da9.pj@sgi.com>
Organization: The Domain of Holomorphy
User-Agent: Mutt/1.5.4i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 997
Lines: 21

On Wed, Nov 19, 2003 at 01:32:38AM -0800, Paul Jackson wrote:
> Wouldn't it be a good idea to pass in the length of the remaining
> available buffer space and use snprintf, to avoid overruns?
> We're going to end up with some pretty big cpumasks on some systems --
> running over a buffer would be nasty.  It would mostly happen during
> bring up of new bigger systems; but still worth avoiding.
> A second thought - more controversial - long sequences of digits can get
> pretty difficult to read.  How about breaking them with a separator
> character, say every 32 or 64 bits.

I'm happy just to get the numbers into _some_ format that makes sense.
This could very well be an improvement over the large hexadecimal
number. I say run with it.


-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/