Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp119857imm; Tue, 25 Sep 2018 17:25:25 -0700 (PDT) X-Google-Smtp-Source: ACcGV61XE4A57JmwSvgMppmoVp4RPWz/k1fE6eD42F/56IkvdIzupI4f/p2wnoPist1bCwsZucCM X-Received: by 2002:a62:90d2:: with SMTP id q79-v6mr3182683pfk.37.1537921525627; Tue, 25 Sep 2018 17:25:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537921525; cv=none; d=google.com; s=arc-20160816; b=skpfEahnHMFrW7glc5ifjZDu0F4rMJXTBxSGP6GkMFHTIoX4kno/czRLNY2arWglAO LUWWQ9ur3qaOFMOY/9KfwbdfizGWYXUJN7LTDtCK620YAPWqOirHMuLj0d6dchWxmHAY 4lPWCul9BA6O04Xu/bjOgG8APXCt28GA1uvwIKyMIatJpyNAC4QMEF+rBQFNS2TDbTRM 9We7cPaNrts4rYw6jGe3Ar651M4aDuxhxZitVVwpGE5zsl+VSWL3/2kaPZ+UPs/zqPvx DapHsw12g1LLncdqU+7cSdX7lNdyf0W5xSvxRrY3Os2sQBL8h6BLasdg1s3zVSd4qGvv PqXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=vFZYmtYY9qefXd8f7ZWI4MYxu6yHptwQsQcge+xW/iE=; b=maBqODuXoCAuEmQGLnhKqGL7IDW+Z8ZzYgUbP/65RlDUapxsg2avCvRer8l2GVkYEs k6yoNu6ooakONi85vZJneHoFs2EEJuz5/N21PpoHrh2zvFLRFl6qu09ocZdKrhLnS6NR WQI4BXFa57wzy7qZHgk8RreDN7KEmPbdAMxaO4ke8/FfJKA4R7999fYR3Kc9jEXpzDtx DTlUfiemMY+zonjMsAyCWTEigrOE+XdMCkBZKk4uc63PrcMOINLDvv3tJ5yktCSMWyDD KdBjzqWgdZQ1wkKlItv83yWpR/nlAo67DkdLmUrwC1uLUq+kfwuLZO7rjec6I6sMvZPO W4hw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u5-v6si3792163pgc.459.2018.09.25.17.25.09; Tue, 25 Sep 2018 17:25:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726431AbeIZGet (ORCPT + 99 others); Wed, 26 Sep 2018 02:34:49 -0400 Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:62526 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726124AbeIZGet (ORCPT ); Wed, 26 Sep 2018 02:34:49 -0400 Received: from ppp59-167-129-252.static.internode.on.net (HELO dastard) ([59.167.129.252]) by ipmail06.adl6.internode.on.net with ESMTP; 26 Sep 2018 09:54:41 +0930 Received: from dave by dastard with local (Exim 4.80) (envelope-from ) id 1g4xd9-0006T8-R9; Wed, 26 Sep 2018 10:24:39 +1000 Date: Wed, 26 Sep 2018 10:24:39 +1000 From: Dave Chinner To: Josef Bacik Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, linux-btrfs@vger.kernel.org, riel@redhat.com, hannes@cmpxchg.org, tj@kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 8/8] btrfs: drop mmap_sem in mkwrite for btrfs Message-ID: <20180926002439.GB18567@dastard> References: <20180925153011.15311-1-josef@toxicpanda.com> <20180925153011.15311-9-josef@toxicpanda.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180925153011.15311-9-josef@toxicpanda.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 25, 2018 at 11:30:11AM -0400, Josef Bacik wrote: > @@ -1454,6 +1463,11 @@ static inline int fixup_user_fault(struct task_struct *tsk, > BUG(); > return -EFAULT; > } > +stiatc inline struct file *maybe_unlock_mmap_for_io(struct vm_area_struct *vma, > + int flags) > +{ > + return NULL; > +} This doesn't compile either. -Dave. -- Dave Chinner david@fromorbit.com