Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp133486imm; Tue, 25 Sep 2018 17:46:30 -0700 (PDT) X-Google-Smtp-Source: ACcGV62UcuDWHJ0uSC7fsrRzjbNtU/2WN67LcDnRA431tlIKqRgo+8hzA3hphypeKEcl17ylV1kf X-Received: by 2002:a17:902:780f:: with SMTP id p15-v6mr3506563pll.170.1537922790154; Tue, 25 Sep 2018 17:46:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537922790; cv=none; d=google.com; s=arc-20160816; b=HJ6Z6Zw4/GfJTgIFWSXXdDaxbmXgjd9TOcs9DWJJxNW1eOau3ffDzPyNNFbvROekZi Td4bthC7x59YpXD/s+ruwv/ptM31/3u7hKLfFb0CftmWKUFfBDIDxetgvAjT1C7ImgJs 0i8zYJzvi6QRloYvG5Myt50KpiZUUpjlEgfn3IAkiX88Lefd5WHzpQ4ql1OYGotKN3nY fIyPGT6fAmVJd5O0gIZXdJaJsZX7gOhvCu+xUIFxAL77NWpK20MMif3SSEvdo4wZEoO8 Qz1RGbKk9u7p/yT6CUuZDL7yarlAwtxSINpg+Of4ZGT/qAQH8v7bAM19UZiKd/pE7KiG JS2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=JL6NBRksQqRxvivNTU570LUzSfCFvQQYxnhTllGBtFs=; b=uPf29fo2yUPmVqqAkhnHGF7bHSfmQc/WGPaqQcGG7kTCUDgPpktJCh7OyxOx116vsE AEb3dYDdNcTVFniyCtfrS9D/oZHws4Sxa415pB8PK6jGE1vnNf/7cFdQLlPQ7Ib5nHwz woAImlGj6WWU/2S4u7BOY1yKf6wMi3LhYi0Xi8+bTtxBQ/yFnZI3tVtjE0MNi/tmFwDN xul8qZhnJC4kIinCJrTVkRX3f5b2EPH/B05uzdOqeUuOhpDv10oJDvhrfbD4YHPePkQ1 s3AW4TZc+fVrvxhHUdFtNpO+1Bj4ROu8Z3TAQkbFDQnOve0yalpKlhz+WNMF+S3jZ8mY 3U0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=URV++VXw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 8-v6si4023706pla.252.2018.09.25.17.46.14; Tue, 25 Sep 2018 17:46:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=URV++VXw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726957AbeIZGza (ORCPT + 99 others); Wed, 26 Sep 2018 02:55:30 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:54528 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726265AbeIZGz3 (ORCPT ); Wed, 26 Sep 2018 02:55:29 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w8Q0iMrg188087; Wed, 26 Sep 2018 00:45:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=JL6NBRksQqRxvivNTU570LUzSfCFvQQYxnhTllGBtFs=; b=URV++VXw/P/AIXn51615PI0hBfBitW/pJGapuMGljE9L9RTexpMZSUS1hI2SW7Mrvet2 rrzbnKjDn3VQZZwALWT0jU1MRh1Nt1BrFA5QgXPhmBkuE9LHJKPRr13z+XFf6YA7qwDG AF8LbECJeHA0nXCbML2d47M3WzVS7877PI1oebXAB1C9BGVn4dF0hjscezf90/Y2qDL1 EvVtdSGb8mYyZUN0DM+l5bsxENjuiZH1v/y60B2H67Ps6bPdCurzUNZrrKbTrbJF2I3t bOR88ejv9lltxYlTAdPFEIUXWEdbR7Fvabsm98KrJSfk64RQxjJ+LmdnDzeiPLkT0BtM QA== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2120.oracle.com with ESMTP id 2mnvtup5b1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Sep 2018 00:45:09 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w8Q0j87F009881 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Sep 2018 00:45:09 GMT Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w8Q0j7fH027482; Wed, 26 Sep 2018 00:45:08 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 25 Sep 2018 17:45:07 -0700 To: zhong jiang Cc: , , , , Subject: Re: [RESEND PATCH v2] scsi: Use vmemdup_user to replace the open code From: "Martin K. Petersen" Organization: Oracle Corporation References: <1537286081-63081-1-git-send-email-zhongjiang@huawei.com> Date: Tue, 25 Sep 2018 20:45:05 -0400 In-Reply-To: <1537286081-63081-1-git-send-email-zhongjiang@huawei.com> (zhong jiang's message of "Tue, 18 Sep 2018 23:54:41 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9027 signatures=668707 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=397 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809260006 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org zhong, > vmemdup_user is better than duplicating its implementation, So just > replace the open code. Applied to 4.20/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering