Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp342536imm; Tue, 25 Sep 2018 23:03:08 -0700 (PDT) X-Google-Smtp-Source: ACcGV63kC0XbjEKbXf65GOEq+kGAyjRtU9K9Fz1CByY/ujeicChsrKqblY7LV3BJkllMhnGisdfQ X-Received: by 2002:a63:4281:: with SMTP id p123-v6mr4054955pga.91.1537941788079; Tue, 25 Sep 2018 23:03:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537941788; cv=none; d=google.com; s=arc-20160816; b=T2jiWGbWM7ZumhUikbqWJhwPjQMrOiTVqKJR1eGp7f5rfNh31J5UaNcnw8WqxhuHg0 X8lW5VT1ruEp1R4Eg4ANDSrPEYKMdQbkVZHIBRYrX3ZAihKS3vqfz1QyQHNnQEDONmgD xRV8XbSpd8nWLD7DUjzzBs/m5P1rK5YqrNM7kwEZDlCBTsaA7MJlNsdvw8yys5xrAsf0 96Mn+hbFFASACl4NT/2eXe99w60M3TON0ii+SOzHiaZ2vUMeRPIhWzqAHUP1zlwdHizl 68aZ36TSV7DqJ4ERYQF7x7NytYlxz0APtnFtZucR/GM2Zgy7++Ksz9QMTYwhcb60NTv6 XDdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:references:message-id:date :thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=7mF2uaLbCLIkddR9I5SUi5AybHyY3v8WRnqAb7bNqr0=; b=WT7akMkJKEXCKKS1vsosmGL3nBQhVG74kl/QsaZ5zwnAlgqEIT3OAJ/iDBtuwsqV8y 9khUBfwBQWdU+I8YjAE80232IZLNAeMavoYSLBy7jWrWqEbaVYflHiq990EE8XR0rzjR A8OlHWgWEsWDTqKWsBCeHVM7Y3TxGx+CPh/QksJMRz+n8NbhMsuZAdho5ad0rhenRHvr sxr9oDMvp+q5JCuFZIuHa3kVR+VGxUZ6RVnxJJVVHXvzVtJyCNizkVCkBcIXw2990d0i KYlD0yoqGqj5XxO/jrtmB62RjHSHbK4heJrGjDrDKNk0LvXHsj+T55wCnQ85irS8lE1Y Fc6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=ddNCHJ5b; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w126-v6si4252350pfb.232.2018.09.25.23.02.50; Tue, 25 Sep 2018 23:03:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=ddNCHJ5b; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726470AbeIZMOA (ORCPT + 99 others); Wed, 26 Sep 2018 08:14:00 -0400 Received: from smtprelay.synopsys.com ([198.182.47.9]:54870 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726343AbeIZMOA (ORCPT ); Wed, 26 Sep 2018 08:14:00 -0400 Received: from mailhost.synopsys.com (mailhost2.synopsys.com [10.13.184.66]) by smtprelay.synopsys.com (Postfix) with ESMTP id B7BF924E08FE; Tue, 25 Sep 2018 23:02:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1537941765; bh=pxlQm2dZ3Yxt2r9Lftg6++qsyxu3o6OkIiKMvYj1SJI=; h=From:To:CC:Subject:Date:References:From; b=ddNCHJ5bAwpCpk3cyvzx/Ae+aKu7R6Ddpow+cV/PTajcgRfn4Tlx0KoN458VXIWpn x7MXzFKIH0BmQGt8dF7QQoiCPVjmnSlGHUT4SQL4vLchOyuPuwbzl9/jH7ih8gCWTv lPlsw5DsinKAVpteKfoqVaLA1avKg5VcTdnAyfnTGU0SGpNmgcl0KEXa0QxNiK3SnF DGNFvuah2cqx69Y6MQ0OLTSt/Ee15MN9AqyaHHKhQG/zauqUqO1L3a01RuAqixWmrN 4JgOGR/tf/fqLQj/7NxTfCtJQRqg2IXsThUG1jDfmdQHu+wO4FisZgotqhZrhuBVZr f8pXES0l6vqYw== Received: from us01wehtc1.internal.synopsys.com (us01wehtc1-vip.internal.synopsys.com [10.12.239.236]) by mailhost.synopsys.com (Postfix) with ESMTP id 6894E3494; Tue, 25 Sep 2018 23:02:45 -0700 (PDT) Received: from AM04WEHTCB.internal.synopsys.com (10.116.16.192) by us01wehtc1.internal.synopsys.com (10.12.239.231) with Microsoft SMTP Server (TLS) id 14.3.361.1; Tue, 25 Sep 2018 23:02:44 -0700 Received: from AM04WEMBXB.internal.synopsys.com ([fe80::1006:bcdd:1b7:579b]) by am04wehtcb.internal.synopsys.com ([::1]) with mapi id 14.03.0361.001; Wed, 26 Sep 2018 10:02:42 +0400 From: Artur Petrosyan To: John Stultz , Artur Petrosyan CC: Minas Harutyunyan , lkml , John Youn , "Felipe Balbi" , "linux-usb@vger.kernel.org" , Manivannan Sadhasivam Subject: Re: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down feature Thread-Topic: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down feature Thread-Index: AQHT7ws4O+8B/axYs0CeMD+6l4m0jQ== Date: Wed, 26 Sep 2018 06:02:41 +0000 Message-ID: <3AD91E696667BF4BA728303C178E8A63532AB864@am04wembxb.internal.synopsys.com> References: <1526690943-8211-1-git-send-email-john.stultz@linaro.org> <410670D7E743164D87FA6160E7907A5601313531E1@am04wembxa.internal.synopsys.com> <410670D7E743164D87FA6160E7907A560131356C4E@am04wembxa.internal.synopsys.com> <3AD91E696667BF4BA728303C178E8A63532AAF6D@am04wembxb.internal.synopsys.com> <3AD91E696667BF4BA728303C178E8A63532AB36A@am04wembxb.internal.synopsys.com> <3AD91E696667BF4BA728303C178E8A63532AB5E5@am04wembxb.internal.synopsys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.116.70.210] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John,=0A= =0A= On 9/25/2018 21:59, John Stultz wrote:=0A= > On Tue, Sep 25, 2018 at 3:04 AM, Artur Petrosyan=0A= > wrote:=0A= >> Just a clarification by this commit "[PATCH] usb: dwc2: Fix HiKey=0A= >> regression caused by power_down feature"=0A= >> https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__marc.info_-3Fl-3D= linux-2Dusb-26m-3D152669095513248-26w-3D2&d=3DDwIBaQ&c=3DDPL6_X_6JkXFx7AXWq= B0tg&r=3D9hPBFKCJ_nBjJhGVrrlYOeOQjP_HlVzYqrC_D7niMJI&m=3D0lMkv7adFVwkzyaUzD= 6-pUG0iwg4fd6b1-aHQgbqvSI&s=3Dm8SZvo3J_Za08sMbo-S9EkhoA06YnzEN-SRm-uTPnbg&e= =3D=0A= >>=0A= >> the power_down is disabled setting "p->power_down =3D false;" in=0A= >> "dwc2_set_his_params" function.=0A= >>=0A= >> Could you please clarify that the testes done for those 3 patches were= =0A= >> done enabling "p->power_down =3D true;" in "dwc2_set_his_params" functio= n.=0A= > =0A= > So if I remove the "power_down =3D true" initialization, USB does not=0A= > seem to function.=0A= > =0A= > If I boot w/ the gadget port removed, the USB host ports do work, but=0A= > plugging in the gadget cable results in a bunch of:=0A= > dwc2 f72c0000.usb: Waiting for Host Mode, Mode=3DPeripheral=0A= > messages.=0A= > =0A= > If I boot w/ the gadget port plugged in, USB gadget mode doesn't seem=0A= > to function at all, and when I remove the gadget cable nothing=0A= > happens, it doesn't switch to host mode.=0A= > =0A= > thanks=0A= > -john=0A= > =0A= =0A= Could you please send the dmesg logs for those situations?=0A= Also, please specify the version of the kernel that the testes has been =0A= done on.=0A= =0A= Regards,=0A= Artur=0A= =0A=