Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp525325imm; Wed, 26 Sep 2018 02:42:16 -0700 (PDT) X-Google-Smtp-Source: ACcGV61U4i6C4JG7reQFid/zqG66P2kWPo2QjI6LmX88wFCYPsQ0RE3UsgqEYN1SSdWiFBwAhSBe X-Received: by 2002:a63:eb53:: with SMTP id b19-v6mr4838607pgk.371.1537954936069; Wed, 26 Sep 2018 02:42:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537954936; cv=none; d=google.com; s=arc-20160816; b=eCQWsTH4rBk5vpl0Sy20BB2gHS4NC5xFm5mNV7DxywUfzKioenBHQbCidwfVwGGR5B yRiSiVIm7kuh6KXcBDB7ihKEBP2MgPQJzc3KA0RbqghpmBaSuUfAyXaqLuAImu1Abx3f cx+elTNv/mIrOJUkl0rkitgFKGyGZSmlg++oRM8o5EwkMNbB3BKBbwijtO8v5rP6KZPw h1Elg+SXkFFnHR0K+4I/lJWBXFm+Gn+Z7aSlrgISN0kXnDXVCafvI1BGAGaTu3o+fQKO 3i/q9RLrJAAJot5bznxOg2uCF2tpxrf70mEmgiAN0/wyIgHjqR/Zi0UuWkIqAMUTsOix WSsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=TtP0UP6LNOsTLwvBJn8TVR+huoknwRCXfrgYOPbcXlQ=; b=HmRbVgzJj6X6MPz86CsgG3rMtVfNujX0UaxYYUVp2dL/3fVA044vk8GTk9+iWoIpMx LXbkHg/guhhY4H2yEYv3Pjle+OK2YJ8Asiq4w4vk0dw7CLQjgNS9/hQ7Q/4OAdXed3x+ CZhHPI4X8eJm2+pWipKOChCEy63sCitr42OzM+4iNNwth4c32hLYSEeIQYIwdLKiD1jd 91G/1V52rPw2y90PuZbN4RcE5dRbJrwjZ4MEkaODefl/k5roO71M+d8bDkkIJwmPCltv uGJBq+uVp1t2bdr8LBldGWTGvRM9l5lNgc0fMVHl5uhHCQ9ZG5LsV8xmWQXJg0/IzSFq BQ9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f29-v6si4757587pgl.570.2018.09.26.02.41.59; Wed, 26 Sep 2018 02:42:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727136AbeIZPxj (ORCPT + 99 others); Wed, 26 Sep 2018 11:53:39 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:55052 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726565AbeIZPxj (ORCPT ); Wed, 26 Sep 2018 11:53:39 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 42KtHW0gZbz9ttST; Wed, 26 Sep 2018 11:41:27 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id c59T4_WQr0DD; Wed, 26 Sep 2018 11:41:27 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 42KtHW038zz9ttRc; Wed, 26 Sep 2018 11:41:27 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 4AD958B803; Wed, 26 Sep 2018 11:41:27 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id 2ttDEZ_Gdx60; Wed, 26 Sep 2018 11:41:27 +0200 (CEST) Received: from PO15451 (unknown [172.25.231.3]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 217E58B7EB; Wed, 26 Sep 2018 11:41:27 +0200 (CEST) Subject: Re: [PATCH v3 2/2] powerpc/64: add stack protector support To: Segher Boessenkool Cc: Russell Currey , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Andrew Donnellan , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <2b934594d21ade67a4092637cf9e6b7d2d131187.1537801613.git.christophe.leroy@c-s.fr> <0797fc91-6400-2508-1cc0-4bba78aafbbb@c-s.fr> <30fb4e6b-0981-c53c-a1db-94138eaad268@c-s.fr> <20180926092806.GM23155@gate.crashing.org> From: Christophe LEROY Message-ID: <284752d1-6c32-bdca-72d3-4d8616b26fbf@c-s.fr> Date: Wed, 26 Sep 2018 11:41:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180926092806.GM23155@gate.crashing.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 26/09/2018 à 11:28, Segher Boessenkool a écrit : > On Wed, Sep 26, 2018 at 09:58:30AM +0200, Christophe LEROY wrote: >> Segher, any idea about this problem ? > >>>> arch/powerpc/platforms/powermac/bootx_init.o: In function `bootx_printf': >>>> /var/lib/jenkins-slave/workspace/snowpatch/snowpatch-linux- >>>> sparse/linux/arch/powerpc/platforms/powermac/bootx_init.c:88: >>>> undefined reference to `__stack_chk_fail_local' > > Are you building as PIC? Are you linking libssp_nonshared.a? Why not? Spotted, thanks. arch/powerpc/platforms/powermac/Makefile contains: CFLAGS_bootx_init.o += -fPIC Does it mean we should add -lssp_nonshared to LDFLAGS_vmlinux ? Or maybe stack protection on bootx_init doesn't make much sense and we could just do the following ? CFLAGS_bootx_init.o += -fPIC $(call cc-option, -fno-stack-protector) Christophe > > :-) > > > Segher >