Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp579905imm; Wed, 26 Sep 2018 03:40:21 -0700 (PDT) X-Google-Smtp-Source: ACcGV60TsGfa9bB+30es7fCZESRZlZwEORXtPc/+J5NIHs2k76fpv4dPTwiMPkeoB68wqwFFT6hR X-Received: by 2002:a63:904a:: with SMTP id a71-v6mr5217759pge.264.1537958421151; Wed, 26 Sep 2018 03:40:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537958421; cv=none; d=google.com; s=arc-20160816; b=gq12dx4R2XyhhN+OGY2FYS4qnXnITG6s/J+cqz+ThZQSp0qlYSdmmZ3ftPn2WqLWZY dYpfGg1KUkHAjF/BoaKVhel53q4sNZxk5RsWpnCdchgTr1G+YT9q70UKTNqGpueG6vuX 5MxqeZhktY7WTIPa/vpwXGKJTkuRs+IeGUStyQkrjPONlnKt2b1SwFdUVGvlZtxrk4dC Chim1L1hhyslu4p2SZVLqKVKHZtRSQtys6X2IU3bItJfC/xuWQ+QaOCGmcrhusaY7xRU Hp7lcJ+X3ElVC/x4VvuT9lPDmFlmTUubUS4ZtUtK0aoQm6m5+YBbtnUmoyT7ZJQfL6yl px8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:organization:message-id:date:subject:cc:to :from:dkim-signature; bh=yNXFMy53N6gT1zYx/IpkRkHViO7Zjh/0sApPQhNZFaQ=; b=GYwwE3RnF/xATky84/sxSLjsMH4Zckgq1CjyeK8kv1VltH2SNDXBWcJx3WBf5v1CPy fuATDak15U7VJ71E2ryEzpNyY0kb5R4uJC1As5X1IFG0XGsTsdLCsI6xJusqtyGgKXsW SPEQG4k9E8Itf6XhkefLCiIw0+P4kzh5FuRi/f5th7mOwD4Up5kmT5hA91bl37MVwMsM CLPB7XLAt2QO84XzGf03o/eQx6ZwVYbzqTQTh5dLkZMgPHZnnpf5SqvAkQEDh0HcDEGK 6AiGAK0IGCxvkmOByBrGmgDilrQ5vuBvnOcUEucfq+b7bcbmsbNis5IY6DcB7uJ8bF5X KgeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=t21wrzqb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t11-v6si4017804plq.63.2018.09.26.03.40.05; Wed, 26 Sep 2018 03:40:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=t21wrzqb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727435AbeIZQuR (ORCPT + 99 others); Wed, 26 Sep 2018 12:50:17 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:47710 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726497AbeIZQuR (ORCPT ); Wed, 26 Sep 2018 12:50:17 -0400 Received: from avalon.localnet (nat-242.udc.es [193.144.61.242]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 43254506; Wed, 26 Sep 2018 12:37:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1537958275; bh=j99ZjXI8qlnrC2UnJA8C+hbsBg4EC9YycNZjepTzxY0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t21wrzqbEyXPsXlIK5L7rMFkLSxs1fvCNqNmU1M+d6J5yypVeOYHGgHCe9EJ25/N1 GppdgUTC37Z2XV0ifll7wjibjaBsS2RD6xH7NMp4tsssQwILReRtIgEI/CoHX9+UHE 81o4ur08HmBDPePzO0ysXOZatzorGn/tf4I44gzI= From: Laurent Pinchart To: maxime.ripard@bootlin.com Cc: Yong Deng , Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Chen-Yu Tsai , "\"David S. Miller" , Greg Kroah-Hartman , Andrew Morton , Arnd Bergmann , Hans Verkuil , Geert Uytterhoeven , Jacob Chen , Neil Armstrong , Thierry Reding , Philipp Zabel , Todor Tomov , Sakari Ailus , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v11 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI) Date: Wed, 26 Sep 2018 13:38:08 +0300 Message-ID: <1568838.d8CnAYTeDB@avalon> Organization: Ideas on Board Oy In-Reply-To: <20180926103547.5ubb6xjkl7xngmfg@flea> References: <1537951204-24672-1-git-send-email-yong.deng@magewell.com> <7197338.mhOH8fQaEM@avalon> <20180926103547.5ubb6xjkl7xngmfg@flea> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime, On Wednesday, 26 September 2018 13:35:47 EEST maxime.ripard@bootlin.com wrote: > On Wed, Sep 26, 2018 at 01:19:34PM +0300, Laurent Pinchart wrote: > > > +Endpoint node properties for CSI1 > > > +--------------------------------- > > > > Should you list the CSI0 properties as well ? As the driver in patch 2/2 > > doesn't support the CSI-2 interface I assume you have left out CSI0 for > > now, but it should still be listed in the bindings. I'm fine with fixing > > this as a follow-up patch to avoid missing the v4.20 merge window, but if > > you end up resubmitting the series, could you please address the problem > > ? > > That driver is not available, and the documentation isn't either, so > there's no easy way to tell which properties are going to be needed > before doing the actual work of reverse engineering it and writing a > driver for it. Unfortunately... While DT bindings should be independent from driver implementations, I agree it's difficult to develop good bindings without hardware documentation and without at least one working driver implementation. How about just explicitly stating that these bindings don't support CSI0 yet ? -- Regards, Laurent Pinchart