Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp750921imm; Wed, 26 Sep 2018 06:19:24 -0700 (PDT) X-Google-Smtp-Source: ACcGV63cxLUUT/DvuL9zlhlUmOtNWQJQFP8XOiqYixIWAjff9R5BlIPvw89+1sG3hFJnp2s7UuNn X-Received: by 2002:a17:902:4401:: with SMTP id k1-v6mr5960638pld.97.1537967964349; Wed, 26 Sep 2018 06:19:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537967964; cv=none; d=google.com; s=arc-20160816; b=DBG+MtvO7/wEajHU5N7UouJ/Fq0SC1H+kf8JjhYEhfr6moawuZSRD+V2DJeRLjk1/3 aGTKl8vKyDEfPV018IZ8Kb4b16cUEMse1rxdt/T1upu3AicFYAijLXwGYVcej1bMtBlE 09c9nBHo97e2gkPZyfvFKXpFM4V5ulnTT8Da5g4YusJQqQ/wArF307RW5/P3vLN4Q1eh o2imnFb+rGBnRMqMe+/tb2sFXVrE5ZOK9oIXxsogd7NFk409ko45RWW2iNdEqJ3FM+Qo yBxqM7Pz/Ua1rr9+yLWNg7JrSGAbNArSQdY8QkQDsAe8/P7LFm3LGjJSnwsSIjDD3eut Tyuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=YizIjjOVVllkHXHANTXv8MTYismIHj3/mLdUsPq6qyY=; b=ZdbLhQvYvpxlMLBeXLdbevT9iE+gDLm79kzdknR1YMOP3yRElWI7LRFhFJuTOyddWo soNQhvMbDg9SwpDICll81zzCqAvGuR3kRqa7Vf8b41j5gjKiTLq69zvK5jCki5QqqAqc TkbCDZYibh415jtczI9aB/VZud39a1jGwci5pvYpsjpSKGCRUhrpZNo9a4Lq9t/NqQ24 0krQJuC+kLweiXRIAp4gyZOzm8itLO3CqQw15qfZQXyLY2Q6l9gKbhgkYzWIUSg5XMHq 9ZPrphmWUZdAcThQLeR7UILFeNuEm6F0kAsSn6mXH4OwQSbmpR+i1S84kZRx3fbipIpG qQAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h3-v6si4969376pgc.122.2018.09.26.06.19.09; Wed, 26 Sep 2018 06:19:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728490AbeIZTbp (ORCPT + 99 others); Wed, 26 Sep 2018 15:31:45 -0400 Received: from mx2.suse.de ([195.135.220.15]:57702 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726768AbeIZTbp (ORCPT ); Wed, 26 Sep 2018 15:31:45 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 239C9AD6D; Wed, 26 Sep 2018 13:18:49 +0000 (UTC) Date: Wed, 26 Sep 2018 15:18:56 +0200 From: Borislav Petkov To: "Lendacky, Thomas" Cc: Baoquan He , Kairui Song , "Singh, Brijesh" , "x86@kernel.org" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "mingo@redhat.com" , "hpa@zytor.com" , "tglx@linutronix.de" , "dyoung@redhat.com" Subject: Re: [PATCH] x86/boot: Fix kexec booting failure after SEV early boot support Message-ID: <20180926131856.GD6920@zn.tnic> References: <20180925111020.23834-1-kasong@redhat.com> <6e15796e-31e9-2dc6-4a31-5c1b01554b45@amd.com> <20180925172608.GB15464@zn.tnic> <20180926073252.GC2555@MiWiFi-R3L-srv> <20180926112208.GE2555@MiWiFi-R3L-srv> <3b41fee3-e2f6-2e36-d2ca-1074c5f62bb8@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3b41fee3-e2f6-2e36-d2ca-1074c5f62bb8@amd.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 26, 2018 at 01:01:00PM +0000, Lendacky, Thomas wrote: > No concern from me. The original version of the patch did not cache the > value, that was added based on the patch series feedback. So, if there > is no concern about executing some extra CPUID/RDMSR instructions, then > it would certainly simplify the code quite a bit. Yeah, I think it was me who suggested to cache it but having simpler code greatly outweighs the minute caching win. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)