Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp757481imm; Wed, 26 Sep 2018 06:24:59 -0700 (PDT) X-Google-Smtp-Source: ACcGV60g8xQMQT9+0iyxXRlxKT9TUeHxvDWsGcoI3G//0GHQQnKfifjqkxXXhc/VJqmkE92a720B X-Received: by 2002:a63:9a42:: with SMTP id e2-v6mr5849982pgo.263.1537968298966; Wed, 26 Sep 2018 06:24:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537968298; cv=none; d=google.com; s=arc-20160816; b=Kv2cSu/EOk57a+V/ClbTZr0codlAQeVGy9YTUo7wFrKX/AJy5vCjhiDIkgvUuIlWVn FAsSX5RNGoClkyWh5jwoCHpD2Aj9kHUL1iqZUVXZcuMhUyO6aavzUdH0LOPCmuA9SfLl nX96kmTKFH0olax00vhpFvskCX7HyXSMEXvVwoR9SeawKe225TqwybWJZpp/MjR8PFBX 7AP7oWKEdi5GHyYAEHltV9t2vArLfEJ+BNYxkDyeloEfccyyIj++DX97MmX1ZiThUPPv FtpOobUoYUptQjeBXVzB0nEPBTLYYgl4QoZO5JOiqMvaKAMlN0RbuR8T5kbZ417xdur6 cnHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=jZGsVNcQdXgMG4CdMFByJK1CsAcAxunt1fcn7ssIes4=; b=v6ZLw9oF0AFXfeF1YyUvCicl6UcmDlTiT3A8ZfB6btpaTni2UyXFd9b8wd/Bq2T/Ap skhAam2/fASm4sDCMavy4BXEcBmidQlfVDX266FXC6WtCaQv3aUjUQfDTBKeXJuwY5zS Hi5wcRbP4rTVBR/DphqTzKFCLHzB/eqLGh1C4XBMQaztWzCAu1fe0omMRWfjrTWzydb9 JW0mtDa3aLBPjOg2L/Ffv39q46JMeC/XxC+KSqld9PI46hFMwncBSUu4xDTTc8qLc97F IHWft7GyaIZdoNrbrJnk8P5Kp5xaBsBs5UOosT+fjHpQeCpHoge+jRTSgS1xMMjtJHRQ FGfQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o5-v6si1531207plk.95.2018.09.26.06.24.43; Wed, 26 Sep 2018 06:24:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728875AbeIZTf7 (ORCPT + 99 others); Wed, 26 Sep 2018 15:35:59 -0400 Received: from inva021.nxp.com ([92.121.34.21]:57746 "EHLO inva021.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728737AbeIZTf5 (ORCPT ); Wed, 26 Sep 2018 15:35:57 -0400 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 05E3C200253; Wed, 26 Sep 2018 15:23:00 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id ECD8220004C; Wed, 26 Sep 2018 15:22:59 +0200 (CEST) Received: from fsr-ub1864-101.ea.freescale.net (fsr-ub1864-101.ea.freescale.net [10.171.82.97]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id 49506203C2; Wed, 26 Sep 2018 15:22:59 +0200 (CEST) From: laurentiu.tudor@nxp.com To: devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: roy.pledge@nxp.com, madalin.bucur@nxp.com, davem@davemloft.net, shawnguo@kernel.org, leoyang.li@nxp.com, robin.murphy@arm.com, bharat.bhushan@nxp.com, Laurentiu Tudor Subject: [PATCH v2 15/22] dpaa_eth: fix SG frame cleanup Date: Wed, 26 Sep 2018 16:22:40 +0300 Message-Id: <20180926132247.10971-16-laurentiu.tudor@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180926132247.10971-1-laurentiu.tudor@nxp.com> References: <20180926132247.10971-1-laurentiu.tudor@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Laurentiu Tudor Fix issue with the entry indexing in the sg frame cleanup code being off-by-1. This problem showed up when doing some basic iperf tests and manifested in traffic coming to a halt. Signed-off-by: Laurentiu Tudor --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index 8db861f281a0..605f06f0def8 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c @@ -1663,7 +1663,7 @@ static struct sk_buff *dpaa_cleanup_tx_fd(const struct dpaa_priv *priv, qm_sg_entry_get_len(&sgt[0]), dma_dir); /* remaining pages were mapped with skb_frag_dma_map() */ - for (i = 1; i < nr_frags; i++) { + for (i = 1; i <= nr_frags; i++) { WARN_ON(qm_sg_entry_is_ext(&sgt[i])); dma_unmap_page(dev, qm_sg_addr(&sgt[i]), -- 2.17.1