Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp774252imm; Wed, 26 Sep 2018 06:39:05 -0700 (PDT) X-Google-Smtp-Source: ACcGV6089IX1DU3lDKSQVZhJfSyDMh/a68ZvfDWq/uQAMqQBFFuvGnvizIiHF3Wq57YunOg15DmA X-Received: by 2002:a62:69c9:: with SMTP id e192-v6mr6374012pfc.35.1537969145212; Wed, 26 Sep 2018 06:39:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537969145; cv=none; d=google.com; s=arc-20160816; b=BeVjG87wp5UrZNR5gNMnmFpwZeSnmYdqmmUzYg0f+7Ru5ky1JO36tpmaHirh6KV29c hUVBguo93oXLIqz9VouS0/1Jvrg9h0kjRM95KOYP2oytvNpXvtGIivMFX4y0vJSvksul 48g0QfyhnKCiPpnF0LVkBR/Zl5eYmj4NMEHYK+M4KtfXywb6uY211gUbnY4avN1eazof Fzc+das+yMK92mCJtzMmPZI2fE7HnCZw1/4KtkX0zN56+y6l2MlueiLzlRYskCymzPR2 HB9bL0xtLfRdLxIeTR27Oi+ZHqJzot0BnAuONzo62Mp/dLJCQ0LCT7wIea/Y8fW2XgTX 0wZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject; bh=w7pi7m+0z/XUkifp2HBvb1De7V0l0OXKKTeIZpgXwtU=; b=Ct4zE/HStez7zANBF5soFvhw1mFP141Z4jFmkj6UDSWJX6bhkNxTllEGBWhDA5s712 sr3WkI4PtILDlVhqXGnJWkYO9Mr3PeAvrtpYQUlohwXSu/VzTGPI0qukbBvMz8S9OQk2 qJZp/acJrKr40EnEXaNy2zRXKNQUggy0bG7FSqb4TEBuHzObvl34v9esVT6qvFMZ0mCk d6BpG1Gstsov8s7iFAJ1fr3TDdJEfJPAbeaurBlrVV6TtiIsl4Ib9YPpKvrUhv8OgYvZ N3WZNwMWUFrKJL0moBUsLahBXj3Ko/sgn0Cbqm6CYQAf6y4rMbFjcZS1RshcHWidv+5y hMBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o7-v6si5308092pls.344.2018.09.26.06.38.49; Wed, 26 Sep 2018 06:39:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727356AbeIZTvF (ORCPT + 99 others); Wed, 26 Sep 2018 15:51:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55836 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726987AbeIZTvF (ORCPT ); Wed, 26 Sep 2018 15:51:05 -0400 Received: from smtp.corp.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E564087624; Wed, 26 Sep 2018 13:38:01 +0000 (UTC) Received: from localhost.localdomain (ovpn-12-101.pek2.redhat.com [10.72.12.101]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D38BD8CB8A; Wed, 26 Sep 2018 13:36:52 +0000 (UTC) Subject: Re: [PATCH 0/3] find_next_iomem_res() fixes From: lijiang To: Bjorn Helgaas Cc: dan.j.williams@intel.com, brijesh.singh@amd.com, bhe@redhat.com, thomas.lendacky@amd.com, tiwai@suse.de, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, mingo@redhat.com, baiyaowei@cmss.chinamobile.com, hpa@zytor.com, tglx@linutronix.de, bp@suse.de, dyoung@redhat.com, akpm@linux-foundation.org, Vivek Goyal References: <20180921073211.20097-2-lijiang@redhat.com> <153782698067.130337.12079523922130875402.stgit@bhelgaas-glaptop.roam.corp.google.com> <1894f2ba-42ab-c044-ea0c-63eab98d9815@redhat.com> Message-ID: <4295243b-20b4-9d21-5863-bab102a6a6d9@redhat.com> Date: Wed, 26 Sep 2018 21:36:48 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1894f2ba-42ab-c044-ea0c-63eab98d9815@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 26 Sep 2018 13:38:05 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2018年09月26日 17:22, lijiang 写道: > > > 在 2018年09月25日 06:14, Bjorn Helgaas 写道: >> Hi Lianbo, >> >> These three patches are a possible replacement for your first patch >> ("[PATCH 1/3 v3] resource: fix an error which walks through iomem >> resources"). >> >> I think the interface of find_next_iomem_res() can be improved to make >> the code easier to read and also avoid the errors you're fixing. >> >> I can't test these, so they've only been compiled. If you can test >> them and if you like them, feel free to incorporate them into your >> series. If not, just drop them (but please at least fix the same >> error in walk_system_ram_range()). >> > Hi, Bjorn > Sorry for my late reply about this. No need to incorporate them into > my patch series, you might freely submit them to upstream. > > I will test your patches whether it can also work well for my case, and > you will get feedback about my test later. > For my case, your patches can also work well. > Thanks. > Lianbo > >> --- >> >> Bjorn Helgaas (3): >> x86/kexec: Correct KEXEC_BACKUP_SRC_END off-by-one error >> resource: Include resource end in walk_*() interfaces >> resource: Fix find_next_iomem_res() iteration issue >> >> >> arch/x86/include/asm/kexec.h | 2 - >> kernel/resource.c | 96 ++++++++++++++++++------------------------ >> 2 files changed, 43 insertions(+), 55 deletions(-) >> >> _______________________________________________ >> kexec mailing list >> kexec@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/kexec >>