Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp781326imm; Wed, 26 Sep 2018 06:45:30 -0700 (PDT) X-Google-Smtp-Source: ACcGV63k83Ro3400IfVVhTnsxnkiRynvdWuBYkW6GeANREcTreKIipouzm5fBTn16KaAVNcHN9zS X-Received: by 2002:a62:7a81:: with SMTP id v123-v6mr2618331pfc.240.1537969530014; Wed, 26 Sep 2018 06:45:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537969529; cv=none; d=google.com; s=arc-20160816; b=XLdODfgNUYdZOF5lv6sg1O3n2wk5fkp32VDE0OcGgrLxWR45OMjY3cxFjS3GsfeVkC nsES3xmxzA0ndjUBIsGzERZmIvJgvYsC4UDMQd0oBJJfem053AHlb2I1rB1GQzYh+Vx0 Xu/GdHuttnyeRMIaJ33hOJMmgF/mB0Qni10Cy2dq7myKHzvS5D133YHjqtXeyFinFNUP tPCy54BpSVZOvWe5BPTIqOR7B5+cRAdEToi2037UBnNBCQrGOiDTQrtiNlZELfMa9OY/ GX3AEIue03IReApojYL7i4jCKBI07rIv9bGbdOuuXDUIC23VLRzdETYZTOVgv+dMKNTx Q0ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=FUFyylW5785xdhv3txHFOQZOMzbnIwKhwl8hiYKKIgA=; b=ITNgpxLuvuccN5VTwHpalFalKJzUWCPfgANfKJ88CWbgb8vrmTlLaxxtZaqu6DxYsy FbuUrCMB7vQ8ZCJDEbw76BJuPGG4yQfYm/o1vv/V5VrQ/qFSUOdWS6S7+6mgtPwKmHga R5MxigRatVxuLrMOaaXEoRUvxCfv44dOfQb3sxbgLBHoZ/Agw7QXM3eRwdasHQEAC/8x ohUwJZZx41eaG1bRS+XGb9HFoElvNUQzVI8hE9NwTujQNf0u+978YumNkS+JileFuTC6 OyStAQoYwGfH6Muh2B6hxvXHSQ3cWbsD2sZ2z+KuCn7cLOJNeIQup0mzarCjn+Gq44Ja DoKA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z16-v6si5254157pgi.252.2018.09.26.06.45.14; Wed, 26 Sep 2018 06:45:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727722AbeIZT57 (ORCPT + 99 others); Wed, 26 Sep 2018 15:57:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59158 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727159AbeIZT57 (ORCPT ); Wed, 26 Sep 2018 15:57:59 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 26BDE86665; Wed, 26 Sep 2018 13:44:57 +0000 (UTC) Received: from gondolin (ovpn-116-210.ams2.redhat.com [10.36.116.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1C369308BDAA; Wed, 26 Sep 2018 13:44:48 +0000 (UTC) Date: Wed, 26 Sep 2018 15:44:46 +0200 From: Cornelia Huck To: Tony Krowiak Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, freude@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, borntraeger@de.ibm.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, pmorel@linux.vnet.ibm.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, jjherne@linux.vnet.ibm.com, thuth@redhat.com, pasic@linux.vnet.ibm.com, berrange@redhat.com, fiuczy@linux.vnet.ibm.com, buendgen@de.ibm.com, frankja@linux.ibm.com, Tony Krowiak Subject: Re: [PATCH v11 24/26] KVM: s390: device attrs to enable/disable AP interpretation Message-ID: <20180926154446.2f6e666f.cohuck@redhat.com> In-Reply-To: <20180925231641.4954-25-akrowiak@linux.vnet.ibm.com> References: <20180925231641.4954-1-akrowiak@linux.vnet.ibm.com> <20180925231641.4954-25-akrowiak@linux.vnet.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 26 Sep 2018 13:44:57 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Sep 2018 19:16:39 -0400 Tony Krowiak wrote: > From: Tony Krowiak > > Introduces two new VM crypto device attributes (KVM_S390_VM_CRYPTO) > to enable or disable AP instruction interpretation from userspace > via the KVM_SET_DEVICE_ATTR ioctl: > > * The KVM_S390_VM_CRYPTO_ENABLE_APIE attribute enables hardware > interpretation of AP instructions executed on the guest. > > * The KVM_S390_VM_CRYPTO_DISABLE_APIE attribute disables hardware > interpretation of AP instructions executed on the guest. In this > case the instructions will be intercepted and pass through to > the guest. > > Signed-off-by: Tony Krowiak > --- > arch/s390/include/uapi/asm/kvm.h | 2 ++ > arch/s390/kvm/kvm-s390.c | 31 ++++++++++++++++++++++++++++--- > 2 files changed, 30 insertions(+), 3 deletions(-) Other than the nits that David had, this looks fine. Reviewed-by: Cornelia Huck