Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp869011imm;
        Wed, 26 Sep 2018 08:03:11 -0700 (PDT)
X-Google-Smtp-Source: ACcGV60adShU88Y78e4mzM3s+/mtYLS+H/3om1l3VazE+uyG2No94Mc79I63J5yvpvOsM1zrzExZ
X-Received: by 2002:a17:902:1681:: with SMTP id h1-v6mr6487997plh.262.1537974191492;
        Wed, 26 Sep 2018 08:03:11 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1537974191; cv=none;
        d=google.com; s=arc-20160816;
        b=GPVWceDj/lFUdJk38gzpcgrIzENKpEIZJ9XpjYYfMy5GIausTsFSNded00IyMIJdMy
         a8WhYyZsYjZZu9HwAWcDnSeGq98/4rntY4wAlPIqGD3LH22KJo/RyHjy/YwOWDtKPiTP
         7DmU/6jw59CWRB9xWMphiIXXYwM/86rKTFXhfEXcqGxErZ4z53uRsN6ZKUuDzKl6qBUu
         4MO1A7qiOmy5nY8pfW7hnl+7Z6j612Mk97TPpEaCNZlJqZzrLxaKnMLK6Khfbq2wA4ez
         nhGcu9GKg/5VDM6N7zvQLsUtzbFWbXzJCasoovKd3ADCyaHOJrYNfUjPy37WHGMwl0jj
         ZhIw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=tfLfkIcnLllntuKQmiaCofazzdc+aulNG4MmnVbrFz4=;
        b=yRsX8VSUaQBDicYO1XWqOrEGwORwShfYXmcqrxxI86wqX08Jxk/cOpY0rcRjFwdAke
         SdHhufhtlKGZw3MhtTvwQQ0CooMlO4POa2emsJNgibFdmVij0qNSkuJOp+GO2+fkfZdF
         vjiMdBshjh7+p/RL6+kha4rz9+Hni9KPvJc96KyhSO9x9BSS3vfWqq+Y8Y6Yn1coFOLl
         FeXWGBNIEjfYy+qAHDmCx/+1c6RVYTSkhkv9oDE/ohgXmC4/SMilrSUfe0luT24gN3Kz
         lhDqBCKZCmojrMq5AHxqkfzX1wMAADXhZVszJLe7WlJroSsxE5ZA+ZR2HdkETXEdqXQ1
         uXtg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=PY3SbNCH;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id o5-v6si5494142pgk.300.2018.09.26.08.02.55;
        Wed, 26 Sep 2018 08:03:11 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=PY3SbNCH;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728137AbeIZVPc (ORCPT <rfc822;xqjcool@gmail.com> + 99 others);
        Wed, 26 Sep 2018 17:15:32 -0400
Received: from hqemgate15.nvidia.com ([216.228.121.64]:18847 "EHLO
        hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727048AbeIZVPc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 26 Sep 2018 17:15:32 -0400
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5bab9f4f0001>; Wed, 26 Sep 2018 08:01:35 -0700
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Wed, 26 Sep 2018 08:02:11 -0700
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Wed, 26 Sep 2018 08:02:11 -0700
Received: from [10.21.132.143] (10.124.1.5) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 26 Sep
 2018 15:02:08 +0000
Subject: Re: [PATCH 1/5] PM / Domains: Export symbol for
 genpd_dev_pm_attach_by_name
To:     Ulf Hansson <ulf.hansson@linaro.org>
CC:     Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        "Rafael J . Wysocki" <rjw@rjwysocki.net>,
        Kevin Hilman <khilman@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        DTML <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>
References: <1537964858-30332-1-git-send-email-jonathanh@nvidia.com>
 <1537964858-30332-2-git-send-email-jonathanh@nvidia.com>
 <CAPDyKFrtw1aYg5QbgRi_jp-xd0VLNeRYhb4HvX4P3AfGjgO0VA@mail.gmail.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <afd04dd4-4199-9bb8-1b21-11444bb1773a@nvidia.com>
Date:   Wed, 26 Sep 2018 16:02:07 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <CAPDyKFrtw1aYg5QbgRi_jp-xd0VLNeRYhb4HvX4P3AfGjgO0VA@mail.gmail.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL108.nvidia.com (172.18.146.13) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1537974095; bh=tfLfkIcnLllntuKQmiaCofazzdc+aulNG4MmnVbrFz4=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=PY3SbNCHcrDO4jOmTrZHthLFfjrwXh2n7Yq0K8RIBT3uOYCWtuuceo1qG4SJ2yEy+
         U7hv1yMHU4t2LStEQBow3O9tzLKBcXgreZ1ECqKROOkmJRWERWM8s4sA3V0MeHJm+k
         jo3FUHcHjvJGBPrrN8lOWJtNsjKsphAXmrvPcW+7hyZeW9uKOVhuOHD5W4MZm0p0wm
         OM6s81hXK/C8Ls5kSCxRiShXLwRRxvmHfWUZhuHW5+MR8t+np/m1jd3HMmGN3OVtmY
         zqfAtLAdqsaU+yTK2o7XBJ1ailjYAyF+HUESRdTqamwT9uDObTCIW3sSZglZxwrxlk
         gE9yY6x+LH3jg==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 26/09/18 15:09, Ulf Hansson wrote:
> On 26 September 2018 at 14:27, Jon Hunter <jonathanh@nvidia.com> wrote:
>> Export the symbol for genpd_dev_pm_attach_by_name() so that drivers
>> built as modules can call this function.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>>  drivers/base/power/domain.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
>> index 4b5714199490..b2bbe0d848d2 100644
>> --- a/drivers/base/power/domain.c
>> +++ b/drivers/base/power/domain.c
>> @@ -2397,6 +2397,7 @@ struct device *genpd_dev_pm_attach_by_name(struct device *dev, char *name)
>>
>>         return genpd_dev_pm_attach_by_id(dev, index);
>>  }
>> +EXPORT_SYMBOL_GPL(genpd_dev_pm_attach_by_name);
> 
> Driver's shouldn't be calling this function, but instead use
> dev_pm_domain_attach_by_name().
> 
> Is there any problem with that?

No not at all. Yes that works, sorry it had been a while since I looked
at this and managed to balls it up. OK, I will drop this and correct the
API used by the driver.

Cheers!
Jon

-- 
nvpublic