Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1052613imm; Wed, 26 Sep 2018 10:49:28 -0700 (PDT) X-Google-Smtp-Source: ACcGV60VoowZosAyJzYlU659gMBYCzY1esbP9wZ2wIIyo+1siCg/DwSOrVMxq1GOFj6jJssIIVa1 X-Received: by 2002:a17:902:aa05:: with SMTP id be5-v6mr6971178plb.313.1537984168780; Wed, 26 Sep 2018 10:49:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537984168; cv=none; d=google.com; s=arc-20160816; b=wD6bmL1MsmgPTOLaP/+nQg8yy9SrKnrgqOcRDecxNixRzYfmReHuRnMumK2xShWrPN jzVlOoM2uKJQyoedrXUqAhlz4mbGkWcF9vJgS8VMo4FWOyYDITuJ273MQRlqA7FjZ1nx ullnJ+RS2Wwxkhgh/3zNHioKEkmGHC1yAffE6pYDYf28ndTa5z5Owqr1jNs2PGrkjc4R NFSwp3WEgkAyqHOD2SVcsdz9QIvmKb3tQhYDb0DBkiuLNVvFUZPU0zZM8h5T4Fr8b0+L Yh/tqDOC49nA63OHAXqvD5SKmsS+0wJB16nRq/sNsdF+wfYAc4tN4UUYYywJ+VNDsZX2 VW5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=60bpes0MGi/bqgWqMHIi0b4px+0rIt2wSm6eMIg9nx8=; b=lrN3bJsmFiiDxwSoVTerAmJOf4J+OUl/Dj6P0zJhhnenU6mknxJmwx2ukg7q/Y8w/A HoQp9xMKQDSoDEMAWNfbvbU/PHvM/K5NfylPDRzmJFBfXYy1sDYxh3FueCLZbCwwoaco 6QRP0Xj3tDOILBdKoIInI5iP095tq9EAdZPUF6ei8cZY/S40+c/i04hG0Fl5DveJFvpU 6LAb32nckdXGdYbF6MVtBr5t2TA8codD3rnKudc0ruulXVM4Qdo4NYBY6skqdl0oP3jB hn4B+8ssVsL8L3HZ7/qIGQEl1eSVx4tG8r+U2WfWKRG1vDVR9Fi1tGoNw4dCNUlB/4RJ O7Ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QkTEenG9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t138-v6si5460526pgb.640.2018.09.26.10.49.13; Wed, 26 Sep 2018 10:49:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QkTEenG9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728361AbeI0ADK (ORCPT + 99 others); Wed, 26 Sep 2018 20:03:10 -0400 Received: from mail-qt1-f175.google.com ([209.85.160.175]:45369 "EHLO mail-qt1-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727280AbeI0ADJ (ORCPT ); Wed, 26 Sep 2018 20:03:09 -0400 Received: by mail-qt1-f175.google.com with SMTP id l2-v6so18187425qtr.12; Wed, 26 Sep 2018 10:49:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=60bpes0MGi/bqgWqMHIi0b4px+0rIt2wSm6eMIg9nx8=; b=QkTEenG9KiIGMXVRe8IEiHJuH5fuUizhMMkpZSRsiVTKbSogstv5uIfwmXoRwqQmQB KFINm4C2+4f4C8d5Dzmu+FbenAkOyNeM9xfWyToOnZA/vsLR+eBeLDVcox8lLUKFrALf FyvSLnCcYbWkY7SsYPh0sbw4K0mnKjM1yO6k7+oowLk/s6FJ53xqLByc97N02DczLHs3 cXAQjqqP+5FlR42YvGW+5OxTklw8Opc+4nhHY8SeeYCvX0aMXrnE6S5Hda8d1Wdc6s9M 1XMUBa8ByVw33yJTMpXgDMWRKGy+WY99YWLeAvteH9xG8YqUJ7eqZjtC/0nyqSmDQ6bJ t6Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=60bpes0MGi/bqgWqMHIi0b4px+0rIt2wSm6eMIg9nx8=; b=UBkAJZq+Pf7u/9cZlA1NzJuqadsmg/MSRb2grZXzkkCFprEbHFVIk+GkXOuSeED/ZX gZejrfJWUnpajV/Gk1RmfusBxQ9y+A4uIXO+OCD+sQa5mCSLxPdJCtB9D1GT4Gj4dvOo Cu+mxCKGFFw0GoY84MK5d4HbxViaJfi/7A0vuZdKqyorLSW1mG9kAXkN19xUjG2c9DX5 iWDqtoCC9c1sb8uYNrIP341Vea1yrSy9baXq7p0igTT76+9xOKTN0Td/MenoCHgMmhxk VDRGnbv8ttlu57HA0fNILPyO8/yAiavetwjW3R9BG/kVukXR23nQH11Is9pnz1qbfmZe WfqQ== X-Gm-Message-State: ABuFfogq78NICdnT67EiavpfqIVtwXrUuhuyVctm+8OwbAs4A7ShsrNu eWBmFTIk9O0go/DPyJ0baXMR63z2ZmOc1P9SZQc= X-Received: by 2002:a0c:93c1:: with SMTP id g1-v6mr5251005qvg.136.1537984145819; Wed, 26 Sep 2018 10:49:05 -0700 (PDT) MIME-Version: 1.0 References: <20180816084104.434-1-jian-hong@endlessm.com> In-Reply-To: From: Andy Shevchenko Date: Wed, 26 Sep 2018 20:48:54 +0300 Message-ID: Subject: Re: [RFC PATCH] platform/x86: asus-wmi: Simplify the keyboard brightness updating process To: Jian-Hong Pan Cc: Corentin Chary , Darren Hart , Andy Shevchenko , acpi4asus-user , Platform Driver , Linux Kernel Mailing List , Linux Upstreaming Team Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 10, 2018 at 11:57 AM Jian-Hong Pan wrote: > > 2018-08-16 16:41 GMT+08:00 Jian-Hong Pan : > > The original asus-wmi queues a work which calls the ACPI/WMI methods to > > update the keyboard LED brightness. Similar drivers - acer-wmi, > > dell-wmi-led just call the ACPI/WMI methods directly without workqueues. > > > > This patch simplifies the keyboard brightness updating process which > > calls the kbd_led_update function directly without workqueue in > > asus-wmi. > Just gentle ping. Any comment for this patch? RFC patches are not supposed to be applied. So, feel free to resend as non-RFC, or wait a bit more if anyone would comment on it. -- With Best Regards, Andy Shevchenko