Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1135668imm; Wed, 26 Sep 2018 12:17:08 -0700 (PDT) X-Google-Smtp-Source: ACcGV60/fpw1EnEPh0Yiu9P1oapOHrz6P03JPrrcy4/NVELjAA1gVXBp9NnCCf5jx514nHTjMZlv X-Received: by 2002:a17:902:274a:: with SMTP id j10-v6mr7557785plg.152.1537989428164; Wed, 26 Sep 2018 12:17:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537989428; cv=none; d=google.com; s=arc-20160816; b=vBq07YdK4FAlKMKn0+uF4Yk8O3nltLvTDpLLu0r1pnZwM0OXhn33icrPtl4Me7y3KQ xy43pQD2Q7C+kVwsPT5YKWM+/Fzemfv7O1yzalyFKZtffEnqcc6Le9QOhgwTGVqFumA3 lPfJMYVPJI4Vm3Ft0TouW5ibM8BsmNyvq+LMWqmLA2Ef1johbieWvTlse9/m3Dx4DgaP yoj+j25HyNAv3V482cGRhCHKvnzcQBvT061HXkyeOsqTm7nqwySLxUqFpzPxzgalUf8I uy3laBYEjZJCO8jhGIYfjVynRyGkftAIi8HaSxiym/9ptQGA6jqChsExuEAgSAmgbVKl hvIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=5MAC1GT8VaitCSn6Wfa7q8fqA5WawyRV8USuRjNHlWw=; b=zpVld6hJQk5K7r43mWqwE1gD2IWMGuEQOdzb9+cxG8Ym8E4lsaot1pgzlIXrykiIlL 427M6XFxR+WJqca38OVSJ/jkxLex1YESGVAZAMjltm0YM5z90ZC/OOVCgcigianyHuEs VP3jW85fvjzij9o7Sjk5GpAWo4qr6u/uOoVnwokRSs5WepxLw7qemQNJZqDy35zn6vjU 8I2m8k7l38whvpxHPCEgOpXpTp1qkFCIUFYENdMPdakUGT60xuVvEL+w8t+Hk2eUBNDm XqQqexAH/K1jqduj9mecNht40QXIX7lkAEfDIc0a9BcOm18J3VXqLunP/h8XEojFnDw4 oghQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vmware.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y7-v6si541567plt.112.2018.09.26.12.16.53; Wed, 26 Sep 2018 12:17:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vmware.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727111AbeI0Bah (ORCPT + 99 others); Wed, 26 Sep 2018 21:30:37 -0400 Received: from ex13-edg-ou-001.vmware.com ([208.91.0.189]:2656 "EHLO EX13-EDG-OU-001.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726959AbeI0B3o (ORCPT ); Wed, 26 Sep 2018 21:29:44 -0400 Received: from sc9-mailhost2.vmware.com (10.113.161.72) by EX13-EDG-OU-001.vmware.com (10.113.208.155) with Microsoft SMTP Server id 15.0.1156.6; Wed, 26 Sep 2018 12:15:01 -0700 Received: from sc2-haas01-esx0118.eng.vmware.com (sc2-haas01-esx0118.eng.vmware.com [10.172.44.118]) by sc9-mailhost2.vmware.com (Postfix) with ESMTP id DE8FFB0E87; Wed, 26 Sep 2018 15:15:09 -0400 (EDT) From: Nadav Amit To: Arnd Bergmann , CC: Xavier Deguillard , , Nadav Amit Subject: [PATCH v3 14/20] vmw_balloon: add reset stat Date: Wed, 26 Sep 2018 12:13:30 -0700 Message-ID: <20180926191336.101885-15-namit@vmware.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180926191336.101885-1-namit@vmware.com> References: <20180926191336.101885-1-namit@vmware.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: None (EX13-EDG-OU-001.vmware.com: namit@vmware.com does not designate permitted sender hosts) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is useful to expose how many times the balloon resets. If it happens more than very rarely - this is an indication for a problem. Reviewed-by: Xavier Deguillard Signed-off-by: Nadav Amit --- drivers/misc/vmw_balloon.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c index 99a831ea82c0..9b0b3fa4f836 100644 --- a/drivers/misc/vmw_balloon.c +++ b/drivers/misc/vmw_balloon.c @@ -218,7 +218,8 @@ enum vmballoon_stat_page { enum vmballoon_stat_general { VMW_BALLOON_STAT_TIMER, VMW_BALLOON_STAT_DOORBELL, - VMW_BALLOON_STAT_LAST = VMW_BALLOON_STAT_DOORBELL + VMW_BALLOON_STAT_RESET, + VMW_BALLOON_STAT_LAST = VMW_BALLOON_STAT_RESET }; #define VMW_BALLOON_STAT_NUM (VMW_BALLOON_STAT_LAST + 1) @@ -1303,6 +1304,7 @@ static void vmballoon_reset(struct vmballoon *b) vmballoon_deinit_batching(b); } + vmballoon_stats_gen_inc(b, VMW_BALLOON_STAT_RESET); b->reset_required = false; error = vmballoon_vmci_init(b); @@ -1380,7 +1382,8 @@ static const char * const vmballoon_stat_page_names[] = { static const char * const vmballoon_stat_names[] = { [VMW_BALLOON_STAT_TIMER] = "timer", - [VMW_BALLOON_STAT_DOORBELL] = "doorbell" + [VMW_BALLOON_STAT_DOORBELL] = "doorbell", + [VMW_BALLOON_STAT_RESET] = "reset", }; static int vmballoon_enable_stats(struct vmballoon *b) -- 2.17.1