Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1157155imm; Wed, 26 Sep 2018 12:39:55 -0700 (PDT) X-Google-Smtp-Source: ACcGV62XoPycIWtRf+1prCn2/oRWTjH9Dx3IQwDcoT6faE0fswkQu6VJ76khUxTz6LwdMgvEP4lU X-Received: by 2002:a17:902:e28a:: with SMTP id cf10-v6mr4141469plb.4.1537990795587; Wed, 26 Sep 2018 12:39:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537990795; cv=none; d=google.com; s=arc-20160816; b=Qzo8GEJmOVz1JXohRJbeSJKoA/KqBCCpD76EI5AIJWCnubLwcU0QQGR2o2AyBdFJGt 9z2yrigcDGwe30ZC9rcHQejLix6HMG1nIOKVQEqV4YV4Q1DeZ/b2yrPkbkNFkzlRIj8f R0amCdysYpsLc1umgIjRrz2CL7qusxh0Ruls5WwcND7jf1TKK/komGA3rtjCDdHJINyr yCJakbHKv03+P+kTovvfzoxb3BrRi1znq8/DS0cGGQpFJNeMA3BUKt0Rx//x5GpbSB7l pI8xfYISXSk2uyoDViDtxzGl7XR8qCMkTAj0LwIwv9OCAqtxzJ71xzqVhI+pJW1HCHfc 5F5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=UV/5aKuv8Sx2zAwhRX1tJeKZSLIOPzPpkTVAjbd1XBc=; b=wuK4PggVcIwCD6NcQEO1+UREkLy/J9210vn7JjmNk7PaKwJpeaCKUd0zS38mzYOB7t nB9FQY2DBMj8BLhD2vWHHUaBxZL4dM6Yic2PrOA9SkDP0lOvaxui9Hvw3abnI7IdeoBi 6Goa2o/ZC3dEh7Pe+Z0GwGuc8PkAL4yi93fEvuWeGI/87PTzXWtQWF+fby8YfpIZAdt6 rl/8EaUOvBb4lPKPYylOK3NLLvd4KswOz9p4vGmgWiXgkda1ikQZyyZJimz5A3if+OUB +lzbwQtb+4AqggwJSzGgl5nw7U4gpmstED8Kg3HzqVwyJBfc40YL9v9i2mdnBPuzsRs7 zYpg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l1-v6si6074220plg.285.2018.09.26.12.39.39; Wed, 26 Sep 2018 12:39:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726961AbeI0Bxe (ORCPT + 99 others); Wed, 26 Sep 2018 21:53:34 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:43735 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726032AbeI0Bxe (ORCPT ); Wed, 26 Sep 2018 21:53:34 -0400 Received: from wuerfel.lan ([109.193.40.16]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.145]) with ESMTPA (Nemesis) id 1MFshF-1fyvRK0r9z-00HNTr; Wed, 26 Sep 2018 21:38:21 +0200 From: Arnd Bergmann To: Sean Wang , Linus Walleij , Matthias Brugger Cc: Arnd Bergmann , linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] pinctrl: mediatek: mark dummy helpers as 'static inline' Date: Wed, 26 Sep 2018 21:38:09 +0200 Message-Id: <20180926193818.2481220-1-arnd@arndb.de> X-Mailer: git-send-email 2.18.0 X-Provags-ID: V03:K1:U4TWxtICXljj/5j09tCKrv67Z85xP2cxpkeXlSTGbXjqP+u0d6H fcKJlK8i2GgNBaNfDoKQBEfypHR6YfYAdicoobLlFxO7rJDvex+E8KNqgykzskywRnt71HJ l01N/s/DiJPbXj0xTUhSZLtRDVAKTmC3UAmB7jB6O0zhPHH8Q9jtqDGBpVv1Xwy+4vqfHDT ZsRhx5sEZLuzGY6YSJLcA== X-UI-Out-Filterresults: notjunk:1;V01:K0:cwENl99UqBw=:yFNVMb058SugpmC5fH4kv9 tZaTD8m93KP9FfaaAJ98TFP7f8ExZXdWxxr+CYmOtDyJGin9U+E8RYShA0DZljB8qKB+7w2ID NsKqStQYNFXbF9RP/ez5/uDIPzIyfhpQwTGOzk7rcZNAHMyS+lqsqwpeGtwkdQkM0k3vbVua+ MBZarDGcT30qB0KqDASIlSohHWI5hpIy0TIUw3G3gXsO49nsVAFcfMWaBtCRu+jb50w7PlUPf OIolECIWbsaENcQ2mioJ7pKpH8XY17ck0BcipXFPNaBCfiTH6VBh8uHtHOI4extawgo4RuxfL ixHs7ISoIawJdgEvAf4macFjli3pd42e9DeaOBGHkPUFClXoEY1njetHL07Q26xuJaad3UTS3 8UYChwH30yYj72Lx/F0KnW/kGuOx7yrmR4Tse+IekFNjsQkkZ9m7V1+K+8Pr8yNI4bmWSc8gV WaqOdsNdgCt5Yi+9F41JsBvhcxysjs9j4rxIGamFb7vSC0HJNx8FL7/I0SygZsK8VS/RYmgOs O301Gr6RkiHEptS9iolmpmO8n38xBNRJBIUlPKMo4WJ2C0SKIyfQNMTcyCqyRXV2ipkMNdh40 i9UI+nC4/3XsqR3LtdPuNDteBrST0RVoG+H+odW16xflu1jvzyaf/qSOIMzIp8Z+zr/jhfKlp fzf2dLAxuIOOM9J1kYuycHyDTFgVecMaohDPEdZACjy31oUIvbNYygHEIOFUQ4HfSoS4= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org mtk_eint_set_debounce and mtk_eint_find_irq are defined as stub functions in a header file, but without marking them as 'static inline', we get a copy for each file that includes the header: drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.o: In function `mtk_eint_set_debounce': pinctrl-mtk-common-v2.c:(.text+0x134): multiple definition of `mtk_eint_set_debounce' drivers/pinctrl/mediatek/pinctrl-moore.o:pinctrl-moore.c:(.text+0x7d0): first defined here drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.o: In function `mtk_eint_find_irq': pinctrl-mtk-common-v2.c:(.text+0x13c): multiple definition of `mtk_eint_find_irq' Fixes: e46df235b4e6 ("pinctrl: mediatek: refactor EINT related code for all MediaTek pinctrl can fit") Signed-off-by: Arnd Bergmann --- drivers/pinctrl/mediatek/mtk-eint.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/mediatek/mtk-eint.h b/drivers/pinctrl/mediatek/mtk-eint.h index c286a9b940f2..48468d0fae68 100644 --- a/drivers/pinctrl/mediatek/mtk-eint.h +++ b/drivers/pinctrl/mediatek/mtk-eint.h @@ -92,13 +92,13 @@ static inline int mtk_eint_do_resume(struct mtk_eint *eint) return -EOPNOTSUPP; } -int mtk_eint_set_debounce(struct mtk_eint *eint, unsigned long eint_n, +static inline int mtk_eint_set_debounce(struct mtk_eint *eint, unsigned long eint_n, unsigned int debounce) { return -EOPNOTSUPP; } -int mtk_eint_find_irq(struct mtk_eint *eint, unsigned long eint_n) +static inline int mtk_eint_find_irq(struct mtk_eint *eint, unsigned long eint_n) { return -EOPNOTSUPP; } -- 2.18.0