Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1261479imm; Wed, 26 Sep 2018 14:39:27 -0700 (PDT) X-Google-Smtp-Source: ACcGV608a6jbEmUpdvydvYQzs1ICA12hPC3c6Hh8qVoeVZdUW3V2Rzhxyb3H9P9zezP9e4PRtgSm X-Received: by 2002:a63:cc4f:: with SMTP id q15-v6mr7228873pgi.217.1537997967279; Wed, 26 Sep 2018 14:39:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537997967; cv=none; d=google.com; s=arc-20160816; b=CRinzR9BueY4eh6q2+Lj/rm5/uyML2uQUN9sIo9Mc10LqcXmWCVfJVLJdoWoAuXXep AtuRGT4z1lrtYq2JoIaiz/cyy2Vtyp/r58tKynV/tvUVwJ4LQYOvwgMcgMxGyFGzs9aT GFGfF7XGHw1sAJTOtrx6yCJZHDgeUAPkRuoHXdWJN1UK3sWGHYKfZa6IUxdarOYykmtl wJe74m+VGU4zGwqGfr2W9zlHmedxN0Rltq9rGR5OevHV2DVu+GrVdF/NWULkXOh8u4hb jPInwjaPcX3/Nu/Lnt+4MUvCzMW3IFr7X6CnKxGNbJeC+dXJU9iKvP8rSELrpr2cRrGH ekdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=0Q834EOsgyWoF66NlJ6NsXgllJnfVs//f5vyVQJmq6o=; b=qfA+JzwL/z31kQWd4+hiXZcqN0Mqzcre2R+oXA4JoOOQsZPa2ZXRwvrRZB54TVdm9r uVi1gRSkdBqLecIQjI3qMhguWDJhVTZqXTSiktTYh1tt9SSC7JPaE7RVggtTM6yvBGKt JQpYPuuOZC9ni6FJ4J3H9SeTKtbF4Jf8GWWfALqmsbgwsfqD4FZoHIMjUGDXbZLW7BEP KK4SyGB1pEw1T5Hkm4+0ClU3N2og8z1O2sfqTiQSW69Ko/tLYz0Ywmdw7tx6Oroz+LSZ HWWlzwpSXLlI3AR1Ccb8/DvxYTy+vXwFE1HcJtT2e0D1j+QliFa29Ns7aiyXT9ZJBjn5 Q01A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gn7si114599plb.264.2018.09.26.14.39.11; Wed, 26 Sep 2018 14:39:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727151AbeI0Dwi (ORCPT + 99 others); Wed, 26 Sep 2018 23:52:38 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:37160 "EHLO mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727018AbeI0Dwh (ORCPT ); Wed, 26 Sep 2018 23:52:37 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id D0BB241DFF; Wed, 26 Sep 2018 21:37:40 +0000 (UTC) Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo03-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lfUa6BhgH7eI; Wed, 26 Sep 2018 21:37:40 +0000 (UTC) Received: from [192.168.1.87] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id BC90141DF5; Wed, 26 Sep 2018 21:37:34 +0000 (UTC) Subject: Re: [V3 PATCH 0/2] selftests: watchdog: Add get/set/pre timeout To: Jerry Hoemann , erosca@de.adit-jv.com Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <1537996989-13092-1-git-send-email-jerry.hoemann@hpe.com> From: Shuah Khan Message-ID: <6f3a8fe3-1ec4-ed8b-99a2-1dba7553c1fc@kernel.org> Date: Wed, 26 Sep 2018 15:37:34 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1537996989-13092-1-git-send-email-jerry.hoemann@hpe.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/26/2018 03:23 PM, Jerry Hoemann wrote: > Add command line arguments to call ioctl WDIOC_GETTIMEOUT, > WDIOC_GETPRETIMEOUT and WDIOC_SETPRETIMEOUT. > > Changes v2 > 1) Update usage to include argument > 2) Update usage to give example. > 3) Made printf of WDIOC_GETTIMEOUT distinct from WDIOC_SETTIMEOUT > 4) Made WDIOC_GETTIMEOUT a "one shot" > 5) Made printf of WDIOC_GETPRETIMEOUT disnct from WDIOC_SETPRETIMEOUT > 6) Made WDIOC_GETPRETIMEOUT a "one shot" > > Change v3 > 1) Printf says errno, but prints the string version of the error. > Make the printf consistent. > 2) As above error was cut/paste from prior printf in application > add new patch 1 to fix the existing printf first. > > Jerry Hoemann (2): > selftests: watchdog: Fix error message. > selftests: watchdog: Add gettimeout and get|set pretimeout > > tools/testing/selftests/watchdog/watchdog-test.c | 41 +++++++++++++++++++++--- > 1 file changed, 36 insertions(+), 5 deletions(-) > Thanks for the patches. Applied to linux-kselftest next for 4.20-rc1 btw -for future reference, the convention is [PATCH v3] not [V3 PATCH] thanks, -- Shuah