Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1414224imm; Wed, 26 Sep 2018 18:00:09 -0700 (PDT) X-Google-Smtp-Source: ACcGV63hgFm7d4dVBss8EPDwZCmJrUy1WIn1Ysogd8HM5x46E/SwSQFqdnVHa8Ve0QEXK8gzap41 X-Received: by 2002:a63:c20:: with SMTP id b32-v6mr7831553pgl.400.1538010009641; Wed, 26 Sep 2018 18:00:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538010009; cv=none; d=google.com; s=arc-20160816; b=CHd07G+6kpUzjDzc1uoWmjzMlCKY3AEwT+bNtdEYFwG5/qW5utjqm6EediZunyqkXS ZtpbIZ49E6upcLHR+WcpIJP5vPNHfi3WmLWqy047mgg8zGWAlRajI1oTJcM1Og9FdGoY n7eBTKRzECmbCxdIrzF1ZkjeBt5nzCCdmbGTXilXr/y9Qi4bgE/NwtmhVpj7ZtgI8pLN C9qSP30eyp/efZNTrcboOgoARgvTwb8h8aAaG4sT/5qMarMAmSS3rrP/2mMTZrVhZ/3m 0osANNyTYLDmwD+6SRJ/0roazrGGAP3lOKzyk5R1XslByJ1j/CEHh4Yk60XjpbvOoYUu HQCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=aweOWYZV76DuUJLR0/UZjUMtBqrXO/KCV4LnY+WcQH4=; b=ukzaKcKPdVDF1XUBX6dUjkxChZW1bwVZ0xeXzw98Bqb028N2SN6rjInWJr2VJ45RsM mTubggb5ATP1ZonGUYdwFtjTK8OGbWQzGpk/gLQ54nGXPTz/dG2oYJBUzsNGMb+N+WnF CyiB6CtQFAmSuNBKQkUHCZp2uvX4L8z4Qf6BDxMtFQvXLYmP+9flGjbKkhrh5S+Jy55W ZhlnMn1S0nsrSqYDfOAlpI25L547oIz8bxHFw9Tflu1gj7Lt2rqWFQ9Gis2ktIymVcvV fGlcOm/4UG/Lyk86ot/ttbEZs2OWN3fftiQySToFVK7as6EiCDW36YgV5cr7cnt9DwHK p3Zw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q1-v6si528484pgs.110.2018.09.26.17.59.54; Wed, 26 Sep 2018 18:00:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727049AbeI0HPU (ORCPT + 99 others); Thu, 27 Sep 2018 03:15:20 -0400 Received: from out20-15.mail.aliyun.com ([115.124.20.15]:49724 "EHLO out20-15.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726378AbeI0HPU (ORCPT ); Thu, 27 Sep 2018 03:15:20 -0400 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.0777384|-1;CH=green;FP=0|0|0|0|0|-1|-1|-1;HT=e02c03290;MF=yong.deng@magewell.com;NM=1;PH=DS;RN=23;RT=23;SR=0;TI=SMTPD_---.CwIwi7p_1538009962; Received: from John(mailfrom:yong.deng@magewell.com fp:SMTPD_---.CwIwi7p_1538009962) by smtp.aliyun-inc.com(10.147.41.187); Thu, 27 Sep 2018 08:59:23 +0800 Date: Thu, 27 Sep 2018 08:59:23 +0800 From: Yong To: Laurent Pinchart Cc: maxime.ripard@bootlin.com, Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Chen-Yu Tsai , "David S. Miller" , Greg Kroah-Hartman , Andrew Morton , Arnd Bergmann , Hans Verkuil , Geert Uytterhoeven , Jacob Chen , Neil Armstrong , Thierry Reding , Philipp Zabel , Todor Tomov , Sakari Ailus , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v11 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI) Message-Id: <20180927085923.cf24d7e2fba7f38637aff7c4@magewell.com> In-Reply-To: <1568838.d8CnAYTeDB@avalon> References: <1537951204-24672-1-git-send-email-yong.deng@magewell.com> <7197338.mhOH8fQaEM@avalon> <20180926103547.5ubb6xjkl7xngmfg@flea> <1568838.d8CnAYTeDB@avalon> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, 26 Sep 2018 13:38:08 +0300 Laurent Pinchart wrote: > Hi Maxime, > > On Wednesday, 26 September 2018 13:35:47 EEST maxime.ripard@bootlin.com wrote: > > On Wed, Sep 26, 2018 at 01:19:34PM +0300, Laurent Pinchart wrote: > > > > +Endpoint node properties for CSI1 > > > > +--------------------------------- > > > > > > Should you list the CSI0 properties as well ? As the driver in patch 2/2 > > > doesn't support the CSI-2 interface I assume you have left out CSI0 for > > > now, but it should still be listed in the bindings. I'm fine with fixing > > > this as a follow-up patch to avoid missing the v4.20 merge window, but if > > > you end up resubmitting the series, could you please address the problem > > > ? > > > > That driver is not available, and the documentation isn't either, so > > there's no easy way to tell which properties are going to be needed > > before doing the actual work of reverse engineering it and writing a > > driver for it. Unfortunately... > > While DT bindings should be independent from driver implementations, I agree > it's difficult to develop good bindings without hardware documentation and > without at least one working driver implementation. > > How about just explicitly stating that these bindings don't support CSI0 yet ? OK. Thanks, Yong