Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1611652imm; Wed, 26 Sep 2018 22:56:47 -0700 (PDT) X-Google-Smtp-Source: ACcGV63cvjmOSjc+0a3Un8CI3caY9yGB7ClwRMjJ5WxWBlw7t5ruLqKuhZJ/5qbZtbZ+xojPrnbL X-Received: by 2002:a63:db04:: with SMTP id e4-v6mr7264183pgg.280.1538027807479; Wed, 26 Sep 2018 22:56:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538027807; cv=none; d=google.com; s=arc-20160816; b=FSiE9Y/J+V0jJCMQSiTvgRmndV/CcXHxWizb0LF/VQdzx80lPDKsZjkchzYhO+hOOJ VNylrGFVpaopY/w0X2z0xzA2sFX8m31qzrM/AlxfRClkvamzd71q7assJp9SVE0XasJD Y4uAxsBk384MWmlkUJzzEP1grLNUbwuMOzo5yqMf6Zw5ttx5Vxv9eomX+WQCPsJRtT5x OJCMINMEGhs94w9TK3P2qa9lBqm0VioeVj4XQCptbxqhM6dUOxwacOXIGU4rlprpba3D TQubOwRFxkjKBqxs8ifSvM0SXjUUEwBVhruuqguX0I/muZLz2pweoWp2FqspqsJXuDT2 FW8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=terauvxhwkIZUrUbZXa5jgYcOOxw13cO3ouZqvKit/s=; b=NAypQIzVmTacAZzyz8uzQIMOA5xvaunaGXGpdQ6K3zC/hiz5vkbVsfUREKMeLY6XEI zoCkKnJq4DRRPkbyaYFEt1OAqPTJ4KzhmHj2IH+J2qSeENUXohrLxJegC2YqVCU0zvEc vwScfdEPolZYQitCmM6zBNTpfV5Jss1W4GmQApippfOf4YpQ3VBKpj8rrKxFkhPzrkGz e4ImslfbLO8WuuAAaEKhfvl+3SU4qf0shJKivCSsiWHH8Vn7tNeQ+GEi0ip6uRuXyoTA gmockOX5IyjJz56kp4XyA5whvOJRefZGUQVxJVcX2QfM4I+8AXuSXXGNxH3hzTCBa9DK COGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e62-v6si1286739pfe.31.2018.09.26.22.56.31; Wed, 26 Sep 2018 22:56:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727108AbeI0MM4 (ORCPT + 99 others); Thu, 27 Sep 2018 08:12:56 -0400 Received: from mail.skyhub.de ([5.9.137.197]:59820 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726659AbeI0MM4 (ORCPT ); Thu, 27 Sep 2018 08:12:56 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Ts7m6w-tl98F; Thu, 27 Sep 2018 07:56:23 +0200 (CEST) Received: from zn.tnic (p200300EC2BC7FB00329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2bc7:fb00:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id EE22E1EC02C1; Thu, 27 Sep 2018 07:56:22 +0200 (CEST) Date: Thu, 27 Sep 2018 07:56:25 +0200 From: Borislav Petkov To: Justin Ernst Cc: russ.anderson@hpe.com, Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Raise maximum number of memory controllers Message-ID: <20180927055625.GB30912@zn.tnic> References: <20180925143449.284634-1-justin.ernst@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180925143449.284634-1-justin.ernst@hpe.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 25, 2018 at 09:34:49AM -0500, Justin Ernst wrote: > We observe an oops in the skx_edac module during boot. > Examining /var/log/messages: > [ 3401.985757] EDAC MC0: Giving out device to module skx_edac controller Skylake Socket#0 IMC#0 > [ 3401.985887] EDAC MC1: Giving out device to module skx_edac controller Skylake Socket#0 IMC#1 > [ 3401.986014] EDAC MC2: Giving out device to module skx_edac controller Skylake Socket#1 IMC#0 > ... > [ 3401.987318] EDAC MC13: Giving out device to module skx_edac controller Skylake Socket#0 IMC#1 > [ 3401.987435] EDAC MC14: Giving out device to module skx_edac controller Skylake Socket#1 IMC#0 > [ 3401.987556] EDAC MC15: Giving out device to module skx_edac controller Skylake Socket#1 IMC#1 > [ 3401.987579] Too many memory controllers: 16 > [ 3402.042614] EDAC MC: Removed device 0 for skx_edac Skylake Socket#0 IMC#0 > > We observe there are two memory controllers per socket, with a limit of 16. > Raise the maximum number of memory controllers from 16 to 2 * MAX_NUMNODES (1024). > > Cc: Borislav Petkov > Cc: Mauro Carvalho Chehab > Cc: linux-edac@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Acked-by: Russ Anderson > Signed-off-by: Justin Ernst > --- > include/linux/edac.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied, thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.