Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1655461imm; Wed, 26 Sep 2018 23:51:55 -0700 (PDT) X-Google-Smtp-Source: ACcGV62O32zkZThUYMOzhrUA51b8jxo2l9yG8CG572ODhtm3hVqGOMV/krYhXGsB0DtcFN04C/jy X-Received: by 2002:a17:902:a50e:: with SMTP id s14-v6mr2200724plq.78.1538031115185; Wed, 26 Sep 2018 23:51:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538031115; cv=none; d=google.com; s=arc-20160816; b=tFiipfo669wZH0LvDdcjB8UNJUCLAbtLrKCMiWLUbZ8NGTdpk4FMaBZ/pWg4e+J6sZ 4P094lDGDH2NIiQBRbshtSlsKMUSx0kuG8CGxwbFL+NG8do8jyyOTSlCBF/r3vaREiaQ RIw69EpJAxgv2/BhZbO7srOfyg1OQ5y8NhbreX3DivyG+72B5bXy7ulN7LgEeSJREbss tPa4rVry9OKShoBMauZRfn2UEqses+VLh4W/sM6uvhY5shoecWc0FpsSogTMC//h9uTf hlETxtpbiDsU3PvWErEvw9F86icE02EAl/wOOhkVYtjF+G/N7p+9aQKVM0Bz9S4hUOfw TvkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:user-agent:message-id :references:cc:in-reply-to:from:to:content-transfer-encoding :mime-version:dkim-signature; bh=JLSYVhJlDA0FsUQmCUBZqdFzMAGSOmjM6ShNUmwWVwU=; b=d75Wz3jBzI2fK49QgQV6F/2iuaAcQezLysc2ZxwcLX3PHdqslV5em8P8BP4V+rUgXN wOqbaM5GlpewJX2gkqpJTPWeznBMD2rX54QrFgA7BD09b4BEzt5WlViYoCvrQ+i5HL2m 8QkVqCN8dZo2PggRjscwHWr+QKRC6BNJqkb0ZOfvZkHTLljmSna/6Wc4/n3E8Eb/6thD ZnoL2Yaqg6F3czezYevGe8Xvfau7CEMVxLZpVuGc6HZrRZ0niEGjuG584xiZHjlzpIqh 7ktkqwHBlnYulJc+bbQRDN8UbFVQ7Dshz5vd9MsesCdu4KXYPmuEOQYN0huHbkxC1glV BMjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AyADrIuV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l26-v6si1183301pgb.251.2018.09.26.23.51.40; Wed, 26 Sep 2018 23:51:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AyADrIuV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727273AbeI0NH5 (ORCPT + 99 others); Thu, 27 Sep 2018 09:07:57 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:44866 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726951AbeI0NH5 (ORCPT ); Thu, 27 Sep 2018 09:07:57 -0400 Received: by mail-pg1-f195.google.com with SMTP id g2-v6so1169738pgu.11 for ; Wed, 26 Sep 2018 23:51:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:to:from:in-reply-to:cc :references:message-id:user-agent:subject:date; bh=JLSYVhJlDA0FsUQmCUBZqdFzMAGSOmjM6ShNUmwWVwU=; b=AyADrIuVK2yoN3v6nPngeWweFqt7dOe8jPTHd6ETEsp9EN4YjvMBxT3ztuk2ZZ8eFt yw89DHtlSPoIXlTYy+IHEtp++up3pfMK190LUk/1SLEz5hAz8M6CmTnF0Ue6Wdlf6g+R NfPeTJxARVsu9Wj9vapgRKBmQErzPbyWUakdA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding:to:from :in-reply-to:cc:references:message-id:user-agent:subject:date; bh=JLSYVhJlDA0FsUQmCUBZqdFzMAGSOmjM6ShNUmwWVwU=; b=jX/kU2/+FxMcWO9bTshErKL4qS+y29Bmq17bnkrTEXOlfSKrJ17th1k8wbFrmqZM5s iKkiPzTEWMCYvimE8apBhiYbaQSISpHJgDcGVAqbs/udaV9t4/pBgNV7mZMd2GNa3vTa 83UznBjvrnclAnskN6vMEWsU5U14FtARkGHCuP/woO6FpyxcKmShuvaxD3P5cW6BXS26 y9xDjifFNXhZzZLVuxozKvPZmcXs+2ZiO3weZ3MguyWuLXq+nTInrCOXUAH85eRLQ7+j 0PNKL2mvHOo8vO4ydkCUdiA7jxtVjjZClM5MTomXkEs8An4pkCEGBhO54eXaIrIj5fmK YIqg== X-Gm-Message-State: ABuFfojzgVaiZjY/BFYT+ZHosddrqrvz9wclgTgZX/kZBEhm9NIWmwsT ptTd34W3/amfaA3fHTXfsmQZKemDT34= X-Received: by 2002:a62:f58a:: with SMTP id b10-v6mr9854308pfm.253.1538031074595; Wed, 26 Sep 2018 23:51:14 -0700 (PDT) Received: from localhost ([2620:15c:202:201:7e28:b9f3:6afc:5326]) by smtp.gmail.com with ESMTPSA id k26-v6sm2169935pfb.167.2018.09.26.23.51.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 Sep 2018 23:51:13 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: LKML , Linus Walleij , Ricardo Ribalda Delgado , Timur Tabi , linux-gpio@vger.kernel.org From: Stephen Boyd In-Reply-To: <20180921103604.13361-2-ricardo.ribalda@gmail.com> Cc: Ricardo Ribalda Delgado References: <20180921103604.13361-1-ricardo.ribalda@gmail.com> <20180921103604.13361-2-ricardo.ribalda@gmail.com> Message-ID: <153803107307.119890.10052910965015646333@swboyd.mtv.corp.google.com> User-Agent: alot/0.7 Subject: Re: [PATCH v2] gpiolib: Show correct direction from the beginning Date: Wed, 26 Sep 2018 23:51:13 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Ricardo Ribalda Delgado (2018-09-21 03:36:04) > Current code assumes that the direction is input if direction_input > function is set. > This might not be the case on GPIOs with programmable direction. > = > Signed-off-by: Ricardo Ribalda Delgado > --- Looks OK to me visually. I haven't tested it because I don't have access to the locked down hardware anymore. Reviewed-by: Stephen Boyd