Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1756648imm; Thu, 27 Sep 2018 01:53:56 -0700 (PDT) X-Google-Smtp-Source: ACcGV639stR5WFtkL10j7SamfOSMzzKl/dDBpvOmhsoo3QqJEc7Ic7/1vtymAstSATKatIL/uVPp X-Received: by 2002:a62:d40d:: with SMTP id a13-v6mr4666971pfh.23.1538038436527; Thu, 27 Sep 2018 01:53:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538038436; cv=none; d=google.com; s=arc-20160816; b=awtaZ1VTVv7+l93+/6vAhVJhj+0mVXeg4dXNPb2NExdiT1iKLfOvzimLzhrYrvXG8E tvOS5a1Xp9DfUFWd7dhNuQkdaPpddZFR+dpmVvoVhD/2AvPN2Zcdq9gmjCqtcjScqb1k kCQCsoq5BMlrdzjir1McYbcbzfMj1xgypK1PyNIlPeesq9oE4xJQw1TUD00bYhblv7MU MquEiSo+bOGqcPtHsKz/AfCzj7pe+buhpGEpZzJ2We/KDwSJ26d7LmR35zD9ZNVDNYBU qq0UgSpck2JmeXNAzT77/UBoFnuVNPrlDzjQyMDlkeu5BkzqNCj++VQ5AxLHaymHR9YO Q+2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=EVF2qmSWjnr+7QUmdDQD9xCx7faaIdACGhZ36N7M4j4=; b=S1aGRU+TfdNt+qVxhifWf6uQrpzKGSlycMnyzxbXy85zE7apHnsqfLS97my+YuPBfO R3Uo/9XNANhuqdmIF/j2X2LSewOgqbDJusa1myB8DBLCha6WqJqGFEwvLYmhgYg5Ex5+ KxIrPI8UcfRqnDhNzOJ7tVlcUnFjdRlug8PkTYofMlFVPdF4aV3nMUttJyX4wPo1inLj RABl77arzw0JhHCXzh1CCi8xxePdcULBr6kxqiHP5fq41RN67B1xfFttO00BgdfeTGcV xLrP9ySob2PCd9k31lktw25t1gfQgNrp0g+dJC7qEkj+tbG9juyoZCBjqgh4yMWFtVlm z5Ww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r18-v6si1447494pgb.578.2018.09.27.01.53.41; Thu, 27 Sep 2018 01:53:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727108AbeI0PIG (ORCPT + 99 others); Thu, 27 Sep 2018 11:08:06 -0400 Received: from foss.arm.com ([217.140.101.70]:59096 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726947AbeI0PIG (ORCPT ); Thu, 27 Sep 2018 11:08:06 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ACEF77A9; Thu, 27 Sep 2018 01:50:56 -0700 (PDT) Received: from [10.37.10.73] (unknown [10.37.10.73]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 49B543F5B3; Thu, 27 Sep 2018 01:50:54 -0700 (PDT) Subject: Re: [PATCH v2 04/11] arm64: dts: sc9836/sc9860: Update coresight bindings for hardware ports To: linux-arm-kernel@lists.infradead.org, Chunyan Zhang Cc: mathieu.poirier@linaro.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh@kernel.org, frowand.list@gmail.com, coresight@lists.linaro.org, leo.yan@linaro.org, orsonzhai@gmail.com, zhang.lyra@gmail.com References: <20180912135352.19722-1-suzuki.poulose@arm.com> <20180912135352.19722-5-suzuki.poulose@arm.com> From: Suzuki K Poulose Message-ID: Date: Thu, 27 Sep 2018 09:51:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180912135352.19722-5-suzuki.poulose@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +To: Chunyan Zhang Chunyan Zhang, On 09/12/2018 02:53 PM, Suzuki K Poulose wrote: > Switch to the new coresight bindings for hw ports > How can we push this patch ? Do you generally send the spreadtrum specific changes to ARM soc folks ? Or would you like me to post this directly to ARM soc folks ? Suzuki > Cc: orsonzhai@gmail.com > Cc: zhang.lyra@gmail.com > Cc: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- > arch/arm64/boot/dts/sprd/sc9836.dtsi | 82 +++++----- > arch/arm64/boot/dts/sprd/sc9860.dtsi | 215 ++++++++++++++------------- > 2 files changed, 153 insertions(+), 144 deletions(-) > > diff --git a/arch/arm64/boot/dts/sprd/sc9836.dtsi b/arch/arm64/boot/dts/sprd/sc9836.dtsi > index 63894c456969..4bcdbb709c01 100644 > --- a/arch/arm64/boot/dts/sprd/sc9836.dtsi > +++ b/arch/arm64/boot/dts/sprd/sc9836.dtsi > @@ -50,10 +50,11 @@ > reg = <0 0x10003000 0 0x1000>; > clocks = <&clk26mhz>; > clock-names = "apb_pclk"; > - port { > - etf_in: endpoint { > - slave-mode; > - remote-endpoint = <&funnel_out_port0>; > + in-ports { > + port { > + etf_in: endpoint { > + remote-endpoint = <&funnel_out_port0>; > + }; > }; > }; > }; > @@ -63,55 +64,50 @@ > reg = <0 0x10001000 0 0x1000>; > clocks = <&clk26mhz>; > clock-names = "apb_pclk"; > - ports { > + > + out-ports { > + port { > + funnel_out_port0: endpoint { > + remote-endpoint = <&etf_in>; > + }; > + }; > + }; > + > + in-ports { > #address-cells = <1>; > #size-cells = <0>; > > - /* funnel output port */ > port@0 { > - reg = <0>; > - funnel_out_port0: endpoint { > - remote-endpoint = <&etf_in>; > - }; > - }; > - > - /* funnel input port 0-4 */ > - port@1 { > reg = <0>; > funnel_in_port0: endpoint { > - slave-mode; > remote-endpoint = <&etm0_out>; > }; > }; > > - port@2 { > + port@1 { > reg = <1>; > funnel_in_port1: endpoint { > - slave-mode; > remote-endpoint = <&etm1_out>; > }; > }; > > - port@3 { > + port@2 { > reg = <2>; > funnel_in_port2: endpoint { > - slave-mode; > remote-endpoint = <&etm2_out>; > }; > }; > > - port@4 { > + port@3 { > reg = <3>; > funnel_in_port3: endpoint { > - slave-mode; > remote-endpoint = <&etm3_out>; > }; > }; > > - port@5 { > + port@4 { > reg = <4>; > funnel_in_port4: endpoint { > - slave-mode; > remote-endpoint = <&stm_out>; > }; > }; > @@ -126,9 +122,11 @@ > cpu = <&cpu0>; > clocks = <&clk26mhz>; > clock-names = "apb_pclk"; > - port { > - etm0_out: endpoint { > - remote-endpoint = <&funnel_in_port0>; > + out-ports { > + port { > + etm0_out: endpoint { > + remote-endpoint = <&funnel_in_port0>; > + }; > }; > }; > }; > @@ -140,9 +138,11 @@ > cpu = <&cpu1>; > clocks = <&clk26mhz>; > clock-names = "apb_pclk"; > - port { > - etm1_out: endpoint { > - remote-endpoint = <&funnel_in_port1>; > + out-ports { > + port { > + etm1_out: endpoint { > + remote-endpoint = <&funnel_in_port1>; > + }; > }; > }; > }; > @@ -154,9 +154,11 @@ > cpu = <&cpu2>; > clocks = <&clk26mhz>; > clock-names = "apb_pclk"; > - port { > - etm2_out: endpoint { > - remote-endpoint = <&funnel_in_port2>; > + out-ports { > + port { > + etm2_out: endpoint { > + remote-endpoint = <&funnel_in_port2>; > + }; > }; > }; > }; > @@ -168,9 +170,11 @@ > cpu = <&cpu3>; > clocks = <&clk26mhz>; > clock-names = "apb_pclk"; > - port { > - etm3_out: endpoint { > - remote-endpoint = <&funnel_in_port3>; > + out-ports { > + port { > + etm3_out: endpoint { > + remote-endpoint = <&funnel_in_port3>; > + }; > }; > }; > }; > @@ -182,9 +186,11 @@ > reg-names = "stm-base", "stm-stimulus-base"; > clocks = <&clk26mhz>; > clock-names = "apb_pclk"; > - port { > - stm_out: endpoint { > - remote-endpoint = <&funnel_in_port4>; > + out-ports { > + port { > + stm_out: endpoint { > + remote-endpoint = <&funnel_in_port4>; > + }; > }; > }; > }; > diff --git a/arch/arm64/boot/dts/sprd/sc9860.dtsi b/arch/arm64/boot/dts/sprd/sc9860.dtsi > index 48f5928ed45c..5f57bf055cde 100644 > --- a/arch/arm64/boot/dts/sprd/sc9860.dtsi > +++ b/arch/arm64/boot/dts/sprd/sc9860.dtsi > @@ -304,30 +304,29 @@ > reg = <0 0x10001000 0 0x1000>; > clocks = <&ext_26m>; > clock-names = "apb_pclk"; > - ports { > - #address-cells = <1>; > - #size-cells = <0>; > - > - port@0 { > - reg = <0>; > + out-ports { > + port { > soc_funnel_out_port: endpoint { > remote-endpoint = <&etb_in>; > }; > }; > + }; > > - port@1 { > + in-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > reg = <0>; > soc_funnel_in_port0: endpoint { > - slave-mode; > remote-endpoint = > <&main_funnel_out_port>; > }; > }; > > - port@2 { > + port@4 { > reg = <4>; > soc_funnel_in_port1: endpoint { > - slave-mode; > remote-endpoint = > <&stm_out_port>; > }; > @@ -340,11 +339,12 @@ > reg = <0 0x10003000 0 0x1000>; > clocks = <&ext_26m>; > clock-names = "apb_pclk"; > - port { > - etb_in: endpoint { > - slave-mode; > - remote-endpoint = > - <&soc_funnel_out_port>; > + out-ports { > + port { > + etb_in: endpoint { > + remote-endpoint = > + <&soc_funnel_out_port>; > + }; > }; > }; > }; > @@ -356,10 +356,12 @@ > reg-names = "stm-base", "stm-stimulus-base"; > clocks = <&ext_26m>; > clock-names = "apb_pclk"; > - port { > - stm_out_port: endpoint { > - remote-endpoint = > - <&soc_funnel_in_port1>; > + out-ports { > + port { > + stm_out_port: endpoint { > + remote-endpoint = > + <&soc_funnel_in_port1>; > + }; > }; > }; > }; > @@ -369,38 +371,36 @@ > reg = <0 0x11001000 0 0x1000>; > clocks = <&ext_26m>; > clock-names = "apb_pclk"; > - ports { > - #address-cells = <1>; > - #size-cells = <0>; > - > - port@0 { > - reg = <0>; > + out-ports { > + port { > cluster0_funnel_out_port: endpoint { > remote-endpoint = > <&cluster0_etf_in>; > }; > }; > + }; > > - port@1 { > + in-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > reg = <0>; > cluster0_funnel_in_port0: endpoint { > - slave-mode; > remote-endpoint = <&etm0_out>; > }; > }; > > - port@2 { > + port@1 { > reg = <1>; > cluster0_funnel_in_port1: endpoint { > - slave-mode; > remote-endpoint = <&etm1_out>; > }; > }; > > - port@3 { > + port@2 { > reg = <2>; > cluster0_funnel_in_port2: endpoint { > - slave-mode; > remote-endpoint = <&etm2_out>; > }; > }; > @@ -408,7 +408,6 @@ > port@4 { > reg = <4>; > cluster0_funnel_in_port3: endpoint { > - slave-mode; > remote-endpoint = <&etm3_out>; > }; > }; > @@ -420,46 +419,43 @@ > reg = <0 0x11002000 0 0x1000>; > clocks = <&ext_26m>; > clock-names = "apb_pclk"; > - ports { > - #address-cells = <1>; > - #size-cells = <0>; > - > - port@0 { > - reg = <0>; > + out-ports { > + port { > cluster1_funnel_out_port: endpoint { > remote-endpoint = > <&cluster1_etf_in>; > }; > }; > + }; > > - port@1 { > + in-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > reg = <0>; > cluster1_funnel_in_port0: endpoint { > - slave-mode; > remote-endpoint = <&etm4_out>; > }; > }; > > - port@2 { > + port@1 { > reg = <1>; > cluster1_funnel_in_port1: endpoint { > - slave-mode; > remote-endpoint = <&etm5_out>; > }; > }; > > - port@3 { > + port@2 { > reg = <2>; > cluster1_funnel_in_port2: endpoint { > - slave-mode; > remote-endpoint = <&etm6_out>; > }; > }; > > - port@4 { > + port@3 { > reg = <3>; > cluster1_funnel_in_port3: endpoint { > - slave-mode; > remote-endpoint = <&etm7_out>; > }; > }; > @@ -472,22 +468,18 @@ > clocks = <&ext_26m>; > clock-names = "apb_pclk"; > > - ports { > - #address-cells = <1>; > - #size-cells = <0>; > - > - port@0 { > - reg = <0>; > + out-ports { > + port { > cluster0_etf_out: endpoint { > remote-endpoint = > <&main_funnel_in_port0>; > }; > }; > + }; > > - port@1 { > - reg = <0>; > + in-ports { > + port { > cluster0_etf_in: endpoint { > - slave-mode; > remote-endpoint = > <&cluster0_funnel_out_port>; > }; > @@ -501,22 +493,18 @@ > clocks = <&ext_26m>; > clock-names = "apb_pclk"; > > - ports { > - #address-cells = <1>; > - #size-cells = <0>; > - > - port@0 { > - reg = <0>; > + out-ports { > + port { > cluster1_etf_out: endpoint { > remote-endpoint = > <&main_funnel_in_port1>; > }; > }; > + }; > > - port@1 { > - reg = <0>; > + in-ports { > + port { > cluster1_etf_in: endpoint { > - slave-mode; > remote-endpoint = > <&cluster1_funnel_out_port>; > }; > @@ -530,31 +518,30 @@ > clocks = <&ext_26m>; > clock-names = "apb_pclk"; > > - ports { > - #address-cells = <1>; > - #size-cells = <0>; > - > - port@0 { > - reg = <0>; > + out-ports { > + port { > main_funnel_out_port: endpoint { > remote-endpoint = > <&soc_funnel_in_port0>; > }; > }; > + }; > > - port@1 { > + in-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > reg = <0>; > main_funnel_in_port0: endpoint { > - slave-mode; > remote-endpoint = > <&cluster0_etf_out>; > }; > }; > > - port@2 { > + port@1 { > reg = <1>; > main_funnel_in_port1: endpoint { > - slave-mode; > remote-endpoint = > <&cluster1_etf_out>; > }; > @@ -569,10 +556,12 @@ > clocks = <&ext_26m>; > clock-names = "apb_pclk"; > > - port { > - etm0_out: endpoint { > - remote-endpoint = > - <&cluster0_funnel_in_port0>; > + out-ports { > + port { > + etm0_out: endpoint { > + remote-endpoint = > + <&cluster0_funnel_in_port0>; > + }; > }; > }; > }; > @@ -584,10 +573,12 @@ > clocks = <&ext_26m>; > clock-names = "apb_pclk"; > > - port { > - etm1_out: endpoint { > - remote-endpoint = > - <&cluster0_funnel_in_port1>; > + out-ports { > + port { > + etm1_out: endpoint { > + remote-endpoint = > + <&cluster0_funnel_in_port1>; > + }; > }; > }; > }; > @@ -599,10 +590,12 @@ > clocks = <&ext_26m>; > clock-names = "apb_pclk"; > > - port { > - etm2_out: endpoint { > - remote-endpoint = > - <&cluster0_funnel_in_port2>; > + out-ports { > + port { > + etm2_out: endpoint { > + remote-endpoint = > + <&cluster0_funnel_in_port2>; > + }; > }; > }; > }; > @@ -614,10 +607,12 @@ > clocks = <&ext_26m>; > clock-names = "apb_pclk"; > > - port { > - etm3_out: endpoint { > - remote-endpoint = > - <&cluster0_funnel_in_port3>; > + out-ports { > + port { > + etm3_out: endpoint { > + remote-endpoint = > + <&cluster0_funnel_in_port3>; > + }; > }; > }; > }; > @@ -629,10 +624,12 @@ > clocks = <&ext_26m>; > clock-names = "apb_pclk"; > > - port { > - etm4_out: endpoint { > - remote-endpoint = > - <&cluster1_funnel_in_port0>; > + out-ports { > + port { > + etm4_out: endpoint { > + remote-endpoint = > + <&cluster1_funnel_in_port0>; > + }; > }; > }; > }; > @@ -644,10 +641,12 @@ > clocks = <&ext_26m>; > clock-names = "apb_pclk"; > > - port { > - etm5_out: endpoint { > - remote-endpoint = > - <&cluster1_funnel_in_port1>; > + out-ports { > + port { > + etm5_out: endpoint { > + remote-endpoint = > + <&cluster1_funnel_in_port1>; > + }; > }; > }; > }; > @@ -659,10 +658,12 @@ > clocks = <&ext_26m>; > clock-names = "apb_pclk"; > > - port { > - etm6_out: endpoint { > - remote-endpoint = > - <&cluster1_funnel_in_port2>; > + out-ports { > + port { > + etm6_out: endpoint { > + remote-endpoint = > + <&cluster1_funnel_in_port2>; > + }; > }; > }; > }; > @@ -674,10 +675,12 @@ > clocks = <&ext_26m>; > clock-names = "apb_pclk"; > > - port { > - etm7_out: endpoint { > - remote-endpoint = > - <&cluster1_funnel_in_port3>; > + out-ports { > + port { > + etm7_out: endpoint { > + remote-endpoint = > + <&cluster1_funnel_in_port3>; > + }; > }; > }; > }; >