Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\))
Subject: Re: [PATCH] btsdio: Do not bind to non-removable BCM43430
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20180927095455.32247-1-acho@suse.com>
Date:   Thu, 27 Sep 2018 11:59:08 +0200
Cc:     linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
        Johan Hedberg <johan.hedberg@gmail.com>, jlee@suse.com
Content-Transfer-Encoding: 8BIT
Message-Id: <DE21BFD5-3A79-4D64-9DB1-4A2DCDBBE359@holtmann.org>
References: <20180927095455.32247-1-acho@suse.com>
To:     "Cho, Yu-Chen" <acho@suse.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Yu-Chen,

> BCM43430 devices soldered onto the PCB (non-removable)
> use an UART connection for bluetooth.
> But also advertise btsdio support on their 3th sdio function.
> 
> Signed-off-by: Cho, Yu-Chen <acho@suse.com>
> ---
> drivers/bluetooth/btsdio.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/btsdio.c b/drivers/bluetooth/btsdio.c
> index 20142bc77554..84d23d786ce5 100644
> --- a/drivers/bluetooth/btsdio.c
> +++ b/drivers/bluetooth/btsdio.c
> @@ -297,7 +297,8 @@ static int btsdio_probe(struct sdio_func *func,
> 	 * uart connection for bluetooth, ignore the BT SDIO interface.
> 	 */
> 	if (func->vendor == SDIO_VENDOR_ID_BROADCOM &&
> -	    func->device == SDIO_DEVICE_ID_BROADCOM_43341 &&
> +	    (func->device == SDIO_DEVICE_ID_BROADCOM_43341 ||
> +	    func->device == SDIO_DEVICE_ID_BROADCOM_43430) &&
> 	    !mmc_card_is_removable(func->card->host))
> 		return -ENODEV;

This will turn quickly unreadable. Can we turn the func->device test into a switch statement.

	if (!mmc_card_is_rem.. && func->vendor == SDIO_ID..) {
		switch (func->device) {
		case SDIO_DEV..
			return -ENODEV;
	}

Regards

Marcel